Skip to content

Commit ab75aa5

Browse files
authored
Remove unnecessary actionDismissed calls (#506)
1 parent ece76d7 commit ab75aa5

File tree

4 files changed

+0
-6
lines changed

4 files changed

+0
-6
lines changed

AndroidSDKCore/src/main/java/com/leanplum/messagetemplates/controllers/RichHtmlController.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,10 +317,8 @@ private boolean handleActionEvent(String url) {
317317
if (!TextUtils.isEmpty(queryComponentsFromUrl) && actionContext != null) {
318318
if (url.contains(richOptions.getActionUrl())) {
319319
actionContext.runActionNamed(queryComponentsFromUrl);
320-
actionContext.actionDismissed();
321320
} else {
322321
actionContext.runTrackedActionNamed(queryComponentsFromUrl);
323-
actionContext.actionDismissed();
324322
}
325323
}
326324
return true;

AndroidSDKCore/src/main/java/com/leanplum/messagetemplates/options/BaseMessageOptions.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,10 @@ private void setAcceptButtonTextColor(int color) {
153153

154154
public void accept() {
155155
context.runTrackedActionNamed(Args.ACCEPT_ACTION);
156-
context.actionDismissed();
157156
}
158157

159158
public void dismiss() {
160159
context.runActionNamed(Args.DISMISS_ACTION);
161-
context.actionDismissed();
162160
}
163161

164162
public static ActionArgs toArgs(Context currentContext) {

AndroidSDKCore/src/main/java/com/leanplum/messagetemplates/options/RichHtmlOptions.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,5 @@ public boolean isBannerWithTapOutsideFalse() {
375375

376376
public void dismiss() {
377377
actionContext.runActionNamed(Args.DISMISS_ACTION);
378-
actionContext.actionDismissed();
379378
}
380379
}

AndroidSDKCore/src/main/java/com/leanplum/messagetemplates/options/WebInterstitialOptions.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ private void setCloseUrl(String closeUrl) {
7171

7272
public void dismiss() {
7373
actionContext.runActionNamed(Args.DISMISS_ACTION);
74-
actionContext.actionDismissed();
7574
}
7675

7776
public static ActionArgs toArgs() {

0 commit comments

Comments
 (0)