Skip to content

Commit b39d2e7

Browse files
committed
feat(deprecation): fixing pr comments
1 parent ac78ded commit b39d2e7

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

AndroidSDK/src/com/leanplum/LocationManagerImplementation.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,6 +436,8 @@ public void onLocationChanged(Location location) {
436436
/**
437437
* Request location for user location update if googleApiClient is connected.
438438
*/
439+
// Suppressing missing permission warning which since it is up to client to add location
440+
// permission to their manifest.
439441
@SuppressWarnings("MissingPermission")
440442
private void requestLocation() {
441443
if (!Leanplum.isLocationCollectionEnabled() || googleApiClient == null

AndroidSDK/src/com/leanplum/internal/SocketIOClient.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@
4444
import java.util.Arrays;
4545
import java.util.HashSet;
4646

47+
// Suppressing apache dependency deprecation. We should upgrade our socket IO client to new version
48+
// which uses okhttp library.
4749
@SuppressWarnings("deprecation")
4850
class SocketIOClient {
4951
interface Handler {

AndroidSDK/src/com/leanplum/internal/WebSocketClient.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@
5353
import javax.net.ssl.SSLSocketFactory;
5454
import javax.net.ssl.TrustManager;
5555

56+
// Suppressing apache dependency deprecation. We should upgrade our socket IO client to new version
57+
// which uses okhttp library.
5658
@SuppressWarnings("deprecation")
5759
class WebSocketClient {
5860
private static final String TAG = "WebSocketClient";

0 commit comments

Comments
 (0)