Skip to content

Commit b53dc9d

Browse files
authored
Remove info event property from CT migration (#567)
1 parent 28cab25 commit b53dc9d

File tree

5 files changed

+6
-19
lines changed

5 files changed

+6
-19
lines changed

AndroidSDKCore/src/main/java/com/leanplum/Leanplum.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1676,9 +1676,7 @@ private static void setTrafficSourceInfoInternal(HashMap<String, Object> params)
16761676
*/
16771677
public static void track(final String event, double value, String info,
16781678
Map<String, ?> params) {
1679-
LeanplumInternal.addStartIssuedHandler(() -> {
1680-
MigrationManager.getWrapper().track(event, value, info, params);
1681-
});
1679+
LeanplumInternal.addStartIssuedHandler(() -> MigrationManager.getWrapper().track(event, value, params));
16821680
LeanplumInternal.track(event, value, info, params, null);
16831681
}
16841682

@@ -1919,14 +1917,14 @@ public static void advanceTo(final String state, String info, final Map<String,
19191917
}
19201918

19211919
if (LeanplumInternal.issuedStart()) {
1922-
MigrationManager.getWrapper().advanceTo(state, info, params);
1920+
MigrationManager.getWrapper().advanceTo(state, params);
19231921
advanceToInternal(state, validatedParams, requestParams);
19241922
} else {
19251923
LeanplumInternal.addStartIssuedHandler(new Runnable() {
19261924
@Override
19271925
public void run() {
19281926
try {
1929-
MigrationManager.getWrapper().advanceTo(state, info, params);
1927+
MigrationManager.getWrapper().advanceTo(state, params);
19301928
advanceToInternal(state, validatedParams, requestParams);
19311929
} catch (Throwable t) {
19321930
Log.exception(t);

AndroidSDKCore/src/main/java/com/leanplum/migration/MigrationConstants.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ object MigrationConstants {
3333
const val CHARGED_EVENT_PARAM = "event"
3434
const val VALUE_PARAM = "value"
3535
const val CURRENCY_CODE_PARAM = "currencyCode"
36-
const val INFO_PARAM = "info"
3736
const val GP_PURCHASE_DATA_PARAM = "googlePlayPurchaseData"
3837
const val GP_PURCHASE_DATA_SIGNATURE_PARAM = "googlePlayPurchaseDataSignature"
3938
const val IAP_ITEM_PARAM = "item"

AndroidSDKCore/src/main/java/com/leanplum/migration/wrapper/CTWrapper.kt

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,6 @@ internal class CTWrapper(
205205
override fun track(
206206
event: String?,
207207
value: Double,
208-
info: String?,
209208
params: Map<String, Any?>?
210209
) {
211210
if (event == null) return
@@ -219,10 +218,6 @@ internal class CTWrapper(
219218

220219
properties[MigrationConstants.VALUE_PARAM] = value
221220

222-
if (info != null) {
223-
properties[MigrationConstants.INFO_PARAM] = info
224-
}
225-
226221
Log.d("Wrapper: Leanplum.track will call pushEvent with $event and $properties")
227222
cleverTapInstance?.pushEvent(event, properties)
228223
}
@@ -288,18 +283,14 @@ internal class CTWrapper(
288283
/**
289284
* LP doesn't allow iterables in params.
290285
*/
291-
override fun advanceTo(state: String?, info: String?, params: Map<String, Any?>?) {
286+
override fun advanceTo(state: String?, params: Map<String, Any?>?) {
292287
if (state == null) return;
293288

294289
val event = MigrationConstants.STATE_PREFIX + state
295290
val properties =
296291
params?.mapValues(::mapNotSupportedValues)?.toMutableMap()
297292
?: mutableMapOf()
298293

299-
if (info != null) {
300-
properties[MigrationConstants.INFO_PARAM] = info
301-
}
302-
303294
Log.d("Wrapper: Leanplum.advance will call pushEvent with $event and $properties")
304295
cleverTapInstance?.pushEvent(event, properties)
305296
}

AndroidSDKCore/src/main/java/com/leanplum/migration/wrapper/IWrapper.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ interface IWrapper {
4444
fun track(
4545
event: String?,
4646
value: Double,
47-
info: String?,
4847
params: Map<String, Any?>?,
4948
) = Unit
5049

@@ -65,7 +64,7 @@ interface IWrapper {
6564
params: Map<String, Any?>?,
6665
) = Unit
6766

68-
fun advanceTo(state: String?, info: String?, params: Map<String, Any?>?) = Unit
67+
fun advanceTo(state: String?, params: Map<String, Any?>?) = Unit
6968

7069
fun setUserAttributes(attributes: Map<String, Any?>?) = Unit
7170

sdk-version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
7.5.0-beta4
1+
7.5.0-beta5

0 commit comments

Comments
 (0)