Skip to content

Commit e5fccdb

Browse files
authored
Merge pull request #82 from Leanplum/feature/deprecated
feat(deprecation): removing already deprecated methods, deprecating l…
2 parents 5f46a3c + dd6a10c commit e5fccdb

16 files changed

+81
-54
lines changed

AndroidSDK/src/com/leanplum/Leanplum.java

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -243,18 +243,6 @@ public static void setAppIdForProductionMode(String appId, String accessKey) {
243243
Request.setAppId(appId, accessKey);
244244
}
245245

246-
/**
247-
* Enable interface editing via Leanplum.com Visual Editor.
248-
*/
249-
@Deprecated
250-
public static void allowInterfaceEditing() {
251-
if (Constants.isDevelopmentModeEnabled) {
252-
throw new LeanplumException("Leanplum UI Editor has moved to a separate package. " +
253-
"Please remove this method call and include this line in your build.gradle: " +
254-
"compile 'com.leanplum:UIEditor:+'");
255-
}
256-
}
257-
258246
/**
259247
* Enable screen tracking.
260248
*/
@@ -330,20 +318,6 @@ public static Context getContext() {
330318
return context;
331319
}
332320

333-
/**
334-
* Called when the device needs to be registered in development mode.
335-
*/
336-
@Deprecated
337-
public static void setRegisterDeviceHandler(RegisterDeviceCallback handler,
338-
RegisterDeviceFinishedCallback finishHandler) {
339-
if (handler == null && finishHandler == null) {
340-
Log.w("setRegisterDeviceHandler - Invalid handler parameter provided.");
341-
}
342-
343-
registerDeviceHandler = handler;
344-
registerDeviceFinishedHandler = finishHandler;
345-
}
346-
347321
/**
348322
* Syncs resources between Leanplum and the current app. You should only call this once, and
349323
* before {@link Leanplum#start}. syncResourcesAsync should be used instead unless file variables
@@ -1301,12 +1275,6 @@ public static void defineAction(String name, int kind, ActionArgs args) {
13011275
defineAction(name, kind, args, null, null);
13021276
}
13031277

1304-
@Deprecated
1305-
static void defineAction(String name, int kind, ActionArgs args,
1306-
Map<String, Object> options) {
1307-
defineAction(name, kind, args, options, null);
1308-
}
1309-
13101278
/**
13111279
* Defines an action that is used within Leanplum Marketing Automation. Actions can be set up to
13121280
* get triggered based on app opens, events, and states.

AndroidSDK/src/com/leanplum/LeanplumEditorMode.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@
2525
* Enum for describing the Editor Mode.
2626
*
2727
* @author Ben Marten
28+
* @deprecated {@link LeanplumEditorMode} will be made private in future releases, since it is not
29+
* intended to be public API.
2830
*/
31+
@Deprecated
2932
public enum LeanplumEditorMode {
3033
LP_EDITOR_MODE_INTERFACE(0),
3134
LP_EDITOR_MODE_EVENT(1);

AndroidSDK/src/com/leanplum/LeanplumFcmServiceHelper.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
* Helper class for enabling the FCM service declared in manifest without app restart.
3030
*
3131
* @author Anna Orlova
32+
* @deprecated {@link LeanplumFcmServiceHelper} will be made private in future releases, since it is
33+
* not intended to be public API.
3234
*/
3335
class LeanplumFcmServiceHelper extends IntentService {
3436
public LeanplumFcmServiceHelper() {

AndroidSDK/src/com/leanplum/LeanplumUIEditor.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@
2525

2626
/**
2727
* Describes the API of the visual editor package.
28+
*
29+
* @deprecated {@link LeanplumUIEditor} will be made private in future releases, since it is not
30+
* intended to be public API.
2831
*/
32+
@Deprecated
2933
public interface LeanplumUIEditor {
3034
/**
3135
* Enable interface editing via Leanplum.com Visual Editor.

AndroidSDK/src/com/leanplum/activities/LeanplumAccountAuthenticatorActivity.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,17 @@
2222
package com.leanplum.activities;
2323

2424
import android.accounts.AccountAuthenticatorActivity;
25-
import android.annotation.SuppressLint;
2625
import android.content.res.Resources;
2726

2827
import com.leanplum.Leanplum;
2928
import com.leanplum.LeanplumActivityHelper;
3029

31-
@SuppressLint("Registered")
30+
/**
31+
* @deprecated due to rising minimal API to 14. This class will be removed in a
32+
* future major release. Please use {@link LeanplumActivityHelper} to track your activities
33+
* automatically.
34+
*/
35+
@Deprecated
3236
public class LeanplumAccountAuthenticatorActivity extends AccountAuthenticatorActivity {
3337
private LeanplumActivityHelper helper;
3438

AndroidSDK/src/com/leanplum/activities/LeanplumActivity.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,12 @@
2727
import com.leanplum.Leanplum;
2828
import com.leanplum.LeanplumActivityHelper;
2929

30+
/**
31+
* @deprecated due to rising minimal API to 14. This class will be removed in a
32+
* future major release. Please use {@link LeanplumActivityHelper} to track your activities
33+
* automatically.
34+
*/
35+
@Deprecated
3036
public abstract class LeanplumActivity extends Activity {
3137
private LeanplumActivityHelper helper;
3238

AndroidSDK/src/com/leanplum/activities/LeanplumActivityGroup.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,18 @@
2121

2222
package com.leanplum.activities;
2323

24-
import android.annotation.SuppressLint;
2524
import android.app.ActivityGroup;
2625
import android.content.res.Resources;
2726

2827
import com.leanplum.Leanplum;
2928
import com.leanplum.LeanplumActivityHelper;
3029

31-
@SuppressLint("Registered")
32-
@SuppressWarnings("deprecation")
30+
/**
31+
* @deprecated due to rising minimal API to 14. This class will be removed in a
32+
* future major release. Please use {@link LeanplumActivityHelper} to track your activities
33+
* automatically.
34+
*/
35+
@Deprecated
3336
public class LeanplumActivityGroup extends ActivityGroup {
3437
private LeanplumActivityHelper helper;
3538

AndroidSDK/src/com/leanplum/activities/LeanplumAliasActivity.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,18 @@
2121

2222
package com.leanplum.activities;
2323

24-
import android.annotation.SuppressLint;
2524
import android.app.AliasActivity;
2625
import android.content.res.Resources;
2726

2827
import com.leanplum.Leanplum;
2928
import com.leanplum.LeanplumActivityHelper;
3029

31-
@SuppressLint("Registered")
30+
/**
31+
* @deprecated due to rising minimal API to 14. This class will be removed in a
32+
* future major release. Please use {@link LeanplumActivityHelper} to track your activities
33+
* automatically.
34+
*/
35+
@Deprecated
3236
public class LeanplumAliasActivity extends AliasActivity {
3337
private LeanplumActivityHelper helper;
3438

AndroidSDK/src/com/leanplum/activities/LeanplumAppCompatActivity.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,18 @@
2121

2222
package com.leanplum.activities;
2323

24-
import android.annotation.SuppressLint;
2524
import android.content.res.Resources;
2625
import android.support.v7.app.AppCompatActivity;
2726

2827
import com.leanplum.Leanplum;
2928
import com.leanplum.LeanplumActivityHelper;
3029

31-
@SuppressLint("Registered")
30+
/**
31+
* @deprecated due to rising minimal API to 14. This class will be removed in a
32+
* future major release. Please use {@link LeanplumActivityHelper} to track your activities
33+
* automatically.
34+
*/
35+
@Deprecated
3236
public class LeanplumAppCompatActivity extends AppCompatActivity {
3337
private LeanplumActivityHelper helper;
3438

AndroidSDK/src/com/leanplum/activities/LeanplumExpandableListActivity.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,18 @@
2121

2222
package com.leanplum.activities;
2323

24-
import android.annotation.SuppressLint;
2524
import android.app.ExpandableListActivity;
2625
import android.content.res.Resources;
2726

2827
import com.leanplum.Leanplum;
2928
import com.leanplum.LeanplumActivityHelper;
3029

31-
@SuppressLint("Registered")
30+
/**
31+
* @deprecated due to rising minimal API to 14. This class will be removed in a
32+
* future major release. Please use {@link LeanplumActivityHelper} to track your activities
33+
* automatically.
34+
*/
35+
@Deprecated
3236
public class LeanplumExpandableListActivity extends ExpandableListActivity {
3337
private LeanplumActivityHelper helper;
3438

0 commit comments

Comments
 (0)