remove deprecated class LPRequestStorage (#192)

Author: e7mac

Example/Leanplum-SDK.xcodeproj/project.pbxproj

@@ -22,7 +22,6 @@
 		07E5C8B81F052B7800A4B092 /* MessagesTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 07E5C8801F052B7800A4B092 /* MessagesTest.m */; };
 		07E5C8B91F052B7800A4B092 /* LPMessageTemplatesClassTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 07E5C8811F052B7800A4B092 /* LPMessageTemplatesClassTest.m */; };
 		07E5C8BA1F052B7800A4B092 /* NewsfeedTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 07E5C8821F052B7800A4B092 /* NewsfeedTest.m */; };
-		07E5C8BB1F052B7800A4B092 /* LPRequestStorageTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 07E5C8831F052B7800A4B092 /* LPRequestStorageTest.m */; };
 		07E5C8BD1F052B7800A4B092 /* LeanplumHelper.m in Sources */ = {isa = PBXBuildFile; fileRef = 07E5C8881F052B7800A4B092 /* LeanplumHelper.m */; };
 		07E5C8BE1F052B7800A4B092 /* LPUtilsTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 07E5C8891F052B7800A4B092 /* LPUtilsTest.m */; };
 		07E5C8BF1F052B7800A4B092 /* GoldIcon.png in Resources */ = {isa = PBXBuildFile; fileRef = 07E5C88C1F052B7800A4B092 /* GoldIcon.png */; };
@@ -138,7 +137,6 @@
 		07E5C8801F052B7800A4B092 /* MessagesTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = MessagesTest.m; sourceTree = "<group>"; };
 		07E5C8811F052B7800A4B092 /* LPMessageTemplatesClassTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = LPMessageTemplatesClassTest.m; sourceTree = "<group>"; };
 		07E5C8821F052B7800A4B092 /* NewsfeedTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = NewsfeedTest.m; sourceTree = "<group>"; };
-		07E5C8831F052B7800A4B092 /* LPRequestStorageTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = LPRequestStorageTest.m; sourceTree = "<group>"; };
 		07E5C8871F052B7800A4B092 /* LeanplumHelper.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = LeanplumHelper.h; sourceTree = "<group>"; };
 		07E5C8881F052B7800A4B092 /* LeanplumHelper.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = LeanplumHelper.m; sourceTree = "<group>"; };
 		07E5C8891F052B7800A4B092 /* LPUtilsTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = LPUtilsTest.m; sourceTree = "<group>"; };
@@ -262,7 +260,6 @@
 				07E5C8801F052B7800A4B092 /* MessagesTest.m */,
 				07E5C8811F052B7800A4B092 /* LPMessageTemplatesClassTest.m */,
 				07E5C8821F052B7800A4B092 /* NewsfeedTest.m */,
-				07E5C8831F052B7800A4B092 /* LPRequestStorageTest.m */,
 				07E5C8841F052B7800A4B092 /* Utilities */,
 				07E5C8891F052B7800A4B092 /* LPUtilsTest.m */,
 			);
@@ -819,7 +816,6 @@
 				07E5C8B21F052B7800A4B092 /* LPNetworkOperation+Category.m in Sources */,
 				07E5C8B91F052B7800A4B092 /* LPMessageTemplatesClassTest.m in Sources */,
 				07E5C8B11F052B7800A4B092 /* LPNetworkEngine+Category.m in Sources */,
-				07E5C8BB1F052B7800A4B092 /* LPRequestStorageTest.m in Sources */,
 				07E5C8B61F052B7800A4B092 /* LeanplumTest.m in Sources */,
 				07E5C8AD1F052B7800A4B092 /* LPEventDataManagerTest.m in Sources */,
 				07E5C8AE1F052B7800A4B092 /* ExceptionsTest.m in Sources */,

Example/Tests/Classes/LPEventDataManagerTest.m

@@ -27,7 +27,6 @@
 #import <OHHTTPStubs/OHHTTPStubs.h>
 #import <OHHTTPStubs/OHPathHelpers.h>
 #import "LeanplumHelper.h"
-#import "LPRequestStorage.h"
 #import "LPEventDataManager.h"
 #import "LPDatabase.h"
 #import "Constants.h"
@@ -36,20 +35,6 @@
 #import "LeanplumReachability+Category.h"
 #import "LPJSON.h"
 
-/**
- * Expose private class methods
- */
-@interface LPRequestStorage(UnitTest)
-
-- (void)migrateRequests;
-- (void)saveRequests:(NSMutableArray *)requests;
-- (NSMutableArray *)loadRequests;
-- (NSString *)cacheFilePath;
-- (NSString *)documentsFilePath;
-+ (NSString *)itemKeyForIndex:(NSUInteger)index;
-
-@end
-
 @interface LPEventDataManager(UnitTest)
 
 + (void)migrateRequests;
@@ -84,22 +69,6 @@ - (NSDictionary *)sampleData
              @"sdkVersion":@"3", @"devMode":@NO, @"time":@"1489007921.162919"};
 }
 
-- (void)test_migrateRequests
-{
-    // Clean up.
-    [[LeanplumRequest sendNowQueue] cancelAllOperations];
-    [[LeanplumRequest sendNowQueue] waitUntilAllOperationsAreFinished];
-    
-    [LPEventDataManager deleteEventsWithLimit:10000];
-    
-    [[LPRequestStorage sharedStorage] popAllRequests];
-    [[LPRequestStorage sharedStorage] pushRequest:[self sampleData]];
-    
-    [LPEventDataManager migrateRequests];
-    NSArray *events = [LPEventDataManager eventsWithLimit:10000];
-    XCTAssertTrue(events.count == 1);
-}
-
 - (void)test_publicEventMethods
 {
     [LPEventDataManager deleteEventsWithLimit:10000];

Example/Tests/Classes/LPRequestStorageTest.m

@@ -25,24 +25,9 @@
 #import "LPEventDataManager.h"
 #import "LPDatabase.h"
 #import "LPJSON.h"
-#import "LPRequestStorage.h"
 
 @implementation LPEventDataManager
 
-+ (void)load
-{
-    [LPEventDataManager migrateRequests];
-}
-
-+ (void)migrateRequests
-{
-    LPRequestStorage *requestStorage = [LPRequestStorage sharedStorage];
-    if ([[NSFileManager defaultManager] fileExistsAtPath:requestStorage.documentsFilePath]) {
-        NSArray *requests = [requestStorage popAllRequests];
-        [LPEventDataManager addEvents:requests];
-    }
-}
-
 + (void)addEvent:(NSDictionary *)event
 {
     NSString *query = @"INSERT INTO event (data) VALUES (?);";