Counting client ios (#212)

* refactor sendAllCounts for easy testing

* test sendAndClearCounts and makeParams

* fix nonnull int

* change SDK_COUNT to sdkCount

Author: gg4race

Example/Tests/Classes/LPCountAggregatorTest.m

@@ -123,7 +123,7 @@ - (void)test_makeParams {
     NSString *testString = @"test";
     NSMutableDictionary *params = [countAggregator makeParams:testString withCount:2];
 
-    XCTAssert([params[LP_PARAM_TYPE] isEqualToString:@"SDK_COUNT"]);
+    XCTAssert([params[LP_PARAM_TYPE] isEqualToString:LP_VALUE_SDK_COUNT]);
     XCTAssert([params[LP_PARAM_MESSAGE] isEqualToString:testString]);
     XCTAssert([params[LP_PARAM_COUNT] intValue] == 2);
 }

Leanplum-SDK/Classes/Internal/Constants.h

@@ -288,6 +288,7 @@ OBJC_EXPORT NSString *LP_VALUE_CHAIN_MESSAGE_ACTION_NAME;
 OBJC_EXPORT NSString *LP_VALUE_DEFAULT_PUSH_ACTION;
 OBJC_EXPORT NSString *LP_VALUE_DEFAULT_PUSH_MESSAGE;
 OBJC_EXPORT NSString *LP_VALUE_SDK_LOG;
+OBJC_EXPORT NSString *LP_VALUE_SDK_COUNT;
 OBJC_EXPORT NSString *LP_VALUE_SDK_ERROR;
 OBJC_EXPORT NSString *LP_VALUE_SDK_START_LATENCY;
 

Leanplum-SDK/Classes/Internal/Constants.m

@@ -224,6 +224,7 @@ - (id)init {
 NSString *LP_VALUE_DEFAULT_PUSH_ACTION = @"Open action";
 NSString *LP_VALUE_DEFAULT_PUSH_MESSAGE = @"Push message goes here.";
 NSString *LP_VALUE_SDK_LOG = @"sdkLog";
+NSString *LP_VALUE_SDK_COUNT = @"sdkCount";
 NSString *LP_VALUE_SDK_ERROR = @"sdkError";
 NSString *LP_VALUE_SDK_START_LATENCY = @"sdkStartLatency";
 

Leanplum-SDK/Classes/Managers/LPCountAggregator.m

@@ -77,7 +77,8 @@ - (NSDictionary *)getAndClearCounts {
 
 - (NSMutableDictionary *)makeParams:(nonnull NSString *)name withCount:(int) count {
     NSMutableDictionary *params = [[NSMutableDictionary alloc] init];
-    params[LP_PARAM_TYPE] = @"SDK_COUNT";
+
+    params[LP_PARAM_TYPE] = LP_VALUE_SDK_COUNT;
     params[LP_PARAM_MESSAGE] = name;
     params[LP_PARAM_COUNT] = [NSNumber numberWithInt:count];
     return params;