Skip to content

Commit 4e11391

Browse files
MaitreyaBuddhagg4race
authored andcommitted
Use proper “name” arg for counter. (#230)
* Use proper “name” arg for counter. * update makePrems test
1 parent ac5e2e0 commit 4e11391

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

Example/Tests/Classes/LPCountAggregatorTest.m

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ - (void)test_incrementCount {
7676

7777
[countAggregator incrementCount:testString];
7878
XCTAssert([countAggregator.counts[testString] intValue] == 2);
79-
8079
}
8180

8281
- (void)test_incrementDisabledCountMultiple {
@@ -126,7 +125,7 @@ - (void)test_makeParams {
126125
NSMutableDictionary<NSString *, id> *params = [countAggregator makeParams:testString withCount:2];
127126

128127
XCTAssert([params[LP_PARAM_TYPE] isEqualToString:LP_VALUE_SDK_COUNT]);
129-
XCTAssert([params[LP_PARAM_MESSAGE] isEqualToString:testString]);
128+
XCTAssert([params[LP_PARAM_NAME] isEqualToString:testString]);
130129
XCTAssert([params[LP_PARAM_COUNT] intValue] == 2);
131130
}
132131

Leanplum-SDK/Classes/Internal/Constants.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ OBJC_EXPORT NSString *LP_PARAM_INCLUDE_VARIANT_DEBUG_INFO;
207207
OBJC_EXPORT NSString *LP_PARAM_PARAMS;
208208
OBJC_EXPORT NSString *LP_PARAM_LIMIT_TRACKING;
209209
OBJC_EXPORT NSString *LP_PARAM_MESSAGE;
210+
OBJC_EXPORT NSString *LP_PARAM_NAME;
210211
OBJC_EXPORT NSString *LP_PARAM_MESSAGE_ID;
211212
OBJC_EXPORT NSString *LP_PARAM_BACKGROUND;
212213
OBJC_EXPORT NSString *LP_PARAM_INSTALL_DATE;

Leanplum-SDK/Classes/Internal/Constants.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ - (id)init {
144144
NSString *LP_PARAM_TOKEN = @"token";
145145
NSString *LP_PARAM_PARAMS = @"params";
146146
NSString *LP_PARAM_LIMIT_TRACKING = @"limitTracking";
147+
NSString *LP_PARAM_NAME = @"name";
147148
NSString *LP_PARAM_MESSAGE = @"message";
148149
NSString *LP_PARAM_MESSAGE_ID = @"messageId";
149150
NSString *LP_PARAM_BACKGROUND = @"background";

Leanplum-SDK/Classes/Managers/LPCountAggregator.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ - (void)incrementCount:(nonnull NSString *)name by:(int)incrementCount {
7979
NSMutableDictionary<NSString *, id> *params = [[NSMutableDictionary alloc] init];
8080

8181
params[LP_PARAM_TYPE] = LP_VALUE_SDK_COUNT;
82-
params[LP_PARAM_MESSAGE] = name;
82+
params[LP_PARAM_NAME] = name;
8383
params[LP_PARAM_COUNT] = [NSNumber numberWithInt:count];
8484
return params;
8585
}

0 commit comments

Comments
 (0)