Skip to content

Commit 5d7b5bd

Browse files
authored
fix encoding + symbol (#415)
* add + symbol as unreserved * unit test for + symbol
1 parent 40c9ff9 commit 5d7b5bd

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Example/Tests/Classes/LPOpenUrlMessageTemplateTest.m

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ - (void)tearDown {
2626
}
2727

2828
- (void)testThatURLEncodingWorksForUnreservedCharacters {
29-
//Test characters @":-._~/?&=#"
29+
//Test characters @":-._~/?&=#+"
3030
// Note: all of them includes : . / charachers
3131

3232
NSString *url;
@@ -74,6 +74,12 @@ - (void)testThatURLEncodingWorksForUnreservedCharacters {
7474
template = [self createTemplateWithUrl:url];
7575
encodedURL= [template urlEncodedStringFromString:[template.context stringNamed:LPMT_ARG_URL]];
7676
XCTAssertEqualObjects(url, encodedURL);
77+
78+
//test for + sign
79+
url = @"http://test.com/test+end";
80+
template = [self createTemplateWithUrl:url];
81+
encodedURL= [template urlEncodedStringFromString:[template.context stringNamed:LPMT_ARG_URL]];
82+
XCTAssertEqualObjects(url, encodedURL);
7783
}
7884

7985
- (LPOpenUrlMessageTemplate *)createTemplateWithUrl:(NSString *)url {

Leanplum-SDK/Classes/MessageTemplates/LPOpenUrlMessageTemplate.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ - (void) openURL
5050
}
5151

5252
- (NSString *)urlEncodedStringFromString:(NSString *)urlString {
53-
NSString *unreserved = @":-._~/?&=#";
53+
NSString *unreserved = @":-._~/?&=#+";
5454
NSMutableCharacterSet *allowed = [NSMutableCharacterSet
5555
alphanumericCharacterSet];
5656
[allowed addCharactersInString:unreserved];

0 commit comments

Comments
 (0)