fix(database): Prevent exception loop LP-8132 (#113)

Author: alexisoyama

Leanplum-SDK/Classes/Constants.m

@@ -315,13 +315,17 @@ void leanplumInternalError(NSException *e)
     int userCodeBlocks = [[[[NSThread currentThread] threadDictionary]
                            objectForKey:LP_USER_CODE_BLOCKS] intValue];
     if (userCodeBlocks <= 0) {
-        [[LeanplumRequest post:LP_METHOD_LOG
-                        params:@{
-                                 LP_PARAM_TYPE: LP_VALUE_SDK_ERROR,
-                                 LP_PARAM_MESSAGE: [e description],
-                                 @"stackTrace": [[e callStackSymbols] description] ?: @"",
-                                 LP_PARAM_VERSION_NAME: versionName
-                                 }] send];
+        @try {
+            [[LeanplumRequest post:LP_METHOD_LOG
+                            params:@{
+                                     LP_PARAM_TYPE: LP_VALUE_SDK_ERROR,
+                                     LP_PARAM_MESSAGE: [e description],
+                                     @"stackTrace": [[e callStackSymbols] description] ?: @"",
+                                     LP_PARAM_VERSION_NAME: versionName
+                                     }] send];
+        } @catch (NSException *e) {
+            // This empty try/catch is needed to prevent crash <-> loop.
+        }
         NSLog(@"Leanplum: INTERNAL ERROR: %@\n%@", e, [e callStackSymbols]);
     } else {
         NSLog(@"Leanplum: Caught exception in callback code: %@\n%@", e, [e callStackSymbols]);

Leanplum-SDK/Classes/LPDatabase.m

@@ -160,17 +160,15 @@ - (void)runQuery:(NSString *)query bindObjects:(NSArray *)objectsToBind
     }
 
     @synchronized (self) {
-        sqlite3_stmt *statement = [self sqliteStatementFromQuery:query bindObjects:objectsToBind];
-        if (!statement) {
-            return;
-        }
-        
-        int result = sqlite3_step(statement);
-        if (result != SQLITE_DONE) {
-            [self handleSQLiteError:@"SQLite fail to run query" errorResult:result query:query];
+        @try {
+            sqlite3_stmt *statement = [self sqliteStatementFromQuery:query bindObjects:objectsToBind];
+            if (!statement) {
+                return;
+            }
+        } @catch (NSException *e) {
+            LPLog(LPError, @"SQLite operation failed.");
+            // TODO: Make sure to catch this when new logging is in place,
         }
-        willSendErrorLog = NO;
-        sqlite3_finalize(statement);
     }
 }