Skip to content

Commit 9ee52af

Browse files
authored
Break up files with multiple classes (#150)
* refactor: breaking up leanplum.m * fix name * refactor LPActionArg * refactor LPVar * refactor LeanplumCompatibility * lpvar changes * rename Leanplum-Internal back to LeanplumInternal to avoid breaking other modules * missed a few files * refactor lpinternalstate * rename tests to reflect the classes being tested * break apart lpsresponse into its own file * refactor lpcontextual values and lpresponse * break apart lpcallback * renamed a bunch of files * remove unneeded pragma marks * add missing files * revert internal state change * fix test
1 parent 1ccc4e9 commit 9ee52af

28 files changed

+349
-202
lines changed

Example/Leanplum-SDK.xcodeproj/project.pbxproj

Lines changed: 32 additions & 32 deletions
Large diffs are not rendered by default.

Example/Tests/Classes/ActionManagerTest.m renamed to Example/Tests/Classes/LPActionManagerTest.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ - (void)didReceiveRemoteNotification:(NSDictionary *)userInfo
4545
- (void)leanplum_application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken;
4646
@end
4747

48-
@interface ActionManagerTest : XCTestCase
48+
@interface LPActionManagerTest : XCTestCase
4949

5050
@end
5151

52-
@implementation ActionManagerTest
52+
@implementation LPActionManagerTest
5353

5454
+ (void)setUp
5555
{

Example/Tests/Classes/AppIconManagerTest.m renamed to Example/Tests/Classes/LPAppIconManagerTest.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,11 @@ + (void)prepareUploadRequestParam:(NSMutableArray *)requestParam
4848

4949
@end
5050

51-
@interface AppIconManagerTest : XCTestCase
51+
@interface LPAppIconManagerTest : XCTestCase
5252

5353
@end
5454

55-
@implementation AppIconManagerTest
55+
@implementation LPAppIconManagerTest
5656

5757
+ (void)setUp
5858
{

Example/Tests/Classes/EventCallbackManagerTest.m renamed to Example/Tests/Classes/LPEventCallbackManagerTest.m

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,14 @@
77
//
88

99
#import <XCTest/XCTest.h>
10+
#import "LPEventCallback.h"
1011
#import "LPEventCallbackManager.h"
1112

12-
@interface EventCallbackManagerTest : XCTestCase
13+
@interface LPEventCallbackManagerTest : XCTestCase
1314

1415
@end
1516

16-
@implementation EventCallbackManagerTest
17+
@implementation LPEventCallbackManagerTest
1718

1819
- (void)setUp {
1920
[super setUp];

Example/Tests/Classes/EventDataManagerTest.m renamed to Example/Tests/Classes/LPEventDataManagerTest.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,11 @@ + (NSOperationQueue *)sendNowQueue;
6363

6464
@end
6565

66-
@interface EventDataManagerTest : XCTestCase
66+
@interface LPEventDataManagerTest : XCTestCase
6767

6868
@end
6969

70-
@implementation EventDataManagerTest
70+
@implementation LPEventDataManagerTest
7171

7272
- (void)setUp {
7373
[super setUp];

Example/Tests/Classes/FileManagerTest.m renamed to Example/Tests/Classes/LPFileManagerTest.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@
3636
/**
3737
* Tests file manager public methods.
3838
*/
39-
@interface FileManagerTest : XCTestCase
39+
@interface LPFileManagerTest : XCTestCase
4040

4141
@end
4242

43-
@implementation FileManagerTest
43+
@implementation LPFileManagerTest
4444

4545
+ (void)setUp
4646
{

Example/Tests/Classes/MessageTemplatesTest.m renamed to Example/Tests/Classes/LPMessageTemplatesClassTest.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ - (void)showPopup;
4545

4646
@end
4747

48-
@interface MessageTemplatesTest : XCTestCase
48+
@interface LPMessageTemplatesClassTest : XCTestCase
4949

5050
@end
5151

52-
@implementation MessageTemplatesTest
52+
@implementation LPMessageTemplatesClassTest
5353

5454
+ (void)setUp
5555
{

Example/Tests/Classes/RequestStorageTest.m renamed to Example/Tests/Classes/LPRequestStorageTest.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,15 @@ + (NSString *)itemKeyForIndex:(NSUInteger)index;
4848

4949
@end
5050

51-
@interface RequestStorageTest : XCTestCase
51+
@interface LPRequestStorageTest : XCTestCase
5252

5353
@property (strong, nonatomic) NSFileManager *fileManager;
5454
@property (strong, nonatomic) LPRequestStorage *requestStorage;
5555
@property (strong, nonatomic) NSUserDefaults *userDefaults;
5656

5757
@end
5858

59-
@implementation RequestStorageTest
59+
@implementation LPRequestStorageTest
6060

6161
- (void)setUp {
6262
[super setUp];

Example/Tests/Classes/UtilitiesTest.m renamed to Example/Tests/Classes/LPUtilsTest.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@
2727
#import "NSString+MD5Addition.h"
2828
#import "Utils.h"
2929

30-
@interface UtilitiesTest : XCTestCase
30+
@interface LPUtilsTest : XCTestCase
3131

3232
@end
3333

34-
@implementation UtilitiesTest
34+
@implementation LPUtilsTest
3535

3636
- (void)setUp {
3737
[super setUp];

Leanplum-SDK/Classes/Constants.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@
8585
#define MACRO_NAME(x) #x
8686
#define MACRO_VALUE(x) MACRO_NAME(x)
8787

88-
#pragma mark - LPConstantsState interface
89-
9088
@interface LPConstantsState : NSObject {
9189
NSString *_apiHostName;
9290
NSString *_apiServlet;
@@ -111,8 +109,6 @@
111109
int _userCodeBlocks;
112110
}
113111

114-
#pragma mark - LPConstantsState properties
115-
116112
@property(strong, nonatomic) NSString *apiHostName;
117113
@property(strong, nonatomic) NSString *socketHost;
118114
@property(assign, nonatomic) int socketPort;
@@ -134,8 +130,6 @@
134130
@property(assign, nonatomic) BOOL isLocationCollectionEnabled;
135131
@property(assign, nonatomic) BOOL isInboxImagePrefetchingEnabled;
136132

137-
#pragma mark - LPConstantsState methods
138-
139133
+ (LPConstantsState *)sharedState;
140134

141135
@end

0 commit comments

Comments
 (0)