incrementCount refactor (#208)

gg4race · web-flow · commit a2e738f0ee69 · 2018-09-12T23:45:39.000-07:00
diff --git a/Example/Tests/Classes/LPCountAggregatorTest.m b/Example/Tests/Classes/LPCountAggregatorTest.m
@@ -2,7 +2,7 @@
 //  AppIconManagerTest.m
 //  Leanplum-SDK
 //
-//  Created by Alexis Oyama on 3/2/17.
+//  Created by Grace Gu on 9/11/18.
 //  Copyright © 2017 Leanplum. All rights reserved.
 //
 //  Licensed to the Apache Software Foundation (ASF) under one
diff --git a/Leanplum-SDK/Classes/Managers/LPCountAggregator.m b/Leanplum-SDK/Classes/Managers/LPCountAggregator.m
@@ -55,14 +55,7 @@ - (instancetype)init {
 }
 
 - (void)incrementCount:(nonnull NSString *)name {
-    if ([self.enabledCounters containsObject:name]) {
-        int count = 0;
-        if ([self.counts objectForKey:name]) {
-            count = [self.counts[name] intValue];
-        }
-        count = count + 1;
-        self.counts[name] = [NSNumber numberWithInt:count];
-    }
+    [self incrementCount:name by: 1];
 }
 
 - (void)incrementCount:(nonnull NSString *)name by:(int)incrementCount {

Original file line number	Diff line number	Diff line change
`@@ -55,14 +55,7 @@ - (instancetype)init {`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`- (void)incrementCount:(nonnull NSString *)name {`
`58`		`- if ([self.enabledCounters containsObject:name]) {`
`59`		`- int count = 0;`
`60`		`- if ([self.counts objectForKey:name]) {`
`61`		`- count = [self.counts[name] intValue];`
`62`		`- }`
`63`		`- count = count + 1;`
`64`		`- self.counts[name] = [NSNumber numberWithInt:count];`
`65`		`- }`
	`58`	`+ [self incrementCount:name by: 1];`
`66`	`59`	`}`
`67`	`60`
`68`	`61`	`- (void)incrementCount:(nonnull NSString *)name by:(int)incrementCount {`