Do not connect socket in prod mode (#530)

Author: nzagorchev

LeanplumSDK/LeanplumSDK/Classes/Internal/Leanplum.m

@@ -186,7 +186,9 @@ + (void)setSocketHostName:(NSString *)hostName withPortNumber:(int)port
         [ApiConfig shared].socketPort != port) {
         [ApiConfig shared].socketHost = hostName;
         [ApiConfig shared].socketPort = port;
-        [[LeanplumSocket sharedSocket] connectToNewSocket];
+        if ([LPConstantsState sharedState].isDevelopmentModeEnabled) {
+            [[LeanplumSocket sharedSocket] connectToNewSocket];
+        }
     }
 }
 

LeanplumSDKApp/LeanplumSDKTests/Classes/LPRequestSenderTest.m

@@ -45,8 +45,9 @@ + (void)setUp
 }
 
 - (void)setUp {
+    [Leanplum setApiHostName:API_HOST withPath:API_PATH usingSsl:YES];
+    [Leanplum setSocketHostName:@"dev.leanplum.com" withPortNumber:443];
     [LeanplumHelper setup_development_test];
-    [[LPConstantsState sharedState] setIsDevelopmentModeEnabled:YES];
     [Leanplum setAppId:@"test" withDevelopmentKey:@"test"];
 }
 
@@ -172,7 +173,10 @@ - (void)testSendNowWithDatas {
 }
 
 - (void)testSendRequestsUpdateHost {
-    id changeHostStub = [HTTPStubs stubRequestsPassingTest:^BOOL(NSURLRequest * _Nonnull request) {
+    // use production, socket is not needed
+    [Leanplum setAppId:@"test" withProductionKey:@"test"];
+    
+    __block __weak id changeHostStub = [HTTPStubs stubRequestsPassingTest:^BOOL(NSURLRequest * _Nonnull request) {
         return [request.URL.host isEqualToString:API_HOST];
     } withStubResponse:^HTTPStubsResponse * _Nonnull(NSURLRequest * _Nonnull request) {
         [HTTPStubs removeStub:changeHostStub];
@@ -206,15 +210,15 @@ - (void)testSendRequestsUpdateHost {
 }
 
 - (void)testUpdateSocketHost {
-    id changeSocketStub = [HTTPStubs stubRequestsPassingTest:^BOOL(NSURLRequest * _Nonnull request) {
+    [HTTPStubs stubRequestsPassingTest:^BOOL(NSURLRequest * _Nonnull request) {
         return [request.URL.absoluteString hasPrefix:@"https://dev.leanplum.com:443/socket.io/1/?t="];
     } withStubResponse:^HTTPStubsResponse * _Nonnull(NSURLRequest * _Nonnull request) {
         NSString *success = @"abcD12Efj3d64oMN18cX-:60:60:websocket,xhr-polling,jsonp-polling";
         NSData *data = [success dataUsingEncoding:NSUTF8StringEncoding];
         return [HTTPStubsResponse responseWithData:data statusCode:200 headers:@{@"Content-Type":@"text/plain"}];
     }];
 
-    id changeHostStub = [HTTPStubs stubRequestsPassingTest:^BOOL(NSURLRequest * _Nonnull request) {
+    [HTTPStubs stubRequestsPassingTest:^BOOL(NSURLRequest * _Nonnull request) {
         return [request.URL.host isEqualToString:API_HOST];
     } withStubResponse:^HTTPStubsResponse * _Nonnull(NSURLRequest * _Nonnull request) {
         NSString *response_file = OHPathForFile(@"change_host_response.json", self.class);