[LP-11004] Fixing not hiding rich interstitial (#326)

milos1290 · web-flow · commit edb617729bb1 · 2019-10-29T19:05:47.000+01:00
* [LP-11004] Fixing not hiding rich interstitial

* Make sure dismiss is guarded
diff --git a/Leanplum-SDK/Classes/LPMessageTemplates.m b/Leanplum-SDK/Classes/LPMessageTemplates.m
@@ -821,7 +821,9 @@ - (void)accept
 
 - (void)dismiss
 {
+    LP_TRY
     [self closePopupWithAnimation:YES];
+    LP_END_TRY
 }
 
 - (void)enablePush
@@ -1437,7 +1439,10 @@ - (void)webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigati
             return;
         }
     }
-    @catch (NSException *exception) {
+    @catch (id exception) {
+        // In case we catch exception here, hide the overlaying message.
+        [self dismiss];
+        // Handle the exception message.
         LOG_LP_MESSAGE_EXCEPTION;
     }
     decisionHandler(WKNavigationActionPolicyAllow);

Original file line number	Diff line number	Diff line change
`@@ -821,7 +821,9 @@ - (void)accept`
`821`	`821`
`822`	`822`	`- (void)dismiss`
`823`	`823`	`{`
	`824`	`+ LP_TRY`
`824`	`825`	`[self closePopupWithAnimation:YES];`
	`826`	`+ LP_END_TRY`
`825`	`827`	`}`
`826`	`828`
`827`	`829`	`- (void)enablePush`
`@@ -1437,7 +1439,10 @@ - (void)webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigati`
`1437`	`1439`	`return;`
`1438`	`1440`	`}`
`1439`	`1441`	`}`
`1440`		`- @catch (NSException *exception) {`
	`1442`	`+ @catch (id exception) {`
	`1443`	`+ // In case we catch exception here, hide the overlaying message.`
	`1444`	`+ [self dismiss];`
	`1445`	`+ // Handle the exception message.`
`1441`	`1446`	`LOG_LP_MESSAGE_EXCEPTION;`
`1442`	`1447`	`}`
`1443`	`1448`	`decisionHandler(WKNavigationActionPolicyAllow);`