Help creating an official Debian package

[sorenstoutner]

Manuel Guerra and I are working on adding an official Debian package for app-bitcoin-new. You can see our work so far at:

https://salsa.debian.org/manuelguerra/python-ledger-bitcoin

With software as complex as this, I usually like to coordinate with upstream to make sure we get things right. One of Debian's goals is to build all code from source in a reproducible and auditable way. While working on this package, we noticed that you ship two .elf binary files in your source.

https://github.com/LedgerHQ/app-bitcoin-new/tree/develop/bitcoin_client/tests/app-binaries

Could you let us know what the procedures are for building these from source?

[bigspider]

Hi, and thanks for opening the issue!

The two .elf binaries mentioned above are rather old binaries of the bitcoin app, only used for some compatibility tests with old versions of the app (pre-2022). Unfortunately, it's hard at this point to try to reproduce those binaries, but IMHO it's not that important as they are rather old.

The main test suite with the current binaries is actually https://github.com/LedgerHQ/app-bitcoin-new/tree/develop/tests, and the app's binaries are built in the CI.

[sorenstoutner]

Thant you. That is very helpful. We will just exclude those old binaries from the Debian package.

[sorenstoutner]

Upon further review, I think it makes the most sense for us to package ledger-bitcoin from the PyPI repository instead of directly from the GitHub repository.

https://pypi.org/project/ledger-bitcoin/

However, the tarball hosted on pypi.org doesn't include the changelog from the GitHub repository.

https://github.com/LedgerHQ/app-bitcoin-new/blob/develop/bitcoin_client/CHANGELOG.md

We typically like to ship a copy of the upstream changelog in the Debian package. Would it be feasible for you to include the changelog in future releases on PyPI?

[bigspider]

@sorenstoutner, thanks for the suggestion. I think #341 should do the trick - is that in line with your expectations for a python package?

[manuwarfare]

Hi Salvatore,

Sorry for adding this to this thread... Soren and I are working on bringing the full Ledger suite to the official Debian repositories, we already uploaded ledgercomm correctly as a previous step to uploading ledger-bitcoin and then other Ledger tools will come, the thing is that we don't have a physical device to perform hardware tests so my question is: do you think Ledger can provide us with a physical device on loan to do all the necessary tests?

[sorenstoutner]

@sorenstoutner, thanks for the suggestion. I think #341 should do the trick - is that in line with your expectations for a python package?

Yes, that is perfect. Thank you.

[sorenstoutner]

When building ledger-bitcoin, I receive the following warning:

/usr/lib/python3/dist-packages/setuptools/dist.py:759: SetuptoolsDeprecationWarning: License classifiers are deprecated.
!!

        ********************************************************************************
        Please consider removing the following classifiers in favor of a SPDX license expression:

        License :: OSI Approved :: Apache Software License

        See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
        ********************************************************************************

!!

My primary concern is that, because this text does not include a version number, it appears to say the software is licensed under the Apache 1.0 License. Other documentation in the repository all references the Apache 2.0 License. I assume that the lack of a version number in this file is simply an oversight.

https://github.com/LedgerHQ/app-bitcoin-new/blob/develop/bitcoin_client/setup.cfg#L14