Merge pull request #420 from LedgerHQ/bugfix/apa/static_analysis_fix

apaillier-ledger · web-flow · commit 09488048d69b · 2023-04-24T15:01:09.000+02:00
Fixes static analysis warning
diff --git a/src_common/uint256.c b/src_common/uint256.c
@@ -240,7 +240,7 @@ bool tostring256(const uint256_t *const number,
 
     if (offset == outLength) {  // destination buffer too small
         if (outLength > 3) {
-            strcpy(out, "...");
+            strlcpy(out, "...", outLength);
         } else {
             out[0] = '\0';
         }

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ bool tostring256(const uint256_t *const number,`
`240`	`240`
`241`	`241`	`if (offset == outLength) { // destination buffer too small`
`242`	`242`	`if (outLength > 3) {`
`243`		`- strcpy(out, "...");`
	`243`	`+ strlcpy(out, "...", outLength);`
`244`	`244`	`} else {`
`245`	`245`	`out[0] = '\0';`
`246`	`246`	`}`