Merge pull request #424 from LedgerHQ/release/1.10.2

App release 1.10.2

Author: apaillier-ledger

.github/actions/commit-changes/action.yml

@@ -114,6 +114,6 @@ runs:
       uses: ad-m/github-push-action@master
       with:
         github_token: ${{ inputs.secret }}
-        branch: ${{ steps.commit.outputs.src_branch }}:${{ steps.commit.outputs.dst_branch }}
+        branch: ${{ steps.commit.outputs.dst_branch }}
         directory: ${{ inputs.directory }}
         repository: ${{ inputs.repository }}

.github/workflows/auto-author-assign.yml

@@ -11,4 +11,4 @@ jobs:
   assign-author:
     runs-on: ubuntu-latest
     steps:
-      - uses: toshimaru/auto-author-assign@v1.4.0
+      - uses: toshimaru/auto-author-assign@v1.6.1

.github/workflows/build-workflow.yml

@@ -22,7 +22,7 @@ jobs:
 
     steps:
       - name: Clone
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Build Ethereum
         run: |

.github/workflows/ci-workflow.yml

@@ -18,14 +18,14 @@ jobs:
       image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Build with Clang Static Analyzer
         run: |
           make clean
           scan-build --use-cc=clang -analyze-headers -enable-checker security -enable-checker unix -enable-checker valist -o scan-build --status-bugs make default
 
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v3
         if: failure()
         with:
           name: scan-build
@@ -42,15 +42,15 @@ jobs:
       image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Build testing binaries
         run: |
           git config --global --add safe.directory "$GITHUB_WORKSPACE"
           cd tests/zemu/ && ./build_local_test_elfs.sh
 
       - name: Upload app binaries
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
         with:
           name: e2e_zemu_elfs
           path: ./tests/zemu/elfs/
@@ -68,14 +68,14 @@ jobs:
           echo $DISPLAY
 
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - run: sudo apt-get update -y && sudo apt-get install -y libusb-1.0.0 libudev-dev
 
-      - name: Install node
-        uses: actions/setup-node@v2
+      - name: Install NodeJS
+        uses: actions/setup-node@v3
         with:
-          node-version: "14.4.0"
+          node-version: "16"
 
       - name: Install yarn
         run: npm install -g yarn
@@ -87,7 +87,7 @@ jobs:
         run: mkdir tests/zemu/elfs
 
       - name: Download app binaries
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v3
         with:
           path: tmp/
 
@@ -109,7 +109,7 @@ jobs:
       image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Build testing binaries
         run: |
@@ -119,7 +119,7 @@ jobs:
           make clean && make -j DEBUG=1 NFT_TESTING_KEY=1 BOLOS_SDK=$NANOSP_SDK && mv bin/app.elf tests/speculos/elfs/nanosp.elf
 
       - name: Upload app binaries
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
         with:
           name: e2e_speculos_elfs
           path: ./tests/speculos/elfs
@@ -136,13 +136,13 @@ jobs:
 
     steps:
       - name: Clone
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Create tmp folder for artifacts
         run: mkdir tests/speculos/elfs
 
       - name: Download app binaries
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v3
         with:
           path: tmp/
 
@@ -166,113 +166,18 @@ jobs:
 # =====================================================
 
   build_ragger_elfs:
-    name: Building binaries for Ragger tests
-    runs-on: ubuntu-latest
-    container:
-      image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest
-
-    steps:
-      - name: Clone
-        uses: actions/checkout@v2
-
-      - name: Build test binaries
-        run: |
-          make -j BOLOS_SDK=$NANOS_SDK CAL_TESTING_KEY=1
-          mv bin/app.elf app-nanos.elf
-          make clean
-          make -j BOLOS_SDK=$NANOX_SDK CAL_TESTING_KEY=1
-          mv bin/app.elf app-nanox.elf
-          make clean
-          make -j BOLOS_SDK=$NANOSP_SDK CAL_TESTING_KEY=1
-          mv bin/app.elf app-nanosp.elf
-
-      - name: Upload app binaries
-        uses: actions/upload-artifact@v2
-        with:
-          name: ragger_elfs
-          path: ./app-*.elf
-
-  create_ragger_env:
-    name: Cache Ragger environment
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Clone
-        uses: actions/checkout@v2
-
-      - name: APT update
-        run: |
-          sudo apt update
-
-      - name: Create virtual env with dependencies
-        run: |
-          cd tests/ragger
-          python3 -m venv ./venv
-          . ./venv/bin/activate
-          pip3 install --extra-index-url https://test.pypi.org/simple/ -r requirements.txt
-          # Used for the cache key
-          echo "py_deps=$(pip freeze | md5sum | cut -d' ' -f1)" >> $GITHUB_ENV
-
-      - name: Download QEMU
-        run: |
-          sudo apt install --download-only -y qemu-user-static
-          mkdir -p tests/ragger/packages
-          cp /var/cache/apt/archives/*.deb tests/ragger/packages/
-          # Used for the cache key
-          echo "deb_deps=$(find /var/cache/apt/archives/ -maxdepth 0 -type f -name '*.deb' | md5sum | cut -d' ' -f 1)" >> $GITHUB_ENV
-
-      - name: Set up cache
-        uses: actions/cache@v3
-        with:
-          key: ${{ runner.os }}-raggenv-${{ env.py_deps }}-${{ env.deb_deps }}
-          path: |
-            tests/ragger/venv/
-            tests/ragger/packages/
-    outputs:
-      py_deps: ${{ env.py_deps }}
-      deb_deps: ${{ env.deb_deps }}
-
+    name: Build app for Ragger tests
+    uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_build.yml@v1
+    with:
+      upload_app_binaries_artifact: "ragger_elfs"
+      flags: "DEBUG=1 CAL_CI_KEY=1 DOMAIN_NAME_TEST_KEY=1"
+      run_for_devices: '["nanos", "nanox", "nanosp"]'
 
   jobs-ragger-tests:
-    name: Ragger tests
-    strategy:
-      matrix:
-        model: ["nanos", "nanox", "nanosp"]
-    needs: [build_ragger_elfs, create_ragger_env]
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Clone
-        uses: actions/checkout@v2
-
-      - name: Download previously built artifacts
-        uses: actions/download-artifact@v2
-        with:
-          name: ragger_elfs
-          path: tmp/
-
-      - name: Put them where they belong
-        run: |
-          mkdir -p tests/ragger/elfs
-          find tmp/ -type f -name '*.elf' -exec cp {} tests/ragger/elfs/ \;
-
-      - name: Get cached environment
-        uses: actions/cache@v3
-        with:
-          key: ${{ runner.os }}-raggenv-${{ needs.create_ragger_env.outputs.py_deps }}-${{ needs.create_ragger_env.outputs.deb_deps }}
-          path: |
-            tests/ragger/venv/
-            tests/ragger/packages/
-
-      - name: Install QEMU
-        run: |
-          sudo mv tests/ragger/packages/*.deb /var/cache/apt/archives/
-          sudo apt install -y qemu-user-static
-
-      - name: Run tests
-        env:
-          CAL_SIGNATURE_TEST_KEY: ${{ secrets.CAL_SIGNATURE_TEST_KEY }}
-        run: |
-          cd tests/ragger
-          . ./venv/bin/activate
-          pytest --path ./elfs --model ${{ matrix.model }} -s -v
+    name: Run Ragger tests
+    needs: build_ragger_elfs
+    uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_ragger_tests.yml@v1
+    with:
+      download_app_binaries_artifact: "ragger_elfs"
+      test_dir: tests/ragger
+      run_for_devices: '["nanos", "nanox", "nanosp"]'

.github/workflows/lint-workflow.yml

@@ -16,7 +16,7 @@ jobs:
 
     steps:
       - name: Clone
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Lint
         uses: DoozyX/[email protected]

.github/workflows/sdk-generation.yml

@@ -14,7 +14,7 @@ jobs:
 
     steps:
       - name: Clone
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           # by default the action uses fetch-depth = 1, which creates
           # shallow repositories from which we can't push
@@ -42,11 +42,10 @@ jobs:
           secret: ${{ secrets.CI_BOT_TOKEN }}
           repository: LedgerHQ/ethereum-plugin-sdk
 
-      - name: Update the SDK submodule in the Ethereum app
-        uses: ./.github/actions/commit-changes
+      - name: Create SDK update pull request
+        uses: peter-evans/create-pull-request@v4
         with:
-          name: 'ldg-github-ci'
-          files: ethereum-plugin-sdk
-          message: "[update][SDK] Branch ${{ steps.extract_branch.outputs.branch }} | Commit ${GITHUB_SHA}"
-          secret: ${{ secrets.CI_BOT_TOKEN }}
-          repository: LedgerHQ/app-ethereum
+          branch: sdk/update-submodule
+          delete-branch: true
+          title: Update the SDK submodule
+          reviewers: apailler-ledger

CHANGELOG.md

@@ -5,6 +5,39 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [1.10.2](https://github.com/ledgerhq/app-ethereum/compare/1.10.1...1.10.2) - 2023-04-24
+
+### Added
+
+- (clone) ID4Good
+- (network) Cronos
+- (network) Scroll
+- (network) KCC
+- (network) Rootstock
+- (network) Evmos
+- (network) Metis Andromeda
+- (network) Kava EVM
+- (network) Klaytn Cypress
+- (network) Syscoin
+- (network) Velas EVM
+- (network) Boba Network
+- (network) Energi
+- Domain names support (LNX / LNS+)
+
+### Changed
+
+- Starknet blind signing wording
+
+### Fixed
+
+- Missing 44'/60' derivation path for XDC Network
+- Small visual glitch with EIP-712 verbose mode with the "Review struct" page
+- Possible overflow with very large transactions
+- EnergyWebChain ticker
+- Arbitrum ticker
+- Error handling on EIP-191 APDUs
+- Swap transactions handling
+
 ## [1.10.1](https://github.com/ledgerhq/app-ethereum/compare/1.10.0...1.10.1) - 2022-11-09
 
 ### Fixed

Makefile

@@ -34,7 +34,7 @@ APP_LOAD_PARAMS += --path "1517992542'/1101353413'"
 
 APPVERSION_M=1
 APPVERSION_N=10
-APPVERSION_P=1
+APPVERSION_P=2
 APPVERSION=$(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)
 APP_LOAD_FLAGS= --appFlags 0xa40 --dep Ethereum:$(APPVERSION)
 
@@ -147,10 +147,23 @@ ifneq ($(TARGET_NAME),TARGET_NANOS)
 DEFINES	+= HAVE_EIP712_FULL_SUPPORT
 endif
 
-# CryptoAssetsList testing key
-CAL_TESTING_KEY:=0
-ifneq ($(CAL_TESTING_KEY),0)
-DEFINES += HAVE_CAL_TESTING_KEY
+# CryptoAssetsList key
+CAL_TEST_KEY:=0
+CAL_CI_KEY:=0
+ifneq ($(CAL_TEST_KEY),0)
+DEFINES += HAVE_CAL_TEST_KEY
+endif
+ifneq ($(CAL_CI_KEY),0)
+DEFINES += HAVE_CAL_CI_KEY
+endif
+
+# ENS
+ifneq ($(TARGET_NAME),TARGET_NANOS)
+DEFINES += HAVE_DOMAIN_NAME
+DOMAIN_NAME_TEST_KEY:=0
+ifneq ($(DOMAIN_NAME_TEST_KEY),0)
+DEFINES += HAVE_DOMAIN_NAME_TEST_KEY
+endif
 endif
 
 # Enabling debug PRINTF