Skip to content

Commit 7321aa0

Browse files
Align on reusable workflows
1 parent 190a4df commit 7321aa0

File tree

2 files changed

+14
-50
lines changed

2 files changed

+14
-50
lines changed

.github/workflows/codeql_checks.yml

Lines changed: 3 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -15,33 +15,6 @@ on:
1515

1616
jobs:
1717
analyse:
18-
name: Analyse
19-
strategy:
20-
fail-fast: false
21-
matrix:
22-
sdk: ["$NANOX_SDK", "$NANOSP_SDK", "$STAX_SDK", "$FLEX_SDK"]
23-
# 'cpp' covers C and C++
24-
language: ['cpp']
25-
runs-on: ubuntu-latest
26-
container:
27-
image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest
28-
29-
steps:
30-
- name: Clone
31-
uses: actions/checkout@v4
32-
with:
33-
submodules: true
34-
35-
- name: Initialize CodeQL
36-
uses: github/codeql-action/init@v3
37-
with:
38-
languages: ${{ matrix.language }}
39-
queries: security-and-quality
40-
41-
# CodeQL will create the database during the compilation
42-
- name: Build
43-
run: |
44-
make BOLOS_SDK=${{ matrix.sdk }}
45-
46-
- name: Perform CodeQL Analysis
47-
uses: github/codeql-action/analyze@v3
18+
name: Call Ledger CodeQL analysis
19+
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_codeql_checks.yml@v1
20+
secrets: inherit

.github/workflows/python-client.yml

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -19,28 +19,19 @@ on:
1919

2020
jobs:
2121
lint:
22-
name: Linting
23-
runs-on: ubuntu-latest
24-
steps:
25-
- name: Clone
26-
uses: actions/checkout@v4
27-
- run: pip install flake8 flake8-pyproject
28-
- name: Flake8 lint Python code
29-
run: (cd client && flake8 src/)
30-
31-
mypy:
32-
name: Type checking
33-
runs-on: ubuntu-latest
34-
steps:
35-
- name: Clone
36-
uses: actions/checkout@v4
37-
- run: pip install mypy
38-
- name: Mypy type checking
39-
run: (cd client && mypy src/)
22+
name: Call Ledger Python linters
23+
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_python_checks.yml@v1
24+
with:
25+
run_linter: flake8
26+
run_type_check: true
27+
src_directory: src
28+
setup_directory: client
29+
req_directory: client
30+
base_directory: client
4031

4132
package_and_deploy:
4233
name: Build and deploy the Ethereum client Python package
43-
needs: [lint, mypy]
34+
needs: [lint]
4435
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_pypi_deployment.yml@v1
4536
with:
4637
package_name: ledger_app_clients.ethereum
@@ -49,4 +40,4 @@ jobs:
4940
jfrog_deployment: false
5041
release: false
5142
secrets:
52-
pypi_token: ${{ secrets.PYPI_PUBLIC_API_TOKEN }}
43+
pypi_token: ${{ secrets.PYPI_PUBLIC_API_TOKEN }}

0 commit comments

Comments
 (0)