Merge pull request #660 from LedgerHQ/fix/apa/eip191_regression

[hotfix] EIP-191 messages regression

Author: apaillier-ledger

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [1.12.1](https://github.com/ledgerhq/app-ethereum/compare/1.12.0...1.12.1) - 2024-10-02
+
+### Fixed
+
+- Review of EIP-191 messages getting stuck and not responding to APDUs
+
 ## [1.12.0](https://github.com/ledgerhq/app-ethereum/compare/1.11.3...1.12.0) - 2024-09-27
 
 ### Added

Makefile

@@ -37,7 +37,7 @@ include ./makefile_conf/chain/$(CHAIN).mk
 
 APPVERSION_M = 1
 APPVERSION_N = 12
-APPVERSION_P = 0
+APPVERSION_P = 1
 APPVERSION = $(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)
 
 # Application source files

src_features/signMessage/cmd_signMessage.c

@@ -311,8 +311,13 @@ void skip_rest_of_message(void) {
  * The user has decided to see the next chunk of the message
  */
 void continue_displaying_message(void) {
+    uint16_t sw = APDU_RESPONSE_OK;
+
     reset_ui_buffer();
     if (unprocessed_length() > 0) {
-        feed_display();
+        sw = feed_display();
+    }
+    if (sw != APDU_NO_RESPONSE) {
+        io_seproxyhal_send_status(sw, 0, sw != APDU_RESPONSE_OK, sw != APDU_RESPONSE_OK);
     }
 }