Cleanup sources

- Remove useless header file
- Fix bit-field init
- Fix parameters casting

Author: cedelavergne-ledger

src/features/signMessageEIP712/filtering.c

@@ -950,8 +950,8 @@ bool filtering_trusted_name(const uint8_t *payload,
     }
     hash_filtering_path((cx_hash_t *) &hash_ctx, discarded, path_crc);
     hash_nbytes((uint8_t *) name, sizeof(char) * name_len, (cx_hash_t *) &hash_ctx);
-    hash_nbytes(types, type_count, (cx_hash_t *) &hash_ctx);
-    hash_nbytes(sources, source_count, (cx_hash_t *) &hash_ctx);
+    hash_nbytes((uint8_t *) types, type_count, (cx_hash_t *) &hash_ctx);
+    hash_nbytes((uint8_t *) sources, source_count, (cx_hash_t *) &hash_ctx);
     if (!sig_verif_end(&hash_ctx, sig, sig_len)) {
         return false;
     }

src/features/signMessageEIP712/ui_logic.c

@@ -1297,7 +1297,7 @@ void ui_712_push_pairs(void) {
             tx_idx++;
             // Replace "nn of mm" placeholder, initialized in ui_712_set_intent()
             snprintf(tmp->value, N_OF_M_LENGTH, "%d of %d", tx_idx, txContext.batch_nb_tx);
-            g_pairs[pair].centeredInfo = 1;
+            g_pairs[pair].centeredInfo = true;
         }
         g_pairs[pair].item = tmp->key;
         g_pairs[pair].value = tmp->value;
@@ -1308,7 +1308,7 @@ void ui_712_push_pairs(void) {
         pair++;
         if ((tmp->end_intent) && (txContext.batch_nb_tx > 1)) {
             // End of batch transaction : start next info on full page
-            g_pairs[pair].forcePageStart = 1;
+            g_pairs[pair].forcePageStart = true;
         }
         tmp = (s_ui_712_pair *) ((s_flist_node *) tmp)->next;
     }
@@ -1320,7 +1320,7 @@ void ui_712_push_pairs(void) {
         }
         // Prepare the pairs list with the hashes
         eip712_format_hash(pair);
-        g_pairs[pair].forcePageStart = 1;
+        g_pairs[pair].forcePageStart = true;
     }
 }
 

src/main.c

@@ -23,7 +23,6 @@
 #include "io.h"
 
 #include "parser.h"
-#include "glyphs.h"
 #include "common_utils.h"
 
 #include "eth_swap_utils.h"

src/nbgl/ui_approve_tx.c

@@ -171,7 +171,7 @@ static void setTagValuePairs(bool displayNetwork, bool fromPlugin) {
             extension->fullValue = strings.common.toAddress;
             extension->explanation = strings.common.toAddress;
             g_pairs[nbPairs].extension = extension;
-            g_pairs[nbPairs].aliasValue = 1;
+            g_pairs[nbPairs].aliasValue = true;
         } else {
             g_pairs[nbPairs].value = strings.common.toAddress;
         }

src/nbgl/ui_gcs.c

@@ -338,7 +338,7 @@ bool ui_gcs(void) {
     } else {
         ext->backText = app_mem_strdup(ext->backText);
     }
-    g_pairs[pair].aliasValue = 1;
+    g_pairs[pair].aliasValue = true;
     pair++;
 
     // TX fields
@@ -354,15 +354,15 @@ bool ui_gcs(void) {
             g_pairs[pair].item = app_mem_strdup("Review transaction");
             g_pairs[pair].value = app_mem_strdup(tmp_buf);
             index_allocated[pair] = true;
-            g_pairs[pair].centeredInfo = 1;
+            g_pairs[pair].centeredInfo = true;
             pair++;
         }
         g_pairs[pair].item = field->key;
         g_pairs[pair].value = field->value;
         pair++;
         if ((field->end_intent) && (txContext.batch_nb_tx > 1)) {
             // End of batch transaction : start next info on full page
-            g_pairs[pair].forcePageStart = 1;
+            g_pairs[pair].forcePageStart = true;
         }
     }
 

src/nbgl/ui_nbgl.h

@@ -2,7 +2,6 @@
 
 #include "nbgl_use_case.h"
 #include "shared_context.h"
-#include "glyphs.h"
 
 #ifdef SCREEN_SIZE_WALLET
 #define ICON_APP_WARNING LARGE_WARNING_ICON

src/nbgl/ui_safe_account.c

@@ -152,7 +152,7 @@ static void setTagValuePairs(void) {
     nbPairs++;
     g_pairs[nbPairs].item = "Threshold";
     g_pairs[nbPairs].value = strings.tmp.tmp + ADDRESS_LENGTH_STR;
-    g_pairs[nbPairs].aliasValue = 1;
+    g_pairs[nbPairs].aliasValue = true;
     g_pairs[nbPairs].extension = &extensions[1];
     extensions[1].aliasType = TAG_VALUE_LIST_ALIAS;
     extensions[1].title = "";

src/nbgl/ui_tx_simulation.c

@@ -1,7 +1,6 @@
 #include "apdu_constants.h"
 #include "utils.h"
 #include "nbgl_use_case.h"
-#include "glyphs.h"
 #include "ui_nbgl.h"
 #include "ui_callbacks.h"
 #include "ui_callbacks.h"