Merge branch 'LedgerHQ:develop' into 7702-phase1

Author: btchip

.github/workflows/cflite_cron.yml

@@ -35,6 +35,6 @@ jobs:
         uses: google/clusterfuzzlite/actions/run_fuzzers@v1
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
-          fuzz-seconds: 300  # 5 minutes
+          fuzz-seconds: 900  # 15 minutes
           mode: ${{ matrix.mode }}
           sanitizer: ${{ matrix.sanitizer }}

.github/workflows/codeql_checks.yml

@@ -24,7 +24,7 @@ jobs:
         language: ['cpp']
     runs-on: ubuntu-latest
     container:
-      image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-legacy:latest
+      image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest
 
     steps:
       - name: Clone

Makefile

@@ -103,12 +103,6 @@ PATH_APP_LOAD_PARAMS += "45'" "44'/1'"
 VARIANT_PARAM = CHAIN
 VARIANT_VALUES = $(SUPPORTED_CHAINS)
 
-# Activate dependency only for specific CHAIN
-ifneq ($(CHAIN),ethereum)
-    DEP_APP_LOAD_PARAMS = Ethereum:$(APPVERSION)
-    DEFINES_LIB = USE_LIB_ETHEREUM
-endif
-
 # Enabling DEBUG flag will enable PRINTF and disable optimizations
 #DEBUG = 1
 
@@ -117,9 +111,16 @@ endif
 ########################################
 # See SDK `include/appflags.h` for the purpose of each permission
 #HAVE_APPLICATION_FLAG_DERIVE_MASTER = 1
-HAVE_APPLICATION_FLAG_GLOBAL_PIN = 1
-HAVE_APPLICATION_FLAG_BOLOS_SETTINGS = 1
-HAVE_APPLICATION_FLAG_LIBRARY = 1
+#HAVE_APPLICATION_FLAG_GLOBAL_PIN = 1
+#HAVE_APPLICATION_FLAG_BOLOS_SETTINGS = 1
+ifeq ($(CHAIN),ethereum)
+    HAVE_APPLICATION_FLAG_LIBRARY = 1
+else
+    # Activate dependency only for specific CHAIN
+    DEP_APP_LOAD_PARAMS = Ethereum:$(APPVERSION)
+    DEFINES_LIB = USE_LIB_ETHEREUM
+endif
+
 
 ########################################
 # Application communication interfaces #

client/src/ledger_app_clients/ethereum/enum_value.py

@@ -1,6 +1,6 @@
 from enum import IntEnum
 from typing import Optional
-from .tlv import format_tlv
+from .tlv import TlvSerializable
 from .keychain import sign_data, Key
 
 
@@ -15,7 +15,7 @@ class Tag(IntEnum):
     SIGNATURE = 0xff
 
 
-class EnumValue:
+class EnumValue(TlvSerializable):
     version: int
     chain_id: int
     contract_addr: bytes
@@ -45,15 +45,15 @@ def __init__(self,
 
     def serialize(self) -> bytes:
         payload = bytearray()
-        payload += format_tlv(Tag.VERSION, self.version)
-        payload += format_tlv(Tag.CHAIN_ID, self.chain_id)
-        payload += format_tlv(Tag.CONTRACT_ADDR, self.contract_addr)
-        payload += format_tlv(Tag.SELECTOR, self.selector)
-        payload += format_tlv(Tag.ID, self.id)
-        payload += format_tlv(Tag.VALUE, self.value)
-        payload += format_tlv(Tag.NAME, self.name)
+        payload += self.serialize_field(Tag.VERSION, self.version)
+        payload += self.serialize_field(Tag.CHAIN_ID, self.chain_id)
+        payload += self.serialize_field(Tag.CONTRACT_ADDR, self.contract_addr)
+        payload += self.serialize_field(Tag.SELECTOR, self.selector)
+        payload += self.serialize_field(Tag.ID, self.id)
+        payload += self.serialize_field(Tag.VALUE, self.value)
+        payload += self.serialize_field(Tag.NAME, self.name)
         sig = self.signature
         if sig is None:
             sig = sign_data(Key.CALLDATA, payload)
-        payload += format_tlv(Tag.SIGNATURE, sig)
+        payload += self.serialize_field(Tag.SIGNATURE, sig)
         return payload