Merge pull request #536 from LedgerHQ/feat/apa/explicit_unknown_ticker

Explicit unknown ticker

Author: apaillier-ledger

src/handle_get_printable_amount.c

@@ -31,6 +31,10 @@ void handle_get_printable_amount(get_printable_amount_parameters_t* params,
     }
     // If the amount is a fee, the ticker should be the chain's native currency
     if (params->is_fee) {
+        // fallback mechanism in the absence of chain ID in swap config
+        if (chain_id == 0) {
+            chain_id = config->chainId;
+        }
         strlcpy(ticker, get_displayable_ticker(&chain_id, config), sizeof(ticker));
         decimals = WEI_TO_ETHER;
     }

src/handle_swap_sign_transaction.c

@@ -49,6 +49,10 @@ bool copy_transaction_parameters(create_transaction_parameters_t* sign_transacti
         return false;
     }
 
+    // fallback mechanism in the absence of chain ID in swap config
+    if (chain_id == 0) {
+        chain_id = config->chainId;
+    }
     // If the amount is a fee, its value is nominated in ETH even if we're doing an ERC20 swap
     strlcpy(ticker, get_displayable_ticker(&chain_id, config), sizeof(ticker));
     decimals = WEI_TO_ETHER;

src/network.c

@@ -11,6 +11,8 @@ typedef struct network_info_s {
     uint64_t chain_id;
 } network_info_t;
 
+static const char *unknown_ticker = "???";
+
 // Mappping of chain ids to networks.
 static const network_info_t NETWORK_MAPPING[] = {
     {.chain_id = 1, .name = "Ethereum", .ticker = "ETH"},
@@ -140,7 +142,11 @@ const char *get_displayable_ticker(const uint64_t *chain_id, const chain_config_
     const char *ticker = get_network_ticker_from_chain_id(chain_id);
 
     if (ticker == NULL) {
-        ticker = chain_cfg->coinName;
+        if (*chain_id == chain_cfg->chainId) {
+            ticker = chain_cfg->coinName;
+        } else {
+            ticker = unknown_ticker;
+        }
     }
     return ticker;
 }