Merge pull request #514 from LedgerHQ/fix/apa/token_ticker_length_check

apaillier-ledger · web-flow · commit ffc1b898b438 · 2023-12-18T17:45:37.000+01:00
Fix comparison for token ticker length being off by one
diff --git a/src_features/provideErc20TokenInformation/cmd_provideTokenInfo.c b/src_features/provideErc20TokenInformation/cmd_provideTokenInfo.c
@@ -127,7 +127,7 @@ void handleProvideErc20TokenInformation(uint8_t p1,
     }
     tickerLength = workBuffer[offset++];
     dataLength--;
-    if ((tickerLength + 1) >= sizeof(token->ticker)) {
+    if ((tickerLength + 1) > sizeof(token->ticker)) {
         THROW(0x6A80);
     }
     if (dataLength < tickerLength + 20 + 4 + 4) {

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ void handleProvideErc20TokenInformation(uint8_t p1,`
`127`	`127`	`}`
`128`	`128`	`tickerLength = workBuffer[offset++];`
`129`	`129`	`dataLength--;`
`130`		`- if ((tickerLength + 1) >= sizeof(token->ticker)) {`
	`130`	`+ if ((tickerLength + 1) > sizeof(token->ticker)) {`
`131`	`131`	`THROW(0x6A80);`
`132`	`132`	`}`
`133`	`133`	`if (dataLength < tickerLength + 20 + 4 + 4) {`