[update] Branch develop | Commit 70cc0a87ffc0ebe77450e52d23231a44962e5945

[update] Branch develop | Commit 97f17b28cf7dcd74933126f8105e246713bf3d58

Author: ldg-github-ci

CHANGELOG.md

@@ -5,7 +5,27 @@
 | :rotating_light:     | Breaks build                  |
 | :warning:            | Breaks compatibility with app |
 
-## [latest](/) - 2023/10/19
+## [latest](/) - 2023/12/07
+
+### Fixed
+
+* standard\_plugin build ([this PR on the SDK](https://github.com/LedgerHQ/ledger-secure-sdk/pull/473) had broken it)
+* Broken variant auto-setting in the standard\_plugin Makefile
+* Missing null-check on parameters received by the plugins
+
+### Changed
+
+* utils renamed to plugin\_utils to prevent filename conflicts in plugins
+
+## [4d8e044](/../../commit/4d8e044) - 2023/11/09
+
+### Added
+
+* standard\_plugin Makefile so plugins can use it & have a really small Makefile
+with only the relevant information
+* Comments in the plugin interface header file
+
+## [1fe4085](/../../commit/1fe4085) - 2023/10/19
 
 ### Changed
 

include/main.c

@@ -53,28 +53,32 @@ static void call_app_ethereum() {
 
 // Function to dispatch calls from the ethereum app.
 static void dispatch_call(int message, void *parameters) {
-    switch (message) {
-        case ETH_PLUGIN_INIT_CONTRACT:
-            handle_init_contract(parameters);
-            break;
-        case ETH_PLUGIN_PROVIDE_PARAMETER:
-            handle_provide_parameter(parameters);
-            break;
-        case ETH_PLUGIN_FINALIZE:
-            handle_finalize(parameters);
-            break;
-        case ETH_PLUGIN_PROVIDE_INFO:
-            handle_provide_token(parameters);
-            break;
-        case ETH_PLUGIN_QUERY_CONTRACT_ID:
-            handle_query_contract_id(parameters);
-            break;
-        case ETH_PLUGIN_QUERY_CONTRACT_UI:
-            handle_query_contract_ui(parameters);
-            break;
-        default:
-            PRINTF("Unhandled message %d\n", message);
-            break;
+    if (parameters != NULL) {
+        switch (message) {
+            case ETH_PLUGIN_INIT_CONTRACT:
+                handle_init_contract(parameters);
+                break;
+            case ETH_PLUGIN_PROVIDE_PARAMETER:
+                handle_provide_parameter(parameters);
+                break;
+            case ETH_PLUGIN_FINALIZE:
+                handle_finalize(parameters);
+                break;
+            case ETH_PLUGIN_PROVIDE_INFO:
+                handle_provide_token(parameters);
+                break;
+            case ETH_PLUGIN_QUERY_CONTRACT_ID:
+                handle_query_contract_id(parameters);
+                break;
+            case ETH_PLUGIN_QUERY_CONTRACT_UI:
+                handle_query_contract_ui(parameters);
+                break;
+            default:
+                PRINTF("Unhandled message %d\n", message);
+                break;
+        }
+    } else {
+        PRINTF("Received null parameters\n");
     }
 }
 

include/utils.c renamed to include/plugin_utils.c

@@ -15,7 +15,7 @@
  *  limitations under the License.
  *****************************************************************************/
 
-#include "utils.h"
+#include "plugin_utils.h"
 
 bool find_selector(uint32_t selector, const uint32_t *array, size_t size, size_t *idx) {
     for (size_t i = 0; i < size; ++i) {

include/utils.h renamed to include/plugin_utils.h

@@ -48,7 +48,7 @@ CURVE_APP_LOAD_PARAMS = secp256k1
 PATH_APP_LOAD_PARAMS ?= "44'/60'"
 
 VARIANT_PARAM = COIN
-VARIANTS_VALUES ?= $(NORMAL_NAME)
+VARIANT_VALUES ?= $(NORMAL_NAME)
 
 HAVE_APPLICATION_FLAG_LIBRARY = 1
 
@@ -57,6 +57,8 @@ DISABLE_STANDARD_SNPRINTF = 1
 DISABLE_STANDARD_USB = 1
 DISABLE_STANDARD_WEBUSB = 1
 DISABLE_STANDARD_BAGL_UX_FLOW = 1
+DISABLE_DEBUG_LEDGER_ASSERT = 1
+DISABLE_DEBUG_THROW = 1
 
 # Required for PRINTFs to compile
 ifeq ($(DEBUG),0)