Skip to content

Commit 3450f0a

Browse files
committed
Updates after PR review + install ledgered from PyPi
1 parent d334531 commit 3450f0a

File tree

4 files changed

+6
-53
lines changed

4 files changed

+6
-53
lines changed

.github/workflows/_get_app_metadata.yml

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ on:
3333
default: ''
3434
type: string
3535
use_case:
36-
description: "The use case to build the application for"
36+
description: "The use case to build the application for. Ignored if 'flags' is set"
3737
required: false
3838
default: ''
3939
type: string
@@ -72,22 +72,9 @@ jobs:
7272
submodules: recursive
7373
token: ${{ secrets.token && secrets.token || github.token }}
7474

75-
# To be suppressed when ledgered for manifest v2 is released
76-
- name: Clone ledgered repository
77-
uses: actions/checkout@v4
78-
with:
79-
repository: LedgerHQ/ledgered
80-
ref: y333/manage_pytest_swap_directory
81-
path: ledgered
82-
token: ${{ secrets.token && secrets.token || github.token }}
83-
8475
- name: Install dependencies
8576
run: |
86-
# pip install ledgered
87-
# Install the local version of ledgered
88-
cd ledgered
89-
python -m pip install --upgrade pip
90-
python -m pip install -e .[dev]
77+
pip install ledgered
9178
9279
- name: Gather application metadata, from inputs or 'ledger_app.toml'
9380
id: fetch_metadata

.github/workflows/_get_test_metadata.yml

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@ on:
1919
type: string
2020
pytest_directory:
2121
description: |
22-
The directory where the Python tests are stored (a `conftest.py` file is expected there).
22+
The directory where the Python tests are stored (a `conftest.py` file is expected inside).
2323
required: false
2424
default: 'None'
2525
type: string
2626
outputs:
2727
pytest_directory:
2828
description: |
29-
The directory where the Python tests are stored (a `conftest.py` file is expected there).
29+
The directory where the Python tests are stored (a `conftest.py` file is expected inside).
3030
value: ${{ jobs.fetch_metadata.outputs.pytest_directory }}
3131

3232
env:
@@ -46,22 +46,9 @@ jobs:
4646
submodules: recursive
4747
token: ${{ secrets.token && secrets.token || github.token }}
4848

49-
# To be suppressed when ledgered for manifest v2 is released
50-
- name: Clone ledgered repository
51-
uses: actions/checkout@v4
52-
with:
53-
repository: LedgerHQ/ledgered
54-
ref: y333/manage_pytest_swap_directory
55-
path: ledgered
56-
token: ${{ secrets.token && secrets.token || github.token }}
57-
5849
- name: Install dependencies
5950
run: |
60-
# pip install ledgered
61-
# Install the local version of ledgered
62-
cd ledgered
63-
python -m pip install --upgrade pip
64-
python -m pip install -e .[dev]
51+
pip install ledgered
6552
6653
- name: Gather application metadata, from inputs or 'ledger_app.toml'
6754
id: fetch_metadata

.github/workflows/reusable_build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ on:
2323
default: ''
2424
type: string
2525
use_case:
26-
description: "The use case to build the application for"
26+
description: "The use case to build the application for. Ignored if 'flags' is set"
2727
required: false
2828
default: ''
2929
type: string

.github/workflows/reusable_ragger_tests.yml

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -177,27 +177,6 @@ jobs:
177177
if: ${{ inputs.lib_binaries_artifact != '' }}
178178
run: ls -R ${{ needs.call_get_test_metadata.outputs.pytest_directory }}/lib_binaries/
179179

180-
# To be suppressed when ledgered for manifest v2 is released
181-
- name: Clone ledgered repository
182-
uses: actions/checkout@v4
183-
with:
184-
repository: LedgerHQ/ledgered
185-
ref: y333/manage_pytest_swap_directory
186-
path: ledgered
187-
fetch-tags: true
188-
fetch-depth: 0
189-
token: ${{ secrets.token && secrets.token || github.token }}
190-
191-
- name: Install local version of ledgered
192-
run: |
193-
# Install the local version of ledgered
194-
cd ledgered
195-
python -m pip install --upgrade pip
196-
pip install -e .[dev]
197-
cd ..
198-
rm -rf ledgered/tests
199-
# #######################################################
200-
201180
- name: Install tests dependencies
202181
run: |
203182
sudo apt-get update && sudo apt-get install -y qemu-user-static tesseract-ocr libtesseract-dev

0 commit comments

Comments
 (0)