move logic in check_makefile.sh

Author: mbrousset-ledger

.github/workflows/_check_makefile.yml

@@ -97,49 +97,7 @@ jobs:
           echo "BOLOS_SDK=${BOLOS_SDK}" >> "${GITHUB_ENV}"
           echo "BOLOS_SDK will be set to: ${BOLOS_SDK}"
 
-      - name: Check for forbidden flags
-        id: check-no-debug-flag
-        shell: bash
-        if: ${{ needs.call_get_app_metadata.outputs.is_rust == 'false' }}
-        working-directory: app-repository
-        run: |
-          forbidden_flags=$(jq -r '.forbidden.c[]' ../ledger-app-workflows/config/forbidden-flags.json)
-
-          BUILD_DEVICE_NAME="${{ matrix.device }}"
-          BUILD_DEVICE_NAME="${BUILD_DEVICE_NAME/sp/s2}"
-
-          entrypoint_filepath=$(grep -rP \
-                                         --exclude-dir='deps' \
-                                         --exclude-dir='tests' \
-                                         --exclude-dir='vendor' \
-                                         --include='*.c' \
-                                         '\b(app_)?main\s*\([^)]*\)' . | cut -d':' -f1 | head -n1)
-
-          entrypoint_filepath=${entrypoint_filepath#./}
-          entrypoint_filepath=${entrypoint_filepath%.c}.o
-
-          build_dir=$(ledger-manifest -ob ledger_app.toml)
-          if [ -z "${build_dir}" ]; then
-            echo "build directory not found in ledger_app.toml!" >&2
-            exit 1
-          fi
-
-          make ${{ needs.call_get_app_metadata.outputs.flags }} \
-               ${ADDITIONAL_ARGS} \
-               BOLOS_SDK="${BOLOS_SDK}" \
-               --dry-run build/${BUILD_DEVICE_NAME}/obj/app/${entrypoint_filepath} 2>&1 | tee -a build_dry_run_output.txt
-
-          for forbidden_flag in $forbidden_flags; do
-            echo "[INFO] Checking for forbidden flag $forbidden_flag"
-            if grep -q "$forbidden_flag" build_dry_run_output.txt; then
-              echo "[ERROR] Detected forbidden flag $forbidden_flag in build output. Aborting."
-              exit 1
-            else
-              echo "[INFO] Did not find forbidden flag $forbidden_flag in build output. Continuing."
-            fi
-          done
-
       - name: Run script
         run: |
             ./ledger-app-workflows/scripts/check_all.sh -c makefile -t "${{ matrix.device }}" \
-              -a ./app-repository -m "${DOWNLOAD_MANIFEST_ARTIFACT_NAME}"
+              -a ./app-repository -m "${DOWNLOAD_MANIFEST_ARTIFACT_NAME}" -w ../ledger-app-workflows

scripts/check_all.sh

@@ -33,6 +33,7 @@ help() {
     echo
     echo "  -c <check>  : Requested check from (${ALL_CHECKS}). Default is all."
     echo "  -d <dir>    : Database directory"
+    echo "  -w <dir>    : Workflows directory"
     echo "  -a <dir>    : Application directory"
     echo "  -b <dir>    : Application build directory"
     echo "  -m <file>   : Manifest (file or directory)"
@@ -50,14 +51,15 @@ help() {
 #
 #===============================================================================
 
-while getopts ":a:b:c:d:m:t:rvh" opt; do
+while getopts ":a:b:c:d:m:t:w:rvh" opt; do
     case ${opt} in
         a)  APP_DIR=${OPTARG}   ;;
         b)  BUILD_DIR=${OPTARG} ;;
         c)  REQUESTED_CHECK=${OPTARG} ;;
         d)  DATABASE_DIR=${OPTARG} ;;
         m)  MANIFEST=${OPTARG}  ;;
         t)  TARGET=${OPTARG}    ;;
+        w)  WORKFLOWS_DIR=${OPTARG} ;;
         r)  IS_RUST=true ;;
         v)  VERBOSE=true ;;
         h)  help ;;
@@ -128,6 +130,16 @@ if [[ (-z ${REQUESTED_CHECK}) || ("${REQUESTED_CHECK}" == app_load_params) ]]; t
     fi
 fi
 
+if [[ (-z ${REQUESTED_CHECK}) || ("${REQUESTED_CHECK}" == makefile) ]]; then
+    if [[ -z "${WORKFLOWS_DIR}" ]]; then
+        # Check if WORKFLOWS_DIR is already present
+        WORKFLOWS_DIR="/tmp/ledger-app-workflows"
+        if [[ ! -d "$WORKFLOWS_DIR" ]]; then
+            git clone "${verbose_mode[@]}" https://github.com/LedgerHQ/ledger-app-database.git "${WORKFLOWS_DIR}"
+        fi
+    fi
+fi
+
 #===============================================================================
 #
 #     log functions
@@ -206,7 +218,7 @@ call_step() {
             COMMAND="python3 ${DATABASE_DIR}/scripts/app_load_params_check.py --database_path ${DATABASE_DIR}/app-load-params-db.json --app_manifests_path ${MANIFEST_DIR}"
             ;;
         "makefile")
-            COMMAND="${dirName}/check_makefile.sh ${APP_DIR} ${REPO_NAME} ${MANIFEST_DIR} ${TARGET}"
+            COMMAND="${dirName}/check_makefile.sh ${APP_DIR} ${REPO_NAME} ${MANIFEST_DIR} ${WORKFLOWS_DIR} ${TARGET}"
             ;;
         "readme")
             COMMAND="${dirName}/check_readme.sh ${APP_DIR} ${REPO_NAME}"

scripts/check_makefile.sh

@@ -10,7 +10,8 @@ main() (
     repo="$1"
     repo_name="$2"
     manifests_dir="$3"
-    target="$4"
+    workflows_dir="$4"
+    target="$5"
 
     declare -A variants_array
     declare -A appnames_array
@@ -92,6 +93,48 @@ main() (
         error=1
     fi
 
+    # check if there are no forbidden compilation flags (e.g. debug flags)
+    forbidden_flags_file="${workflows_dir}/config/forbidden-flags.json"
+    forbidden_flags=$(jq -r '.forbidden.c[]' "$forbidden_flags_file")
+
+    entrypoint_filepath=$(grep -rP \
+        --exclude-dir='deps' \
+        --exclude-dir='tests' \
+        --exclude-dir='vendor' \
+        --include='*.c' \
+        '\b(app_)?main\s*\([^)]*\)' . | cut -d':' -f1 | head -n1)
+    entrypoint_filepath=${entrypoint_filepath#./}
+    entrypoint_filepath=${entrypoint_filepath%.c}.o
+
+    build_dir=$(ledger-manifest -ob ledger_app.toml)
+    if [ -n "${build_dir}" ]; then
+        for cur_manifest in $manifests_list; do
+            for variant in "${!variants_array[@]}"; do
+                build_target=$(jq -r ".VARIANTS.${variant}.TARGET" "${cur_manifest}")
+                eval "BOLOS_SDK=\$$(echo "${build_target/s2/sp}" | tr '[:lower:]' '[:upper:]')_SDK"
+
+                log_info "Trying to make --dry-run for rule build/${build_target}/obj/app/${entrypoint_filepath}. Using $BOLOS_SDK"
+
+                make -C "${build_dir}"  \
+                    BOLOS_SDK="${BOLOS_SDK}" \
+                    --dry-run build/"${build_target}"/obj/app/"${entrypoint_filepath}" 2>&1 | tee build_dry_run_output.txt
+
+                for forbidden_flag in $forbidden_flags; do
+                    log_info "Checking for forbidden flag $forbidden_flag"
+                    if grep -q "$forbidden_flag" build_dry_run_output.txt; then
+                        log_error_no_header "Detected forbidden flag $forbidden_flag in build output."
+                        error=1
+                    else
+                        log_info "Did not find forbidden flag $forbidden_flag in build output."
+                    fi
+                done
+            done
+        done
+    else
+        log_error_no_header "build directory not found in ledger_app.toml!" >&2
+        error=1
+    fi
+
     if [[ error -eq 0 ]]; then
         log_success "The Makefile is compliant"
     else