Skip to content

Commit f45eba5

Browse files
Merge pull request #116 from LedgerHQ/cev/update_enforcer_status
Copy full status of guideline enforcer in a md file to be used by app-tester
2 parents b2ab309 + d19261f commit f45eba5

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

scripts/check_all.sh

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ call_step() {
170170
log_step "Get ${step} (All targets)"
171171
ALL_TARGETS=$(ledger-manifest --output-devices ledger_app.toml | tail -n +2 | awk -F" " '{print $2}' | sed 's/+/p/' )
172172
for tgt in ${ALL_TARGETS}; do
173+
echo "Processing target: ${tgt}"
173174
eval BOLOS_SDK="$(echo "\$${tgt}" | tr '[:lower:]' '[:upper:]')_SDK"
174175
if [[ "${IS_RUST}" == true ]]; then
175176
COMMAND="(cd ${APP_DIR} && python3 ${dirName}/cargo_metadata_dump.py --device ${tgt} --app_build_path ${BUILD_DIR} --json_path ${MANIFEST_DIR}/manifest_${tgt}.json)"
@@ -181,9 +182,11 @@ call_step() {
181182
err=$?
182183
if [[ ${err} -ne 0 ]]; then
183184
log_error "Check ${step} failed"
185+
echo -n "|:x:" >> "${FILE_STATUS}"
184186
exit 1
185187
fi
186188
done
189+
echo -n "|:white_check_mark:" >> "${FILE_STATUS}"
187190
return
188191
fi
189192
;;
@@ -220,7 +223,10 @@ call_step() {
220223
err=$?
221224
if [[ ${err} -ne 0 ]]; then
222225
log_error "Check ${step} failed"
223-
exit 1
226+
echo -n "|:x:" >> "${FILE_STATUS}"
227+
[[ "${step}" == manifest ]] && exit 1
228+
else
229+
echo -n "|:white_check_mark:" >> "${FILE_STATUS}"
224230
fi
225231
}
226232

@@ -236,6 +242,8 @@ else
236242
log_title "Running Guideline_enforcer checks for '${TARGET}'"
237243
fi
238244

245+
FILE_STATUS="/tmp/check_status.md"
246+
rm -f "${FILE_STATUS}"
239247
if [[ -z ${REQUESTED_CHECK} ]]; then
240248
REQUESTED_CHECK="${ALL_CHECKS}"
241249
else
@@ -250,9 +258,14 @@ for check in ${REQUESTED_CHECK}; do
250258
call_step "${check}"
251259
done
252260

253-
echo
254-
if [[ -z "${TARGET}" ]]; then
255-
log_success "Successfully ran Guideline_enforcer checks"
261+
nb_errors=$(grep -o ":x:" "${FILE_STATUS}" | wc -l)
262+
echo ""
263+
264+
[[ -n "${TARGET}" ]] && SUBSTR="for '${TARGET}'"
265+
if [[ "${nb_errors}" -eq 0 ]]; then
266+
log_success "Successful Guideline_enforcer checks ${SUBSTR}"
267+
exit 0
256268
else
257-
log_success "Successfully ran Guideline_enforcer checks for '${TARGET}'"
269+
log_error_no_header "Fail with ${nb_errors} error(s) during Guideline_enforcer checks ${SUBSTR}"
270+
exit 1
258271
fi

0 commit comments

Comments
 (0)