🐛 (ledger-button) [LBD-260]: Fix transaction parameter detection for typed data error messages (#248)

Author: mbertin-ledger

packages/ledger-button/src/domain/sign-transaction/sign-transaction-controller.ts

@@ -5,6 +5,9 @@ import {
   isBroadcastedTransactionResult,
   isSignedMessageOrTypedDataResult,
   isSignedTransactionResult,
+  isSignPersonalMessageParams,
+  isSignRawTransactionParams,
+  isSignTransactionParams,
   type SignedResults,
   type SignFlowStatus,
   type SignPersonalMessageParams,
@@ -161,6 +164,28 @@ export class SignTransactionController implements ReactiveController {
       : this.lang.currentTranslation.common.device.model.fallback;
   }
 
+  private isTransactionParameter(
+    transactionParams:
+      | SignTransactionParams
+      | SignRawTransactionParams
+      | SignTypedMessageParams
+      | SignPersonalMessageParams
+      | undefined,
+  ): boolean {
+    if (!transactionParams) {
+      return false;
+    }
+
+    if (isSignPersonalMessageParams(transactionParams)) {
+      return false;
+    }
+
+    return (
+      isSignTransactionParams(transactionParams) ||
+      isSignRawTransactionParams(transactionParams)
+    );
+  }
+
   private mapSuccessToState(data: SignedResults): ScreenState {
     const lang = this.lang.currentTranslation;
 
@@ -323,7 +348,7 @@ export class SignTransactionController implements ReactiveController {
       }
       case error instanceof UserRejectedTransactionError: {
         const deviceName = this.getDeviceName();
-        const isTx = isSignedTransactionResult(this.currentTransaction);
+        const isTx = this.isTransactionParameter(this.currentTransaction);
         this.state = {
           screen: "error",
           status: {