Fix NBGL object issues when null strings are provided

Author: yogh333

.github/workflows/get_rust_apps.py

@@ -11,8 +11,7 @@
 # Excluded Rust apps
 # app-kadena-legacy: has been replaced by app-kadena
 # app-pocket: does not build (Obsidians' Alamgu issue)
-# app-age: not maintained anymore
-excluded_apps = ["app-kadena-legacy", "app-pocket", "app-age"]
+excluded_apps = ["app-kadena-legacy", "app-pocket"]
 
 # Retrieve all public apps on LedgerHQ GitHub organization
 token = sys.argv[1]

ledger_device_sdk/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ledger_device_sdk"
-version = "1.22.8"
+version = "1.22.9"
 authors = ["yhql", "yogh333", "agrojean-ledger", "kingofpayne"]
 edition = "2021"
 license.workspace = true

ledger_device_sdk/src/nbgl/nbgl_choice.rs

@@ -73,10 +73,22 @@ impl<'a> NbglChoice<'a> {
             self.ux_sync_init();
             nbgl_useCaseChoice(
                 &icon as *const nbgl_icon_details_t,
-                message.as_ptr() as *const c_char,
-                sub_message.as_ptr() as *const c_char,
-                confirm_text.as_ptr() as *const c_char,
-                cancel_text.as_ptr() as *const c_char,
+                match message.is_empty() {
+                    true => core::ptr::null(),
+                    false => message.as_ptr() as *const c_char,
+                },
+                match sub_message.is_empty() {
+                    true => core::ptr::null(),
+                    false => sub_message.as_ptr() as *const c_char,
+                },
+                match confirm_text.is_empty() {
+                    true => core::ptr::null(),
+                    false => confirm_text.as_ptr() as *const c_char,
+                },
+                match cancel_text.is_empty() {
+                    true => core::ptr::null(),
+                    false => cancel_text.as_ptr() as *const c_char,
+                },
                 Some(choice_callback),
             );
             let sync_ret = self.ux_sync_wait(false);

ledger_device_sdk/src/nbgl/nbgl_review.rs

@@ -107,9 +107,18 @@ impl<'a> NbglReview<'a> {
                         self.tx_type.to_c_type(false),
                         &tag_value_list as *const nbgl_contentTagValueList_t,
                         &icon as *const nbgl_icon_details_t,
-                        self.title.as_ptr() as *const c_char,
-                        self.subtitle.as_ptr() as *const c_char,
-                        self.finish_title.as_ptr() as *const c_char,
+                        match self.title.is_empty() {
+                            true => core::ptr::null(),
+                            false => self.title.as_ptr() as *const c_char,
+                        },
+                        match self.subtitle.is_empty() {
+                            true => core::ptr::null(),
+                            false => self.subtitle.as_ptr() as *const c_char,
+                        },
+                        match self.finish_title.is_empty() {
+                            true => core::ptr::null(),
+                            false => self.finish_title.as_ptr() as *const c_char,
+                        },
                         core::ptr::null(),
                         Some(choice_callback),
                     );
@@ -120,9 +129,18 @@ impl<'a> NbglReview<'a> {
                             self.tx_type.to_c_type(false),
                             &tag_value_list as *const nbgl_contentTagValueList_t,
                             &icon as *const nbgl_icon_details_t,
-                            self.title.as_ptr() as *const c_char,
-                            self.subtitle.as_ptr() as *const c_char,
-                            self.finish_title.as_ptr() as *const c_char,
+                            match self.title.is_empty() {
+                                true => core::ptr::null(),
+                                false => self.title.as_ptr() as *const c_char,
+                            },
+                            match self.subtitle.is_empty() {
+                                true => core::ptr::null(),
+                                false => self.subtitle.as_ptr() as *const c_char,
+                            },
+                            match self.finish_title.is_empty() {
+                                true => core::ptr::null(),
+                                false => self.finish_title.as_ptr() as *const c_char,
+                            },
                             Some(choice_callback),
                         );
                     } else {