Delay lock + better ticker management

Author: yogh333

ledger_device_sdk/src/io.rs

@@ -397,7 +397,7 @@ impl Comm {
             seph::Events::BleReceive => ble::receive(&mut self.apdu_buffer, spi_buffer),
 
             seph::Events::TickerEvent => {
-                #[cfg(any(target_os = "stax", target_os = "flex"))]
+                #[cfg(any(target_os = "stax", target_os = "flex", feature = "nano_nbgl"))]
                 unsafe {
                     ux_process_ticker_event();
                 }

ledger_device_sdk/src/seph.rs

@@ -201,7 +201,12 @@ pub fn handle_event(apdu_buffer: &mut [u8], spi_buffer: &[u8]) {
         #[cfg(any(target_os = "nanox", target_os = "stax", target_os = "flex"))]
         Events::BleReceive => ble::receive(apdu_buffer, spi_buffer),
         Events::CAPDUEvent => handle_capdu_event(apdu_buffer, spi_buffer),
-        Events::TickerEvent => { /* unsafe{ G_io_app.ms += 100; } */ }
+        Events::TickerEvent => {
+            #[cfg(any(target_os = "stax", target_os = "flex", feature = "nano_nbgl"))]
+            unsafe {
+                ux_process_ticker_event();
+            }
+        }
         _ => (),
     }
 }

ledger_device_sdk/src/ui/gadgets.rs

@@ -567,7 +567,7 @@ impl<'a> MultiPageMenu<'a> {
                 },
                 io::Event::Command(ins) => return EventOrPageIndex::Event(io::Event::Command(ins)),
                 io::Event::Ticker => {
-                    if UxEvent::Event.request() != BOLOS_UX_OK {
+                    if UxEvent::Event.request(None) != BOLOS_UX_OK {
                         // pin lock management
                         UxEvent::block_and_get_event::<Temp>(self.comm);
                         // notify Ticker event only when redisplay is required

ledger_device_sdk/src/uxapp.rs

@@ -11,8 +11,8 @@ pub use ledger_secure_sdk_sys::BOLOS_UX_IGNORE;
 pub use ledger_secure_sdk_sys::BOLOS_UX_OK;
 pub use ledger_secure_sdk_sys::BOLOS_UX_REDRAW;
 
-fn os_ux_rs(params: &bolos_ux_params_t) {
-    unsafe { os_ux(params as *const bolos_ux_params_t as *mut bolos_ux_params_t) };
+unsafe extern "C" {
+    pub unsafe static mut G_ux_params: bolos_ux_params_t;
 }
 
 #[repr(u8)]
@@ -21,31 +21,46 @@ pub enum UxEvent {
     Keyboard = BOLOS_UX_KEYBOARD,
     WakeUp = BOLOS_UX_WAKE_UP,
     ValidatePIN = BOLOS_UX_VALIDATE_PIN,
-    LastID = BOLOS_UX_VALIDATE_PIN + 1,
+    DelayLock = BOLOS_UX_DELAY_LOCK,
+    LastID = BOLOS_UX_DELAY_LOCK + 1,
 }
 
 impl UxEvent {
-    pub fn request(&self) -> u32 {
-        let mut params = bolos_ux_params_t::default();
-        params.ux_id = match self {
-            Self::Event => Self::Event as u8,
-            Self::Keyboard => Self::Keyboard as u8,
-            Self::WakeUp => Self::WakeUp as u8,
-            Self::ValidatePIN => {
-                // Perform pre-wake up
-                params.ux_id = Self::WakeUp as u8;
-                os_ux_rs(&params);
+    #[allow(unused)]
+    pub fn request(&self, val: Option<u32>) -> u32 {
+        unsafe {
+            //let mut params = bolos_ux_params_t::default();
+            G_ux_params.ux_id = match self {
+                Self::Event => Self::Event as u8,
+                Self::Keyboard => Self::Keyboard as u8,
+                Self::WakeUp => Self::WakeUp as u8,
+                Self::ValidatePIN => {
+                    // Perform pre-wake up
+                    G_ux_params.ux_id = Self::WakeUp as u8;
+                    os_ux(&raw mut G_ux_params as *mut bolos_ux_params_t);
 
-                Self::ValidatePIN as u8
-            }
-            Self::LastID => panic!("Unknown UX Event"),
-        };
+                    Self::ValidatePIN as u8
+                }
+                Self::DelayLock => {
+                    #[cfg(any(target_os = "stax", target_os = "flex", feature = "nano_nbgl"))]
+                    {
+                        G_ux_params.u = bolos_ux_params_s__bindgen_ty_1 {
+                            lock_delay: bolos_ux_params_s__bindgen_ty_1__bindgen_ty_3 {
+                                delay_ms: val.unwrap_or(10000),
+                            },
+                        };
+                    }
+                    Self::DelayLock as u8
+                }
+                Self::LastID => panic!("Unknown UX Event"),
+            };
 
-        os_ux_rs(&params);
+            os_ux(&raw mut G_ux_params as *mut bolos_ux_params_t);
 
-        match self {
-            Self::ValidatePIN => Self::block(),
-            _ => unsafe { os_sched_last_status(TASK_BOLOS_UX as u32) as u32 },
+            match self {
+                Self::ValidatePIN => Self::block(),
+                _ => os_sched_last_status(TASK_BOLOS_UX as u32) as u32,
+            }
         }
     }
 
@@ -58,7 +73,7 @@ impl UxEvent {
                 let mut spi_buffer = [0u8; 256];
                 sys_seph::send_general_status();
                 sys_seph::seph_recv(&mut spi_buffer, 0);
-                UxEvent::Event.request();
+                UxEvent::Event.request(None);
             } else {
                 unsafe { os_sched_yield(BOLOS_UX_OK as u8) };
             }
@@ -83,7 +98,7 @@ impl UxEvent {
                 seph::seph_recv(&mut spi_buffer, 0);
                 event = comm.decode_event(&mut spi_buffer);
 
-                UxEvent::Event.request();
+                UxEvent::Event.request(None);
 
                 if let Option::Some(Event::Command(_)) = event {
                     return (ret, event);

ledger_secure_sdk_sys/src/c/src.c

@@ -251,7 +251,7 @@ void c_reset_bss() {
   memset(bss, 0, bss_len);
 }
 
-bolos_ux_params_t G_ux_params;
+bolos_ux_params_t G_ux_params = {0};
 
 void c_boot_std() {
     // below is a 'manual' implementation of `io_seproxyhal_init`