Merge pull request #261 from LedgerHQ/y333/dev_container_setup

Y333/dev container setup

Author: yogh333

ledger_secure_sdk_sys/.cargo/config.toml renamed to .cargo/config.toml

@@ -1,6 +1,6 @@
 [unstable]
-build-std = ["core"]
+build-std = ["core", "alloc"]
 build-std-features = ["compiler-builtins-mem"]
 
 [build]
-target = "nanosplus"
+target = "flex"

.github/workflows/build_with_current_nightly.yml

@@ -32,7 +32,6 @@ jobs:
           BUILD_DEVICE_NAME="$(echo ${{ matrix.device }})"
           BIN_DIR_NAME="$(echo ${{ matrix.device }} | sed 's/nanosplus/nanos2/')"
           cd app-boilerplate
-          RUST_NIGHTLY=nightly
           cargo ledger build ${{ matrix.device }}
       
       #- name: Upload binary artifacts

.github/workflows/ci.yml

@@ -24,28 +24,12 @@ jobs:
         target: ["nanox", "nanosplus", "stax", "flex"]
         package: [include_gif, testmacro, ledger_secure_sdk_sys, ledger_device_sdk]
     steps:
-      - name: Print Environment variables
-        run:
-          echo "The value of RUST_NIGHTLY is $RUST_NIGHTLY"
       - name: Clone
         uses: actions/checkout@v4
       - name: Cargo clippy
         working-directory: ${{ matrix.package }}
         run: |
-          cargo +$RUST_NIGHTLY clippy --target ${{ matrix.target }}
-
-  clippy-cargo-ledger:
-    name: Run static analysis for cargo-ledger
-    runs-on: ubuntu-latest
-    container:
-      image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools:latest
-    steps:
-      - name: Clone
-        uses: actions/checkout@v4
-      - name: Cargo clippy for cargo-ledger
-        working-directory: cargo-ledger
-        run: |
-          cargo +$RUST_STABLE clippy --no-deps
+          cargo clippy --target ${{ matrix.target }}
 
   format:
     name: Check code formatting
@@ -57,7 +41,7 @@ jobs:
         uses: actions/checkout@v4
       - name: Run cargo fmt
         run: |
-          cargo +$RUST_NIGHTLY fmt --all --check
+          cargo fmt --all --check
 
   build:
     name: Build SDK
@@ -73,20 +57,7 @@ jobs:
       - name: Cargo build
         working-directory: ledger_device_sdk
         run: |
-          cargo +$RUST_NIGHTLY build --target ${{ matrix.target }}
-
-  build-cargo-ledger:
-    name: Build SDK
-    runs-on: ubuntu-latest
-    container:
-      image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools:latest
-    steps:
-      - name: Clone
-        uses: actions/checkout@v4
-      - name: Cargo build
-        working-directory: cargo-ledger
-        run: |
-          cargo +$RUST_STABLE build
+          cargo build --target ${{ matrix.target }}
 
   test:
     name: Run unit and integration tests
@@ -102,4 +73,4 @@ jobs:
       - name: Unit tests
         working-directory: ledger_device_sdk
         run: |
-          cargo +$RUST_NIGHTLY test --target ${{ matrix.target }} --features speculos --tests
+          cargo test --target ${{ matrix.target }} --features speculos --tests

.github/workflows/publish.yml

@@ -24,7 +24,7 @@ jobs:
       - name: Test Dry-Run Publish for Each Package
         run: |
           # Iterate through package names retrieved
-          PACKAGE_NAMES="testmacro include_gif ledger_secure_sdk_sys ledger_device_sdk cargo-ledger"
+          PACKAGE_NAMES="testmacro include_gif ledger_secure_sdk_sys ledger_device_sdk"
           for PACKAGE_NAME in $PACKAGE_NAMES; do
             # Test a dry-run publish for each package within the workspace if required
             last_published_version=$(cargo search -q --limit 1 $PACKAGE_NAME | grep -oP '\d+\.\d+\.\d+')
@@ -60,7 +60,7 @@ jobs:
       - name: Publish Package on crates.io if required
         run: |
           # Iterate through package names retrieved
-          PACKAGE_NAMES="testmacro include_gif ledger_secure_sdk_sys ledger_device_sdk cargo-ledger"
+          PACKAGE_NAMES="testmacro include_gif ledger_secure_sdk_sys ledger_device_sdk"
           for PACKAGE_NAME in $PACKAGE_NAMES; do
             # Publish each package within the workspace if required
             last_published_version=$(cargo search -q --limit 1 $PACKAGE_NAME | grep -oP '\d+\.\d+\.\d+')

.github/workflows/reusable_build_all_apps.yml

@@ -139,9 +139,9 @@ jobs:
                 build_directory=$(ledger-manifest --output-build-directory ledger_app.toml)
                 cd $build_directory
                 # Required as patch has a different version from what is locked in Cargo.lock
-                cargo +$RUST_NIGHTLY update include_gif
-                cargo +$RUST_NIGHTLY update ledger_secure_sdk_sys
-                cargo +$RUST_NIGHTLY update ledger_device_sdk
+                cargo update include_gif
+                cargo update ledger_secure_sdk_sys
+                cargo update ledger_device_sdk
                 device=$(echo ${{ matrix.device }} | sed 's/+/plus/')
                 echo "Build for "$device
                 cargo ledger build $device