Skip to content

Commit e63ebc8

Browse files
committed
Add PR trigger for the new workflow
1 parent 3809141 commit e63ebc8

File tree

5 files changed

+13
-6
lines changed

5 files changed

+13
-6
lines changed

.github/workflows/check_csdk_build_parameters.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
name: Build C Boilerplate application and check if C SDK build parameters are still correct
22

33
on:
4+
pull_request:
45
workflow_dispatch:
56
schedule:
67
# * is a special character in YAML so you have to quote this string
@@ -15,7 +16,7 @@ jobs:
1516
- name: Checkout C SDK Build Parameters Extractor
1617
uses: actions/checkout@v4
1718
with:
18-
repository: LedgerHQ/csdk_build_params_x
19+
repository: LedgerHQ/csdk_build_parameters_extractor
1920
path: c_sdk_build_params_x
2021
- name: Build C SDK Build Parameters Extractor
2122
run: |
@@ -48,7 +49,13 @@ jobs:
4849
name: c_sdk_build_params_extractor
4950
- name: Run C SDK Build Parameters Extractor
5051
run: |
51-
c_sdk_build_params_extractor --app-path c_boilerplate \
52+
# to be suppressed when C SDK API_LEVEL_24 is available in dev-tools
53+
git clone https://github.com/LedgerHQ/ledger-secure-sdk.git --branch API_LEVEL_24 --single-branch c_sdk
54+
echo "setting LEDGER_SDK_PATH to $(realpath c_sdk)"
55+
export LEDGER_SDK_PATH=$(realpath c_sdk)
56+
# ####################################### #
57+
chmod +x cbpx
58+
./cbpx --app-path c_boilerplate \
5259
--device ${{ matrix.target }}
5360
# Compare output with matching file
5461
diff c_sdk_build_${{ matrix.target }}.cflags ledger_secure_sdk_sys/c_sdk_build_${{ matrix.target }}.cflags

ledger_secure_sdk_sys/c_sdk_build_flex.defines

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#define USB_SEGMENT_SIZE 64
1414
#define HAVE_WEBUSB
1515
#define WEBUSB_URL_SIZE_B 0
16-
#define WEBUSB_URL
16+
#define WEBUSB_URL
1717
#define HAVE_IO_U2F
1818
#define OS_IO_SEPROXYHAL
1919
#define STANDARD_APP_SYNC_RAPDU

ledger_secure_sdk_sys/c_sdk_build_nanosplus.defines

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#define USB_SEGMENT_SIZE 64
1010
#define HAVE_WEBUSB
1111
#define WEBUSB_URL_SIZE_B 0
12-
#define WEBUSB_URL
12+
#define WEBUSB_URL
1313
#define OS_IO_SEPROXYHAL
1414
#define STANDARD_APP_SYNC_RAPDU
1515
#define REVAMPED_IO

ledger_secure_sdk_sys/c_sdk_build_nanox.defines

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#define USB_SEGMENT_SIZE 64
1313
#define HAVE_WEBUSB
1414
#define WEBUSB_URL_SIZE_B 0
15-
#define WEBUSB_URL
15+
#define WEBUSB_URL
1616
#define HAVE_IO_U2F
1717
#define OS_IO_SEPROXYHAL
1818
#define STANDARD_APP_SYNC_RAPDU

ledger_secure_sdk_sys/c_sdk_build_stax.defines

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#define USB_SEGMENT_SIZE 64
1414
#define HAVE_WEBUSB
1515
#define WEBUSB_URL_SIZE_B 0
16-
#define WEBUSB_URL
16+
#define WEBUSB_URL
1717
#define HAVE_IO_U2F
1818
#define OS_IO_SEPROXYHAL
1919
#define STANDARD_APP_SYNC_RAPDU

0 commit comments

Comments
 (0)