Skip to content

Commit ff5cdec

Browse files
committed
Add PR trigger for the new workflow
1 parent 3809141 commit ff5cdec

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

.github/workflows/check_csdk_build_parameters.yml

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
name: Build C Boilerplate application and check if C SDK build parameters are still correct
22

33
on:
4+
pull_request:
45
workflow_dispatch:
56
schedule:
67
# * is a special character in YAML so you have to quote this string
@@ -15,7 +16,7 @@ jobs:
1516
- name: Checkout C SDK Build Parameters Extractor
1617
uses: actions/checkout@v4
1718
with:
18-
repository: LedgerHQ/csdk_build_params_x
19+
repository: LedgerHQ/csdk_build_parameters_extractor
1920
path: c_sdk_build_params_x
2021
- name: Build C SDK Build Parameters Extractor
2122
run: |
@@ -48,15 +49,21 @@ jobs:
4849
name: c_sdk_build_params_extractor
4950
- name: Run C SDK Build Parameters Extractor
5051
run: |
51-
c_sdk_build_params_extractor --app-path c_boilerplate \
52+
# to be suppressed when C SDK API_LEVEL_24 is available in dev-tools
53+
git clone https://github.com/LedgerHQ/ledger-secure-sdk.git --branch API_LEVEL_24 --single-branch c_sdk
54+
echo "setting LEDGER_SDK_PATH to $(realpath c_sdk)"
55+
export LEDGER_SDK_PATH=$(realpath c_sdk)
56+
# ####################################### #
57+
chmod +x cbpx
58+
./cbpx --app-path c_boilerplate \
5259
--device ${{ matrix.target }}
5360
# Compare output with matching file
54-
diff c_sdk_build_${{ matrix.target }}.cflags ledger_secure_sdk_sys/c_sdk_build_${{ matrix.target }}.cflags
61+
diff -Z c_sdk_build_${{ matrix.target }}.cflags ledger_secure_sdk_sys/c_sdk_build_${{ matrix.target }}.cflags
5562
if [ $? -ne 0 ]; then
5663
echo "C SDK build parameters CFLAGS do not match for target ${{ matrix.target }}"
5764
exit 1
5865
fi
59-
diff c_sdk_build_${{ matrix.target }}.defines ledger_secure_sdk_sys/c_sdk_build_${{ matrix.target }}.defines
66+
diff -Z c_sdk_build_${{ matrix.target }}.defines ledger_secure_sdk_sys/c_sdk_build_${{ matrix.target }}.defines
6067
if [ $? -ne 0 ]; then
6168
echo "C SDK build parameters DEFINES do not match for target ${{ matrix.target }}"
6269
exit 1

ledger_secure_sdk_sys/c_sdk_build_nanox.defines

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#define WEBUSB_URL
1616
#define HAVE_IO_U2F
1717
#define OS_IO_SEPROXYHAL
18-
#define STANDARD_APP_SYNC_RAPDU
18+
#define STANDARD_APP_SYNC_RAPDU
1919
#define REVAMPED_IO
2020
#define gcc
2121
#define __IO volatile

0 commit comments

Comments
 (0)