Merge pull request #13492 from LedgerHQ/feat/LIVE-23912

feat(lwm): removed largemoverLandingPage feature flag

Author: iqbalibrahim-ledger

.changeset/mean-panthers-speak.md

@@ -0,0 +1,7 @@
+---
+"@ledgerhq/types-live": minor
+"live-mobile": minor
+"@ledgerhq/live-common": minor
+---
+
+feat(lwm): removed largermoverLandingPage feature flag

apps/ledger-live-mobile/src/components/RootNavigator/LandingPagesNavigator.tsx

@@ -7,7 +7,6 @@ import { LandingPagesNavigatorParamList } from "./types/LandingPagesNavigator";
 import GenericLandingPage from "LLM/features/LandingPages/screens/GenericLandingPage";
 import { NavigationHeaderCloseButton } from "../NavigationHeaderCloseButton";
 import { LargeMoverLandingPage } from "LLM/features/LandingPages/screens/LargeMoverLandingPage";
-import { useFeature } from "@ledgerhq/live-common/featureFlags/index";
 
 const Stack = createNativeStackNavigator<LandingPagesNavigatorParamList>();
 
@@ -21,24 +20,20 @@ export default function LandingPagesNavigator() {
     headerRight: () => <NavigationHeaderCloseButton />,
   };
 
-  const isLargeMoverFeatureEnabled = useFeature("largemoverLandingpage")?.enabled;
-
   return (
     <Stack.Navigator screenOptions={stackNavigationConfig}>
       <Stack.Screen
         name={ScreenName.GenericLandingPage}
         component={GenericLandingPage}
         options={navigationOptions}
       />
-      {isLargeMoverFeatureEnabled && (
-        <Stack.Screen
-          name={ScreenName.LargeMoverLandingPage}
-          component={LargeMoverLandingPage}
-          options={{
-            headerShown: false,
-          }}
-        />
-      )}
+      <Stack.Screen
+        name={ScreenName.LargeMoverLandingPage}
+        component={LargeMoverLandingPage}
+        options={{
+          headerShown: false,
+        }}
+      />
     </Stack.Navigator>
   );
 }

apps/ledger-live-mobile/src/components/RootNavigator/SettingsNavigator.tsx

@@ -3,8 +3,6 @@ import { createNativeStackNavigator } from "@react-navigation/native-stack";
 import { useTranslation } from "react-i18next";
 import { useTheme } from "styled-components/native";
 import { ScreenName } from "~/const";
-import { useFeature } from "@ledgerhq/live-common/featureFlags/index";
-
 import DebugBenchmarkQRStream from "~/screens/Settings/Debug/Broken/BenchmarkQRStream";
 import DebugBLE from "~/screens/Settings/Debug/Connectivity/BLE";
 import DebugBLEBenchmark from "~/screens/Settings/Debug/Connectivity/BLEBenchmark";
@@ -91,9 +89,8 @@ export default function SettingsNavigator() {
   const { t } = useTranslation();
   const { colors } = useTheme();
   const stackNavConfig = useMemo(() => getStackNavigatorConfig(colors), [colors]);
-
   const noNanoBuyNanoWallScreenOptions = useNoNanoBuyNanoWallScreenOptions();
-  const isLargeMoverFeatureEnabled = useFeature("largemoverLandingpage")?.enabled;
+
   return (
     <Stack.Navigator screenOptions={stackNavConfig}>
       <Stack.Screen
@@ -516,15 +513,13 @@ export default function SettingsNavigator() {
           title: "QueuedDrawers (Auto force open)",
         }}
       />
-      {isLargeMoverFeatureEnabled && (
-        <Stack.Screen
-          name={ScreenName.LargeMoverLandingPage}
-          component={LargeMoverLandingPage}
-          options={{
-            headerShown: false,
-          }}
-        />
-      )}
+      <Stack.Screen
+        name={ScreenName.LargeMoverLandingPage}
+        component={LargeMoverLandingPage}
+        options={{
+          headerShown: false,
+        }}
+      />
       <Stack.Screen
         name={ScreenName.DebugSwipe}
         component={SwiperScreenDebug}

apps/ledger-live-mobile/src/screens/Settings/Debug/Features/index.tsx

@@ -117,14 +117,13 @@ export default function Features() {
         onPress={() => navigation.navigate(ScreenName.DebugTransactionsAlerts)}
       />
 
-      <FeatureToggle featureId="largemoverLandingpage">
-        <SettingsRow
-          title="Large Mover"
-          desc="See the large mover landing page"
-          iconLeft={<Icons.Dollar />}
-          onPress={navigateToLargeMover}
-        />
-      </FeatureToggle>
+      <SettingsRow
+        title="Large Mover"
+        desc="See the large mover landing page"
+        iconLeft={<Icons.Dollar />}
+        onPress={navigateToLargeMover}
+      />
+
       <SettingsRow
         title="Swiper"
         desc="Swipe cards"

libs/ledger-live-common/src/featureFlags/defaultFeatures.ts

@@ -650,7 +650,6 @@ export const DEFAULT_FEATURES: Features = {
   },
   llmThai: DEFAULT_FEATURE,
   lldThai: DEFAULT_FEATURE,
-  largemoverLandingpage: DEFAULT_FEATURE,
   llmMmkvMigration: {
     ...DEFAULT_FEATURE,
     params: {

libs/ledgerjs/packages/types-live/src/feature.ts

@@ -242,7 +242,6 @@ export type Features = CurrencyFeatures & {
   llmNanoSUpsellBanners: Feature_LlmNanoSUpsellBanners;
   llmThai: DefaultFeature;
   lldThai: DefaultFeature;
-  largemoverLandingpage: DefaultFeature;
   llmMmkvMigration: Feature_LlmMmkvMigration;
   lldModularDrawer: Feature_ModularDrawer;
   llmModularDrawer: Feature_ModularDrawer;