dev: code review ListAudioDevice

Author: Demonese

LuaSTG/LuaSTG/LuaBinding/LW_Audio.cpp

@@ -11,24 +11,23 @@ void luastg::binding::Audio::Register(lua_State* L)noexcept
 {
 	struct Wrapper
 	{
-		static int ListAudioDevice(lua_State* L)
+		static int ListAudioDevice(lua_State* vm)
 		{
+			lua::stack_t const ctx(vm);
 			auto const audio_engine = LAPP.getAudioEngine();
 			if (!audio_engine)
 			{
-				return luaL_error(L, "engine not initialized");
+				return luaL_error(vm, "engine not initialized");
 			}
-			lua::stack_t S(L);
-			auto const refresh = S.get_value<bool>(1);
-			if (refresh) {
-				audio_engine->refreshAudioEndpoint();
+			if (auto const refresh = ctx.get_value<bool>(1); refresh) {
+				std::ignore = audio_engine->refreshAudioEndpoint();
 			}
 			uint32_t const count = audio_engine->getAudioEndpointCount();
-			S.create_array(count);
+			auto const names = ctx.create_array(count);
 			for (uint32_t i = 0; i < count; i += 1)
 			{
 				auto const name = audio_engine->getAudioEndpointName(i);
-				S.set_array_value_zero_base<std::string_view>(i, name);
+				ctx.set_array_value_zero_base<std::string_view>(names, i, name);
 			}
 			return 1;
 		}

engine/lua/lua/plus.hpp

@@ -163,6 +163,13 @@ namespace lua {
 		template<>
 		inline void set_array_value_zero_base(size_t c_index, std::string_view value) { lua_pushlstring(L, value.data(), value.size()); lua_rawseti(L, -2, static_cast<int>(c_index + 1)); }
 
+		template<typename T>
+		void set_array_value_zero_base(stack_index_t const array_index, stack_index_t const index, T const& value) const {
+			lua_pushinteger(L, index.value + 1);
+			push_value(value);
+			lua_settable(L, array_index.value);
+		}
+
 		template<typename T>
 		inline void set_array_value(stack_index_t index, T value) { typename T::__invalid_type__ _{}; }