Skip to content

Commit 06fb299

Browse files
committed
Fix sky rotation direction
1 parent ad3ecc6 commit 06fb299

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

src/main/java/btw/lowercase/optiboxes/skybox/OptiFineCustomSkybox.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -106,18 +106,15 @@ public void renderSky(SkyRenderer skyRenderer, PoseStack poseStack, float tickDe
106106
RenderSystem.blendFuncSeparate(GlStateManager.SourceFactor.SRC_ALPHA, GlStateManager.DestFactor.ONE, GlStateManager.SourceFactor.ONE, GlStateManager.DestFactor.ZERO);
107107
poseStack.pushPose();
108108
RenderSystem.setShaderColor(1.0F, 1.0F, 1.0F, rainLevel);
109-
poseStack.mulPose(Axis.YP.rotationDegrees(-90.0F));
110109
this.render(poseStack, tickDelta);
111-
poseStack.mulPose(Axis.XP.rotationDegrees(timeOfDay * 360.0F)); // TODO/NOTE: Might not be needed?
112110
poseStack.popPose();
113-
}
114111

115-
skyRenderer.renderSunMoonAndStars(poseStack, bufferSource, timeOfDay, this.level.getMoonPhase(), rainLevel, starBrightness, fogParameters);
116-
bufferSource.endBatch();
112+
skyRenderer.renderSunMoonAndStars(poseStack, bufferSource, timeOfDay, this.level.getMoonPhase(), rainLevel, starBrightness, fogParameters);
113+
bufferSource.endBatch();
117114

118-
// Undoing this because of the OptiFine Sky Rendering Code Prior
119-
RenderSystem.disableBlend();
120-
RenderSystem.defaultBlendFunc();
115+
RenderSystem.disableBlend();
116+
RenderSystem.defaultBlendFunc();
117+
}
121118

122119
// Dark Disc
123120
if (this.shouldRenderDarkDisc(minecraft, tickDelta)) {

src/main/java/btw/lowercase/optiboxes/skybox/OptiFineSkyLayer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public void render(Level level, PoseStack poseStack, int timeOfDay, float skyAng
8888
this.blend.apply(finalAlpha);
8989
poseStack.pushPose();
9090
if (this.rotate) {
91-
float angle = getAngle(level, skyAngle);
91+
float angle = this.getAngle(level, skyAngle);
9292
Quaternionf rotation = new Quaternionf();
9393
rotation.rotationAxis(angle, this.axis);
9494
poseStack.mulPose(rotation);
@@ -142,7 +142,7 @@ private float getAngle(Level level, float skyAngle) {
142142
angleDayStart = (float) (currentAngle % 1.0D);
143143
}
144144

145-
return (-360.0F * (angleDayStart + skyAngle * this.speed)) * (float) Math.PI / 180.0F;
145+
return (360.0F * (angleDayStart + skyAngle * this.speed)) * (float) Math.PI / 180.0F;
146146
}
147147

148148
private boolean getConditionCheck(Level level) {

0 commit comments

Comments
 (0)