Refactor delete methods to return full JSON responses instead of boolean values; update docstrings for clarity.

Author: LegendEvent

darktrace/dt_tags.py

@@ -65,25 +65,23 @@ def create(self, name: str, color: Optional[int] = None, description: Optional[s
         response.raise_for_status()
         return response.json()
 
-    def delete(self, tag_id: str):
+    def delete(self, tag_id: str) -> dict:
         """
         Delete a tag by tag ID (tid).
 
         Args:
             tag_id (str): Tag ID (tid) to delete (e.g., /tags/5).
 
         Returns:
-            bool: True if deletion was successful, False otherwise.
+            dict: The response from the Darktrace API.
         """
         endpoint = f'/tags/{tag_id}'
         url = f"{self.client.host}{endpoint}"
         headers, _ = self._get_headers(endpoint)
         self.client._debug(f"DELETE {url}")
         response = requests.delete(url, headers=headers, verify=False)
-        if response.status_code == 200:
-            return True
         response.raise_for_status()
-        return False
+        return response.json()
 
 
     #TAGS/ENTITIES ENDPOINT   
@@ -141,7 +139,7 @@ def post_entities(self, did: int, tag: str, duration: Optional[int] = None):
         response.raise_for_status()
         return response.json()
 
-    def delete_entities(self, did: int, tag: str):
+    def delete_entities(self, did: int, tag: str) -> dict:
         """
         Remove a tag from a device via /tags/entities (DELETE).
 
@@ -150,18 +148,16 @@ def delete_entities(self, did: int, tag: str):
             tag (str): Name of the tag to remove.
 
         Returns:
-            bool: True if deletion was successful, False otherwise.
+            dict: The response from the Darktrace API.
         """
         endpoint = '/tags/entities'
         url = f"{self.client.host}{endpoint}"
         params = {'did': did, 'tag': tag}
         headers, sorted_params = self._get_headers(endpoint, params)
         self.client._debug(f"DELETE {url} params={sorted_params}")
         response = requests.delete(url, headers=headers, params=sorted_params, verify=False)
-        if response.status_code == 200:
-            return True
         response.raise_for_status()
-        return False
+        return response.json()
 
         # /tags/[tid]/entities ENDPOINT
     def get_tag_entities(self, tid: int, responsedata: Optional[str] = None, fulldevicedetails: Optional[bool] = None):
@@ -213,7 +209,7 @@ def post_tag_entities(self, tid: int, entityType: str, entityValue, expiryDurati
         response.raise_for_status()
         return response.json()
 
-    def delete_tag_entity(self, tid: int, teid: int):
+    def delete_tag_entity(self, tid: int, teid: int) -> dict:
         """
         Remove a tag from an entity via /tags/[tid]/entities/[teid] (DELETE).
 
@@ -222,14 +218,12 @@ def delete_tag_entity(self, tid: int, teid: int):
             teid (int): Tag entity ID (teid) representing the tag-to-entity relationship.
 
         Returns:
-            bool: True if deletion was successful, False otherwise.
+            dict: The response from the Darktrace API.
         """
         endpoint = f"/tags/{tid}/entities/{teid}"
         url = f"{self.client.host}{endpoint}"
         headers, _ = self._get_headers(endpoint)
         self.client._debug(f"DELETE {url}")
         response = requests.delete(url, headers=headers, verify=False)
-        if response.status_code == 200:
-            return True
         response.raise_for_status()
-        return False
+        return response.json()