Skip to content

Commit 02d9d49

Browse files
a-santamariaAlfredo Santamaria Gomez
authored andcommitted
add useTempDataDisk, remove dataDiskSizeGB from required and add examples (Azure#16704)
Co-authored-by: Alfredo Santamaria Gomez <[email protected]>
1 parent 1531e52 commit 02d9d49

File tree

3 files changed

+132
-4
lines changed

3 files changed

+132
-4
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
1+
{
2+
"parameters": {
3+
"subscriptionId": "00000000-0000-0000-0000-000000000000",
4+
"resourceGroupName": "resRg",
5+
"clusterName": "myCluster",
6+
"nodeTypeName": "BE",
7+
"api-version": "2021-11-01-preview",
8+
"parameters": {
9+
"properties": {
10+
"isPrimary": false,
11+
"vmSize": "Standard_DS3",
12+
"vmImagePublisher": "MicrosoftWindowsServer",
13+
"vmImageOffer": "WindowsServer",
14+
"vmImageSku": "2016-Datacenter-Server-Core",
15+
"vmImageVersion": "latest",
16+
"vmInstanceCount": 10,
17+
"enableEncryptionAtHost": true,
18+
"isStateless": true,
19+
"useTempDataDisk": true,
20+
"multiplePlacementGroups": true,
21+
"vmExtensions": [
22+
{
23+
"name": "Microsoft.Azure.Geneva.GenevaMonitoring",
24+
"properties": {
25+
"autoUpgradeMinorVersion": true,
26+
"publisher": "Microsoft.Azure.Geneva",
27+
"type": "GenevaMonitoring",
28+
"typeHandlerVersion": "2.0",
29+
"settings": {}
30+
}
31+
}
32+
]
33+
}
34+
}
35+
},
36+
"responses": {
37+
"202": {
38+
"headers": {
39+
"Location": "http://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ServiceFabric/locations/eastus/managedClusterOperationResults/1ca6e48d-70ca-4e43-b652-3b0522f64d67?api-version=2021-11-01-preview",
40+
"Azure-AsyncOperation": "http://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ServiceFabric/locations/eastus/managedClusterOperationStatus/1ca6e48d-70ca-4e43-b652-3b0522f64d67?api-version=2021-11-01-preview"
41+
},
42+
"body": {
43+
"type": "Microsoft.ServiceFabric/managedClusters/nodeTypes",
44+
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/resRg/providers/Microsoft.ServiceFabric/managedClusters/myCluster/nodeTypes/BE",
45+
"name": "BE",
46+
"tags": {},
47+
"properties": {
48+
"provisioningState": "Updating",
49+
"isPrimary": false,
50+
"vmSize": "Standard_DS3",
51+
"vmImagePublisher": "MicrosoftWindowsServer",
52+
"vmImageOffer": "WindowsServer",
53+
"vmImageSku": "2016-Datacenter-Server-Core",
54+
"vmImageVersion": "latest",
55+
"vmInstanceCount": 10,
56+
"enableEncryptionAtHost": true,
57+
"isStateless": true,
58+
"useTempDataDisk": true,
59+
"multiplePlacementGroups": true,
60+
"vmExtensions": [
61+
{
62+
"name": "Microsoft.Azure.Geneva.GenevaMonitoring",
63+
"properties": {
64+
"autoUpgradeMinorVersion": true,
65+
"publisher": "Microsoft.Azure.Geneva",
66+
"type": "GenevaMonitoring",
67+
"typeHandlerVersion": "2.0",
68+
"settings": {}
69+
}
70+
}
71+
]
72+
}
73+
}
74+
},
75+
"200": {
76+
"headers": {
77+
"Location": "http://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ServiceFabric/locations/eastus/managedClusterOperationResults/1ca6e48d-70ca-4e43-b652-3b0522f64d67?api-version=2021-11-01-preview",
78+
"Azure-AsyncOperation": "http://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ServiceFabric/locations/eastus/managedClusterOperationStatus/1ca6e48d-70ca-4e43-b652-3b0522f64d67?api-version=2021-11-01-preview"
79+
},
80+
"body": {
81+
"type": "Microsoft.ServiceFabric/managedClusters/nodeTypes",
82+
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/resRg/providers/Microsoft.ServiceFabric/managedClusters/myCluster/nodeTypes/BE",
83+
"name": "BE",
84+
"tags": {},
85+
"properties": {
86+
"provisioningState": "Creating",
87+
"isPrimary": false,
88+
"vmSize": "Standard_DS3",
89+
"vmImagePublisher": "MicrosoftWindowsServer",
90+
"vmImageOffer": "WindowsServer",
91+
"vmImageSku": "2016-Datacenter-Server-Core",
92+
"vmImageVersion": "latest",
93+
"vmInstanceCount": 10,
94+
"enableEncryptionAtHost": true,
95+
"isStateless": true,
96+
"useTempDataDisk": true,
97+
"multiplePlacementGroups": true,
98+
"vmExtensions": [
99+
{
100+
"name": "Microsoft.Azure.Geneva.GenevaMonitoring",
101+
"properties": {
102+
"autoUpgradeMinorVersion": true,
103+
"publisher": "Microsoft.Azure.Geneva",
104+
"type": "GenevaMonitoring",
105+
"typeHandlerVersion": "2.0",
106+
"settings": {}
107+
}
108+
}
109+
]
110+
}
111+
}
112+
}
113+
}
114+
}

specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2021-11-01-preview/examples/NodeTypePutOperation_example_max.json

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,15 @@
7272
"diskSizeGB": 150,
7373
"diskLetter": "G"
7474
}
75-
]
75+
],
76+
"enableAcceleratedNetworking": true,
77+
"frontendConfigurations": [
78+
{
79+
"loadBalancerBackendAddressPoolId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resRg/providers/Microsoft.Network/loadBalancers/test-LB/backendAddressPools/LoadBalancerBEAddressPool",
80+
"loadBalancerInboundNatPoolId": " /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resRg/providers/Microsoft.Network/loadBalancers/test-LB/inboundNatPools/LoadBalancerNATPool"
81+
}
82+
],
83+
"useDefaultPublicLoadBalancer": true
7684
}
7785
}
7886
},

specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2021-11-01-preview/nodetype.json

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -397,6 +397,9 @@
397397
},
398398
"Put a node type with auto-scale parameters": {
399399
"$ref": "./examples/NodeTypePutOperationAutoScale_example.json"
400+
},
401+
"Put an stateless node type with temporary disk for service fabric": {
402+
"$ref": "./examples/NodeTypePutOperationStateless_example.json"
400403
}
401404
},
402405
"x-ms-long-running-operation": true,
@@ -684,8 +687,7 @@
684687
"type": "object",
685688
"required": [
686689
"isPrimary",
687-
"vmInstanceCount",
688-
"dataDiskSizeGB"
690+
"vmInstanceCount"
689691
],
690692
"properties": {
691693
"isPrimary": {
@@ -702,7 +704,7 @@
702704
"dataDiskSizeGB": {
703705
"type": "integer",
704706
"format": "int32",
705-
"description": "Disk size for each vm in the node type in GBs."
707+
"description": "Disk size for the managed disk attached to the vms on the node type in GBs."
706708
},
707709
"dataDiskType": {
708710
"$ref": "#/definitions/DiskType",
@@ -825,6 +827,10 @@
825827
"useDefaultPublicLoadBalancer": {
826828
"type": "boolean",
827829
"description": "Specifies whether the use public load balancer. If not specified and the node type doesn't have its own frontend configuration, it will be attached to the default load balancer. If the node type uses its own Load balancer and useDefaultPublicLoadBalancer is true, then the frontend has to be an Internal Load Balancer. If the node type uses its own Load balancer and useDefaultPublicLoadBalancer is false or not set, then the custom load balancer must include a public load balancer to provide outbound connectivity."
830+
},
831+
"useTempDataDisk": {
832+
"type": "boolean",
833+
"description": "Specifies whether to use the temporary disk for the service fabric data root, in which case no managed data disk will be attached and the temporary disk will be used. It is only allowed for stateless node types."
828834
}
829835
},
830836
"description": "Describes a node type in the cluster, each node type represents sub set of nodes in the cluster."

0 commit comments

Comments
 (0)