Merge pull request #147 from Lemoncode/review-terraform

Review terraform

Author: JaimeSalas

05-iac/00-terraform/01-setup/readme.md

@@ -33,6 +33,41 @@ Para editar el `PATH`, seguiremos los siguientes pasos:
 3. Pulsar `edit` y modificarlo de forma adecuada
 4. Asegurar que hemos incluido `;` --> `c:\path;c:\path2`
 
+## Visual Studio Code Devconatiners
+
+Crear en el raíz del proyecto el directorio `.devcontainer`, dentro de este directorio añadimos el fichero `devcontainer.json`
+
+```json
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+// README at: https://github.com/devcontainers/templates/tree/main/src/ubuntu
+{
+	"name": "Ubuntu",
+	"image": "mcr.microsoft.com/devcontainers/base:jammy",
+	"features": {
+		"ghcr.io/devcontainers/features/aws-cli:1": {},
+		"ghcr.io/devcontainers/features/terraform:1": {}
+	}
+
+	// Features to add to the dev container. More info: https://containers.dev/features.
+	// "features": {},
+
+	// Use 'forwardPorts' to make a list of ports inside the container available locally.
+	// "forwardPorts": [],
+
+	// Use 'postCreateCommand' to run commands after the container is created.
+	// "postCreateCommand": "uname -a",
+
+	// Configure tool-specific properties.
+	// "customizations": {},
+
+	// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
+	// "remoteUser": "root"
+}
+
+```
+
+Ahora sólo tenemos que reabrir el directorio utilizando la opción de `Devcontainers` y tendremos el entorno preparado para trabajar con `Terraform` y `AWS`
+
 ## Referencias
 
 [Terraform Downloads](https://www.terraform.io/downloads)

05-iac/00-terraform/04-usando-inputs-outputs/02-demo.md

@@ -16,7 +16,7 @@ terraform apply "d1.tfplan"
 
 Crear `./lab/lc_web_app/variables.tf`.
 
-```tf
+```ini
 # variables.tf
 variable "aws_access_key" {
   type        = string
@@ -90,7 +90,7 @@ provider "aws" {
 
 Vamos a crear nuevas entradas en `variables.tf` para los recursos de Networking. 
 
-```tf
+```ini
 # ....
 # NETWORKING
 variable "vpc_cidr_block" {
@@ -183,7 +183,7 @@ resource "aws_route_table" "rtb" {
 
 Creamos nuevas entradas en `variables.tf` par los recusos de los SG
 
-```tf
+```ini
 # ....
 
 # SECURITY GROUPS
@@ -200,7 +200,7 @@ variable "sg_ingress_port" {
 }
 
 variable "sg_egress_cidr_blocks" {
-  type       map = list(string)
+  type        = list(string)
   description = "cidr blocks allow for egress"
   default     = ["0.0.0.0/0"]
 }

05-iac/00-terraform/04-usando-inputs-outputs/03-demo.md

@@ -16,7 +16,7 @@ terraform apply "d1.tfplan"
 
 Crear `./lab/lc_web_app/locals.tf`.
 
-```tf
+```ini
 locals {
   common_tags = {
 
@@ -31,7 +31,7 @@ Queremos añadir 3 valores, `company`, `project` y `billing_code`. Vamos a sacar
 
 Actualizamos `variables.tf`
 
-```tf
+```ini
 # ....
 # COMMON
 variable "company" {

05-iac/00-terraform/04-usando-inputs-outputs/04-demo.md

@@ -12,15 +12,15 @@ terraform apply "d1.tfplan"
 
 Creamos `./lab/lc_web_app/outputs.tf`
 
-```tf
+```ini
 output "aws_instance_public_dns" {
 
 }
 ```
 
 Para la entrada tomamos el valor expuesto por la instacia en `main.tf`
 
-```tf
+```ini
 resource "aws_instance" "nginx1" {
 ```
 

05-iac/00-terraform/05-incorporando-recursos/07-demo.md

@@ -70,7 +70,7 @@ EOF
 
 Actualizamos `loadbalancer.tf`
 
-```tf
+```ini
 ## aws_lb
 
 ## aws_lb_target_group

05-iac/00-terraform/06-incorporando-nuevos-providers/14-demo.md

@@ -19,7 +19,9 @@ Crear `lab/lc_web_app/s3.tf`
 ```tf
 # aws_s3_bucket
 
-# aws_s3_bucket_object
+# aws_s3_bucket_acl
+
+# aws_s3_bucket_policy
 
 # aws_iam_role