Merge pull request #167 from LeoHsiao1/dev

Dev

Author: LeoHsiao1

.github/workflows/build.yml

@@ -11,6 +11,11 @@ on:
       exiv2_version:
         default: 0.28.5
 
+env:
+  # When workflow is automatically triggered by a git push event, it does not set the default value of exiv2_version.
+  # So I have to set the default value again.
+  exiv2_version: ${{ inputs.exiv2_version || '0.28.5' }}
+
 jobs:
   on_linux:
     strategy:
@@ -23,9 +28,9 @@ jobs:
     runs-on: ${{ matrix.runner.os }}
     env:
       PLATFORM_NAME: ${{matrix.runner.exiv2_platform_name}}
-      EXIV2_URL: https://github.com/Exiv2/exiv2/releases/download/v${{inputs.exiv2_version}}
-      EXIV2_VERSION: ${{inputs.exiv2_version}}
-      EXIV2_BUILD_NAME: exiv2-${{inputs.exiv2_version}}-${{matrix.runner.exiv2_platform_name}}
+      EXIV2_URL: https://github.com/Exiv2/exiv2/releases/download/v${{env.exiv2_version}}
+      EXIV2_VERSION: ${{env.exiv2_version}}
+      EXIV2_BUILD_NAME: exiv2-${{env.exiv2_version}}-${{matrix.runner.exiv2_platform_name}}
       EXIV2_BUILD_EXT: .tar.gz
       PYTHON_VERSION: ${{matrix.python_version}}
     steps:
@@ -90,9 +95,9 @@ jobs:
     runs-on: ${{ matrix.runner.os }}
     env:
       PLATFORM_NAME: ${{matrix.runner.exiv2_platform_name}}
-      EXIV2_URL: https://github.com/Exiv2/exiv2/releases/download/v${{inputs.exiv2_version}}
-      EXIV2_VERSION: ${{inputs.exiv2_version}}
-      EXIV2_BUILD_NAME: exiv2-${{inputs.exiv2_version}}-${{matrix.runner.exiv2_platform_name}}
+      EXIV2_URL: https://github.com/Exiv2/exiv2/releases/download/v${{env.exiv2_version}}
+      EXIV2_VERSION: ${{env.exiv2_version}}
+      EXIV2_BUILD_NAME: exiv2-${{env.exiv2_version}}-${{matrix.runner.exiv2_platform_name}}
       EXIV2_BUILD_EXT: .tar.gz
       PYTHON_VERSION: ${{matrix.python_version}}
     steps:
@@ -157,9 +162,9 @@ jobs:
     runs-on: ${{ matrix.runner.os }}
     env:
       PLATFORM_NAME: ${{matrix.runner.exiv2_platform_name}}
-      EXIV2_URL: https://github.com/Exiv2/exiv2/releases/download/v${{inputs.exiv2_version}}
-      EXIV2_VERSION: ${{inputs.exiv2_version}}
-      EXIV2_BUILD_NAME: exiv2-${{inputs.exiv2_version}}-${{matrix.runner.exiv2_platform_name}}
+      EXIV2_URL: https://github.com/Exiv2/exiv2/releases/download/v${{env.exiv2_version}}
+      EXIV2_VERSION: ${{env.exiv2_version}}
+      EXIV2_BUILD_NAME: exiv2-${{env.exiv2_version}}-${{matrix.runner.exiv2_platform_name}}
       EXIV2_BUILD_EXT: .zip
       PYTHON_VERSION: ${{matrix.python_version}}
     steps:

.github/workflows/release.yml

@@ -6,11 +6,13 @@ on:
   workflow_dispatch:
     inputs:
       last_build_id:
-        description: Input the run id of workflows/build.yml, to download artifacts from it.
+        # description: Input the run id of workflows/build.yml, to download artifacts from it.
       upload_to_github:
         default: false
+        type: boolean
       # upload_to_pypi:
       #   default: false
+      #   type: boolean
 
 jobs:
   release:
@@ -92,7 +94,7 @@ jobs:
 
     - name: Upload wheels to GitHub
       uses: softprops/action-gh-release@v2
-      if: inputs.upload_to_github == 'true'
+      if: ${{ inputs.upload_to_github }}
       with:
         name: A draft for release
         draft: true
@@ -101,7 +103,7 @@ jobs:
           dist/*
 
     # - name: Upload wheels to PyPI
-    #   if: inputs.upload_to_pypi == 'true'
+    #   if: ${{ inputs.upload_to_pypi }}
     #   run: |
     #     python -m twine upload -u __token__ dist/*
     #     # Maybe the token should not be used, according to https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#configuring-trusted-publishing

.github/workflows/test_package.yml .github/workflows/test_wheels.yml.github/workflows/test_package.yml renamed to .github/workflows/test_wheels.yml

@@ -1,6 +1,6 @@
 # Test pyexiv2 wheel packages uploaded to pypi.org .
 
-name: Test package
+name: Test wheels
 
 on:
   # release: