Skip to content

Commit 115ff93

Browse files
authored
fix:#280 address ESlint errors for Select component (#614)
1 parent 6d7376f commit 115ff93

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

.eslintignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ components/MembersList/MembersList.tsx
4848
components/MultiSelect/multi-select-input.tsx
4949
components/Popover/popover.tsx
5050
components/ProfileCard/ProfileCard.tsx
51-
components/Select/select.tsx
5251
components/SnowOverlayWrapper/react-snow-overlay.d.ts
5352
lib/supabase/middleware.ts
5453
lib/utils.ts

components/Select/Select.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import {
1616
} from '@/components/Select';
1717

1818
describe('Select', () => {
19-
it("renders provided children", () => {
19+
it('renders provided children', () => {
2020
render(
2121
<Select defaultValue="default-select-value">
2222
<SelectGroup>

components/Select/Select.tsx

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,29 @@
55

66
import * as SelectPrimitive from '@radix-ui/react-select';
77

8+
/**
9+
* Root component that contains all the parts of a select.
10+
* Manages the selection state and handles all the interactions.
11+
* @see {@link https://www.radix-ui.com/docs/primitives/components/select#root}
12+
*/
813
const Select = SelectPrimitive.Root;
914

15+
/**
16+
* Component used to group multiple items.
17+
* Use in conjunction with Select.Label to ensure good accessibility via automatic labelling.
18+
* @see {@link https://www.radix-ui.com/docs/primitives/components/select#group}
19+
*/
1020
const SelectGroup = SelectPrimitive.Group;
1121

22+
/**
23+
* Component that reflects the selected value.
24+
* Appears in the trigger when a value is selected.
25+
* By default the selected item's text will be rendered.
26+
* If you require more control, you can instead control the select and pass your own children.
27+
* It should not be styled to ensure correct positioning.
28+
* An optional placeholder prop is also available for when the select has no value.
29+
* @see {@link https://www.radix-ui.com/docs/primitives/components/select#value}
30+
*/
1231
const SelectValue = SelectPrimitive.Value;
1332

1433
export { Select, SelectGroup, SelectValue };

0 commit comments

Comments
 (0)