Refactor CreateSellerController to use GenerateUniqueShopKeyJob and update generateShopNameService for unique shop key generation

This commit modifies the CreateSellerController to dispatch a job for generating a unique shop key instead of generating it directly within the controller. Additionally, the generateShopNameService is refactored to ensure the generated shop key is unique by checking against existing shop keys in the database, enhancing the reliability of shop key creation.

Author: Level237

app/Http/Controllers/Seller/CreateSellerController.php

@@ -9,9 +9,9 @@
 use Illuminate\Support\Facades\Log;
 use App\Http\Controllers\Controller;
 use Illuminate\Support\Facades\Hash;
+use App\Jobs\GenerateUniqueShopKeyJob;
 use App\Http\Requests\NewSellerRequest;
 use Illuminate\Support\Facades\Storage;
-use App\Services\Shop\generateShopNameService;
 use App\Services\Auth\CreateAccountSyncService;
 
 class CreateSellerController extends Controller
@@ -47,7 +47,6 @@ public function create(Request $request){
         if( $seller->save()){
             $shop=new Shop;
             $shop->shop_name=$request->shop_name;
-            $shop->shop_key=(new generateShopNameService)->generateUniqueShopName($request->shop_name);
             $shop->shop_description=$request->shop_description;
             $shop->user_id=$seller->id;
             $shop->town_id=intval($request->town_id);
@@ -62,6 +61,7 @@ public function create(Request $request){
                 Log::info('PaymentProcessingJob: Payment complete',[
                     'cat'=>$request->categories
                 ]);
+                GenerateUniqueShopKeyJob::dispatch($shop->id);
                 //$urlShop=$this->getUrlSyncAccount();
                 //$accountId=(new CreateAccountSyncService())->createSyncAccount(
                 //$request->shop_name,

app/Jobs/GenerateUniqueShopKeyJob.php

@@ -0,0 +1,36 @@
+<?php
+
+namespace App\Jobs;
+
+use App\Models\Shop;
+use Illuminate\Bus\Queueable;
+use Illuminate\Queue\SerializesModels;
+use Illuminate\Queue\InteractsWithQueue;
+use Illuminate\Contracts\Queue\ShouldQueue;
+use Illuminate\Foundation\Bus\Dispatchable;
+use App\Services\Shop\generateShopNameService;
+
+class GenerateUniqueShopKeyJob implements ShouldQueue
+{
+    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
+
+    /**
+     * Create a new job instance.
+     */
+
+    protected $shopId;
+    public function __construct($shopId)
+    {
+        $this->shopId=$shopId;
+    }
+
+    /**
+     * Execute the job.
+     */
+    public function handle(): void
+    {
+        $shop=Shop::find($this->shopId);
+        $shop->shop_key=(new generateShopNameService)->generateUniqueShopName($shop->shop_name);
+        $shop->save();
+    }
+}

app/Services/Shop/generateShopNameService.php

@@ -1,21 +1,25 @@
 <?php
 
 namespace App\Services\Shop;
+
 use App\Models\Shop;
-class generateShopNameService{
 
-   function generateUniqueShopName(string $shopName) {
-        // Nettoyer et préparer le préfixe à partir du nom de la boutique
-        $prefix = strtolower($shopName); // Conversion en minuscules
-        $prefix = preg_replace('/[^a-z0-9]/', '', $prefix); // Supprime les caractères spéciaux
-        $prefix = substr($prefix, 0, 4); // Prend les 4 premiers caractères
-        $prefix .= '-'; // Ajoute le tiret
-        
-        // Générer une chaîne aléatoire de 5 caractères
-        $characters = 'abcdefghijklmnopqrstuvwxyz0123456789';
-        $randomString = substr(str_shuffle($characters), 0, 5);
-        
-        // Combiner le préfixe avec la chaîne aléatoire
-        return $prefix . $randomString;
+function generateUniqueShopName(string $shopName) {
+        $shopKey = '';
+        do {
+            // Nettoyer et préparer le préfixe à partir du nom de la boutique
+            $prefix = strtolower($shopName); // Conversion en minuscules
+            $prefix = preg_replace('/[^a-z0-9]/', '', $prefix); // Supprime les caractères spéciaux
+            $prefix = substr($prefix, 0, 4); // Prend les 4 premiers caractères
+            $prefix .= '-'; // Ajoute le tiret
+            
+            // Générer une chaîne aléatoire de 5 caractères
+            $characters = 'abcdefghijklmnopqrstuvwxyz0123456789';
+            $randomString = substr(str_shuffle($characters), 0, 5);
+            
+            // Combiner le préfixe avec la chaîne aléatoire
+            $shopKey = $prefix . $randomString;
+        } while (Shop::where('shop_key', $shopKey)->exists());
+
+        return $shopKey;
     }
-}