v 1.3

Add new feature - Delete old backups. User can select for how many days backups will be stored.
Setting name: "TimeInDaysToHoldBackups" in appsettings.json file.
Officially fix windows version for making backups for postgresql. The problem was not creating backup on complex password. Now application is storing auth in .pgpass or pgpass.conf files (depends on platform). Also clears this file after job t not store these data anymore.

Author: Lewan24

DbBackupService/Core/Entities/Databases/MySqlDatabase.cs

@@ -25,20 +25,11 @@ public async Task PerformBackup()
 
         try
         {
-            if (string.IsNullOrWhiteSpace(_databaseConfig.DbName))
-                throw new ArgumentNullException(nameof(_databaseConfig.DbName));
+            var backupPaths = PrepareBackupDirectories.CheckDbNameAndPrepareBackupPaths(_databaseConfig, _appConfig);
+            var combinedBackupPathBackupFile = await PrepareBackupDirectories.PrepareNeededDirectoryAndClean(backupPaths, _appConfig, _logger);
 
             var connectionString = PrepareDatabaseBackupStrings.PrepareConnectionString(_databaseConfig);
-            var backupPaths = PrepareDatabaseBackupStrings.PrepareBackupPaths(_databaseConfig, _appConfig);
-
-            if (!Directory.Exists(backupPaths.DatabaseBackupPath))
-                Directory.CreateDirectory(backupPaths.DatabaseBackupPath);
-
-            var combinedBackupPathBackupFile = Path.Combine(backupPaths.DatabaseBackupPath, backupPaths.BackupFileName);
-
-            if (File.Exists(combinedBackupPathBackupFile))
-                File.Delete(combinedBackupPathBackupFile);
-
+            
             await using var connection = new MySqlConnection(connectionString);
             await using var cmd = new MySqlCommand();
             using var backup = new MySqlBackup(cmd);

DbBackupService/Core/Entities/Databases/PostgreSqlDatabase.cs

@@ -25,18 +25,8 @@ public async Task PerformBackup()
 
         try
         {
-            if (string.IsNullOrWhiteSpace(_databaseConfig.DbName))
-                throw new ArgumentNullException(nameof(_databaseConfig.DbName));
-
-            var backupPaths = PrepareDatabaseBackupStrings.PrepareBackupPaths(_databaseConfig, _appConfig);
-
-            if (!Directory.Exists(backupPaths.DatabaseBackupPath))
-                Directory.CreateDirectory(backupPaths.DatabaseBackupPath);
-
-            var combinedBackupPathBackupFile = Path.Combine(backupPaths.DatabaseBackupPath, backupPaths.BackupFileName);
-
-            if (File.Exists(combinedBackupPathBackupFile))
-                File.Delete(combinedBackupPathBackupFile);
+            var backupPaths = PrepareBackupDirectories.CheckDbNameAndPrepareBackupPaths(_databaseConfig, _appConfig);
+            var combinedBackupPathBackupFile = await PrepareBackupDirectories.PrepareNeededDirectoryAndClean(backupPaths, _appConfig, _logger);
 
 			var server = _databaseConfig.DbServerAndPort!.Split(':');
 

DbBackupService/Core/Entities/Models/ApplicationConfigurationModel.cs

@@ -5,4 +5,5 @@ public class ApplicationConfigurationModel
     public string? LogsFileName { get; set; } = string.Empty;
     public string? BackupSaveDirectory { get; set; } = string.Empty;
     public bool IncludeDateOfCreateLogFile { get; set; } = false;
+    public int TimeInDaysToHoldBackups { get; set; } = 2;
 }

DbBackupService/Core/StaticClassess/DeleteOldBackup.cs

@@ -0,0 +1,41 @@
+using System.Globalization;
+using System.Text.RegularExpressions;
+using NLog;
+
+namespace Core.StaticClassess;
+
+public static class DeleteOldBackup
+{
+    public static Task Delete(string directoryPath, int daysThreshold, Logger logger)
+    {
+        try
+        {
+            var zipFiles = Directory.GetFiles(directoryPath, "*.zip");
+
+            var currentDate = DateTime.Now;
+
+            foreach (var zipFile in zipFiles)
+            {
+                var fileName = Path.GetFileNameWithoutExtension(zipFile);
+                var match = Regex.Match(fileName, @"\d{2}\.\d{2}\.\d{2}_\d{2}\.\d{2}");
+
+                if (!match.Success) continue;
+                if (!DateTime.TryParseExact(match.Value, "dd.MM.yy_HH.mm", null, DateTimeStyles.None,
+                        out var backupDateTime)) continue;
+                var difference = currentDate - backupDateTime;
+
+                if (!(difference.TotalDays > daysThreshold)) continue;
+
+                File.Delete(zipFile);
+                logger.Info($"Deleted old backup: {Path.GetFileName(zipFile)}");
+            }
+            
+            return Task.CompletedTask;
+        }
+        catch (Exception e)
+        {
+            logger.Warn(e, "Error thrown while deleting old backups");
+            return Task.CompletedTask;
+        }
+    }
+}

DbBackupService/Core/StaticClassess/PrepareBackupDirectories.cs

@@ -0,0 +1,32 @@
+using Core.Entities.Models;
+using NLog;
+
+namespace Core.StaticClassess;
+
+public static class PrepareBackupDirectories
+{
+    public static (string DatabaseBackupPath, string BackupFileName) CheckDbNameAndPrepareBackupPaths(DatabaseConfigModel databaseConfig, ApplicationConfigurationModel appConfig)
+    {
+        if (string.IsNullOrWhiteSpace(databaseConfig.DbName))
+            throw new ArgumentNullException(nameof(databaseConfig.DbName));
+
+        var backupPaths = PrepareDatabaseBackupStrings.PrepareBackupPaths(databaseConfig, appConfig);
+        return backupPaths;
+    }
+
+    public static async Task<string> PrepareNeededDirectoryAndClean((string DatabaseBackupPath, string BackupFileName) backupPaths, ApplicationConfigurationModel appConfig, Logger logger)
+    {
+        if (!Directory.Exists(backupPaths.DatabaseBackupPath))
+            Directory.CreateDirectory(backupPaths.DatabaseBackupPath);
+
+        logger.Info("Deleting old backups...");
+        await DeleteOldBackup.Delete(backupPaths.DatabaseBackupPath, appConfig.TimeInDaysToHoldBackups, logger);
+            
+        var combinedBackupPathBackupFile = Path.Combine(backupPaths.DatabaseBackupPath, backupPaths.BackupFileName);
+
+        if (File.Exists(combinedBackupPathBackupFile))
+            File.Delete(combinedBackupPathBackupFile);
+
+        return combinedBackupPathBackupFile;
+    }
+}

DbBackupService/Presentation/Presentation.csproj

@@ -30,6 +30,12 @@
       <None Update="Src\Media\appicon.ico">
         <CopyToOutputDirectory>Always</CopyToOutputDirectory>
       </None>
+      <None Update="Src\ConfigurationFiles\appsettings.json">
+        <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+      </None>
+      <None Update="Src\ConfigurationFiles\databasesConfigurations.json">
+        <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+      </None>
     </ItemGroup>
 
 </Project>

DbBackupService/Presentation/Src/ConfigurationFiles/appsettings.json

@@ -2,7 +2,8 @@
   "AppConfiguration": {
     "LogsFileName": "Logs.txt",
     "BackupSaveDirectory": "C:\\Backups",
-    "IncludeDateOfCreateLogFile": true
+    "IncludeDateOfCreateLogFile": true,
+    "TimeInDaysToHoldBackups": 2
   },
   "EmailProviderConfiguration": {
     "ProviderSettings": {