Skip to content

Commit aa0fd47

Browse files
committed
[check][aggregate] fix unified results' failed count
When running `make -C check stats`, the unified results' failed count was always `0`. This was due to the absence of colors when printing to a file (commit 2186cb1). This fixes it by changing the order of conditions and the expected end of line for failure lines.
1 parent ed099dc commit aa0fd47

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

check/src/aggregate.ml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -62,21 +62,21 @@ let update state line =
6262
StringSet.add line set
6363
in
6464
let state =
65-
let end_of_fp = "Should not be detected" ^ PP.style_reset in
66-
let end_of_fn = "Not detected" ^ PP.style_reset in
67-
if String.starts_with ~prefix:(Filename.concat "." "examples") line then
68-
let unique_success_lines =
69-
add_unique_line state.State.unique_success_lines
70-
in
71-
{state with unique_success_lines}
72-
else if
65+
let end_of_fp = "Should not be detected" in
66+
let end_of_fn = "Not detected" in
67+
if
7368
String.ends_with ~suffix:end_of_fp line
7469
|| String.ends_with ~suffix:end_of_fn line
7570
then
7671
let unique_failure_lines =
7772
add_unique_line state.State.unique_failure_lines
7873
in
7974
{state with unique_failure_lines}
75+
else if String.starts_with ~prefix:(Filename.concat "." "examples") line then
76+
let unique_success_lines =
77+
add_unique_line state.State.unique_success_lines
78+
in
79+
{state with unique_success_lines}
8080
else state
8181
in
8282
let get ~default extract_from =

0 commit comments

Comments
 (0)