[src][input][3/n] store uid's loc for values

Using information available in the `.cmt`, store locations of uids
coming from `include`s in a new state field :
`state.signature.uid_to_loc`. Using `.cmt` and `.cmti`, store locations
of values' (and patterns in value bindings) uids at the same location
for easier lookup.
This is done as soon as the files are loaded, before the analysis.

The new table tries to be semantically equivalent to the usage of
`cmt_value_dependencies` instead of `cmt_declaration_dependencies`
before OCaml 5.3.

This fixes the FP and FN introduced when moving to OCaml 5.3.

Author: fantazio

check/classic/classic.ref

@@ -42,8 +42,7 @@
 
 ./examples/using_make/advanced/inc_val.mli:1: x
 ./examples/using_make/advanced/inc_val.mli:2: y
-./examples/using_make/advanced/val.mli:1: x: Should not be detected
-./examples/using_make/advanced/val.mli:2: y: Should not be detected
+
 ./examples/using_make/bar.ml:1: x
 ./examples/using_make/bar_fn.ml:3: h
 ./examples/using_make/baz.mli:1: z
@@ -109,29 +108,31 @@ Nothing else to report in this section
 ./examples/using_dune/unwrapped_lib/obj/with_class.mli:25: fun_class#unused
 ./examples/using_dune/unwrapped_lib/obj/with_class.mli:35: _self_used#unused
 ./examples/using_dune/unwrapped_lib/obj/with_class.mli:41: _self_used_fun_class#unused
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:1: immediate#unused_fun: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:1: immediate#unused_int: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:11: factory#unused_fun: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:11: factory#unused_int: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_fun: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_int: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_fun: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_int: Not detected
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:1: immediate#unused_fun
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:1: immediate#unused_int
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:11: factory#unused_fun
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:11: factory#unused_int
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_fun
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_int
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_fun
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_int
+
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:1: unused#unused
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:5: basics#never_used_fun
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:5: basics#never_used_int
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:23: unused_fun_class#unused
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:25: fun_class#unused
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:35: _self_used#unused
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:41: _self_used_fun_class#unused
-./examples/using_dune/wrapped_lib/obj/without_class.mli:1: immediate#unused_fun: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:1: immediate#unused_int: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:11: factory#unused_fun: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:11: factory#unused_int: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_fun: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_int: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_fun: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_int: Not detected
+./examples/using_dune/wrapped_lib/obj/without_class.mli:1: immediate#unused_fun
+./examples/using_dune/wrapped_lib/obj/without_class.mli:1: immediate#unused_int
+./examples/using_dune/wrapped_lib/obj/without_class.mli:11: factory#unused_fun
+./examples/using_dune/wrapped_lib/obj/without_class.mli:11: factory#unused_int
+./examples/using_dune/wrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_fun
+./examples/using_dune/wrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_int
+./examples/using_dune/wrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_fun
+./examples/using_dune/wrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_int
+
 ./examples/using_make/obj/class.mli:1: c#h
 ./examples/using_make/obj/class_type.mli:9: c#h
 ./examples/using_make/obj/coerce.mli:6: p#f
@@ -347,8 +348,6 @@ Nothing else to report in this section
 ./examples/using_make/if_end.ml:5: ?b
 ./examples/using_make/letIn.mli:1: ?a
 ./examples/using_make/let_in.ml:1: ?a
-./examples/using_make/opt/sig_struct.ml:6: ?x: Should not be detected
-./examples/using_make/opt/sig_struct.ml:11: ?x: Should not be detected
 ./examples/using_make/opt_in_opt.ml:1: ?a
 ./examples/using_make/opt_in_opt.ml:5: ?a
 ./examples/using_make/partial_opt.ml:1: ?a
@@ -455,7 +454,6 @@ Nothing else to report in this section
 ./examples/using_make/foo.ml:1: ?a
 ./examples/using_make/letIn.mli:1: ?b
 ./examples/using_make/let_in.ml:1: ?c
-./examples/using_make/opt/sig_struct.ml:2: ?x: Should not be detected
 ./examples/using_make/opt_in_opt.ml:2: ?a
 ./examples/using_make/opt_in_opt.ml:2: ?b
 ./examples/using_make/record.ml:12: ?b
@@ -502,7 +500,7 @@ Nothing else to report in this section
 --------------------------------------------------------------------------------
 
 
-Total: 438
-Success: 417
-Failed: 21
-Ratio: 95.2054794521%
+Total: 433
+Success: 433
+Failed: 0
+Ratio: 100.%

check/internal/internal.ref

@@ -1,43 +1,25 @@
 .> UNUSED EXPORTED VALUES:
 =========================
 ./examples/using_dune/unwrapped_lib/opt_args/opt_args.mli:1: unused_fun_with_single_never_used_opt_arg
-./examples/using_dune/unwrapped_lib/opt_args/opt_args.mli:8: internally_used_fun_with_single_never_used_opt_arg: Should not be detected
-./examples/using_dune/unwrapped_lib/opt_args/opt_args.mli:10: internally_used_fun_with_single_always_used_opt_arg: Should not be detected
-./examples/using_dune/unwrapped_lib/opt_args/opt_args.mli:12: internally_used_fun_with_single_sometimes_used_opt_arg: Should not be detected
+
 ./examples/using_dune/unwrapped_lib/values/values.mli:2: unused_int
-./examples/using_dune/unwrapped_lib/values/values.mli:14: unused_fun: Not detected
-./examples/using_dune/unwrapped_lib/values/values.mli:20: unused_alias_fun: Not detected
-./examples/using_dune/unwrapped_lib/values/values.mli:25: unused_closure: Not detected
-./examples/using_dune/unwrapped_lib/values/values.mli:3: internally_used_int: Should not be detected
-./examples/using_dune/unwrapped_lib/values/values.mli:14: unused_fun: Should not be detected
-./examples/using_dune/unwrapped_lib/values/values.mli:15: internally_used_fun: Should not be detected
-./examples/using_dune/unwrapped_lib/values/values.mli:20: unused_alias_fun: Should not be detected
-./examples/using_dune/unwrapped_lib/values/values.mli:25: unused_closure: Should not be detected
-./examples/using_dune/unwrapped_lib/values/values.mli:26: internally_used_closure: Should not be detected
+./examples/using_dune/unwrapped_lib/values/values.mli:14: unused_fun
+./examples/using_dune/unwrapped_lib/values/values.mli:20: unused_alias_fun
+./examples/using_dune/unwrapped_lib/values/values.mli:25: unused_closure
 ./examples/using_dune/unwrapped_lib/values/values_in_submodules.mli:3: Exported.unused_int
-./examples/using_dune/unwrapped_lib/values/values_in_submodules.mli:4: Exported.internally_used_int: Should not be detected
 ./examples/using_dune/unwrapped_lib/values/values_in_submodules_no_intf.ml:3: Exported.unused_int
 ./examples/using_dune/unwrapped_lib/values/values_no_intf.ml:2: unused_int
 ./examples/using_dune/unwrapped_lib/values/values_no_intf.ml:13: unused_fun
 ./examples/using_dune/unwrapped_lib/values/values_no_intf.ml:20: unused_alias_fun
 ./examples/using_dune/unwrapped_lib/values/values_no_intf.ml:25: unused_closure
 
 ./examples/using_dune/wrapped_lib/opt_args/opt_args.mli:1: unused_fun_with_single_never_used_opt_arg
-./examples/using_dune/wrapped_lib/opt_args/opt_args.mli:8: internally_used_fun_with_single_never_used_opt_arg: Should not be detected
-./examples/using_dune/wrapped_lib/opt_args/opt_args.mli:10: internally_used_fun_with_single_always_used_opt_arg: Should not be detected
-./examples/using_dune/wrapped_lib/opt_args/opt_args.mli:12: internally_used_fun_with_single_sometimes_used_opt_arg: Should not be detected
+
 ./examples/using_dune/wrapped_lib/values/values.mli:2: unused_int
-./examples/using_dune/wrapped_lib/values/values.mli:14: unused_fun: Not detected
-./examples/using_dune/wrapped_lib/values/values.mli:20: unused_alias_fun: Not detected
-./examples/using_dune/wrapped_lib/values/values.mli:25: unused_closure: Not detected
-./examples/using_dune/wrapped_lib/values/values.mli:3: internally_used_int: Should not be detected
-./examples/using_dune/wrapped_lib/values/values.mli:14: unused_fun: Should not be detected
-./examples/using_dune/wrapped_lib/values/values.mli:15: internally_used_fun: Should not be detected
-./examples/using_dune/wrapped_lib/values/values.mli:20: unused_alias_fun: Should not be detected
-./examples/using_dune/wrapped_lib/values/values.mli:25: unused_closure: Should not be detected
-./examples/using_dune/wrapped_lib/values/values.mli:26: internally_used_closure: Should not be detected
+./examples/using_dune/wrapped_lib/values/values.mli:14: unused_fun
+./examples/using_dune/wrapped_lib/values/values.mli:20: unused_alias_fun
+./examples/using_dune/wrapped_lib/values/values.mli:25: unused_closure
 ./examples/using_dune/wrapped_lib/values/values_in_submodules.mli:3: Exported.unused_int
-./examples/using_dune/wrapped_lib/values/values_in_submodules.mli:4: Exported.internally_used_int: Should not be detected
 ./examples/using_dune/wrapped_lib/values/values_in_submodules_no_intf.ml:3: Exported.unused_int
 ./examples/using_dune/wrapped_lib/values/values_no_intf.ml:2: unused_int
 ./examples/using_dune/wrapped_lib/values/values_no_intf.ml:13: unused_fun
@@ -46,8 +28,7 @@
 
 ./examples/using_make/advanced/inc_val.mli:1: x
 ./examples/using_make/advanced/inc_val.mli:2: y
-./examples/using_make/advanced/val.mli:1: x: Should not be detected
-./examples/using_make/advanced/val.mli:2: y: Should not be detected
+
 ./examples/using_make/bar.ml:1: x
 ./examples/using_make/bar_fn.ml:3: h
 ./examples/using_make/baz.mli:1: z
@@ -64,41 +45,25 @@
 ./examples/using_make/dir/anon_call2.ml:9: h
 ./examples/using_make/dir/match_opt.ml:8: l
 ./examples/using_make/dir/matchopt.ml:5: w
-./examples/using_make/dir/mod.mli:10: M.f: Should not be detected
 ./examples/using_make/dir/mod.mli:11: M.g
 ./examples/using_make/dir/refFn.mli:3: x
 ./examples/using_make/dir/ref_opt.ml:3: no
 ./examples/using_make/dir/ref_opt.ml:11: x
 
-./examples/using_make/exported.mli:11: F.times_five: Not detected
-./examples/using_make/exported.mli:17: M2.ten: Not detected
-./examples/using_make/exported.mli:6: M1.five: Should not be detected
-./examples/using_make/exported.mli:10: F.plus_five: Should not be detected
-./examples/using_make/exported.mli:11: F.times_five: Should not be detected
-./examples/using_make/exported.mli:15: M2.five: Should not be detected
-./examples/using_make/exported.mli:16: M2.plus_five: Should not be detected
-./examples/using_make/exported.mli:17: M2.ten: Should not be detected
+./examples/using_make/exported.mli:11: F.times_five
+./examples/using_make/exported.mli:17: M2.ten
 ./examples/using_make/foo.mli:2: y
 ./examples/using_make/fooFn.mli:2: g
-./examples/using_make/functor.mli:2: M.f: Should not be detected
 ./examples/using_make/functor.mli:3: M.none
-./examples/using_make/functor.mli:7: F.g: Should not be detected
-./examples/using_make/functor.mli:11: N.g: Should not be detected
 ./examples/using_make/let_in.ml:3: parent
 ./examples/using_make/let_test.ml:3: g
 ./examples/using_make/matchopt.ml:5: w
-./examples/using_make/mod_alias.mli:2: M1.id: Should not be detected
-./examples/using_make/mod_alias.mli:6: M2.id: Should not be detected
-./examples/using_make/obj/class.mli:7: o: Should not be detected
-./examples/using_make/obj/class.mli:9: f: Should not be detected
-./examples/using_make/obj/inher.mli:11: o: Should not be detected
-./examples/using_make/obj/inher.mli:13: f: Should not be detected
 ./examples/using_make/opt_in_opt.ml:7: x
 ./examples/using_make/qux.ml:1: z
 ./examples/using_make/unused_fn.ml:3: g
 ./examples/using_make/unused_fn.ml:5: var
 ./examples/using_make/useless_opt.ml:3: x
-./examples/using_make/variant.mli:5: f: Should not be detected
+
 Nothing else to report in this section
 --------------------------------------------------------------------------------
 
@@ -112,29 +77,31 @@ Nothing else to report in this section
 ./examples/using_dune/unwrapped_lib/obj/with_class.mli:25: fun_class#unused
 ./examples/using_dune/unwrapped_lib/obj/with_class.mli:35: _self_used#unused
 ./examples/using_dune/unwrapped_lib/obj/with_class.mli:41: _self_used_fun_class#unused
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:1: immediate#unused_fun: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:1: immediate#unused_int: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:11: factory#unused_fun: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:11: factory#unused_int: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_fun: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_int: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_fun: Not detected
-./examples/using_dune/unwrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_int: Not detected
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:1: immediate#unused_fun
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:1: immediate#unused_int
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:11: factory#unused_fun
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:11: factory#unused_int
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_fun
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_int
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_fun
+./examples/using_dune/unwrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_int
+
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:1: unused#unused
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:5: basics#never_used_fun
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:5: basics#never_used_int
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:23: unused_fun_class#unused
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:25: fun_class#unused
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:35: _self_used#unused
 ./examples/using_dune/wrapped_lib/obj/with_class.mli:41: _self_used_fun_class#unused
-./examples/using_dune/wrapped_lib/obj/without_class.mli:1: immediate#unused_fun: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:1: immediate#unused_int: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:11: factory#unused_fun: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:11: factory#unused_int: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_fun: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_int: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_fun: Not detected
-./examples/using_dune/wrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_int: Not detected
+./examples/using_dune/wrapped_lib/obj/without_class.mli:1: immediate#unused_fun
+./examples/using_dune/wrapped_lib/obj/without_class.mli:1: immediate#unused_int
+./examples/using_dune/wrapped_lib/obj/without_class.mli:11: factory#unused_fun
+./examples/using_dune/wrapped_lib/obj/without_class.mli:11: factory#unused_int
+./examples/using_dune/wrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_fun
+./examples/using_dune/wrapped_lib/obj/without_class.mli:22: _self_used_immediate#unused_int
+./examples/using_dune/wrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_fun
+./examples/using_dune/wrapped_lib/obj/without_class.mli:28: _self_used_factory#unused_int
+
 ./examples/using_make/obj/class.mli:1: c#h
 ./examples/using_make/obj/class_type.mli:9: c#h
 ./examples/using_make/obj/coerce.mli:6: p#f
@@ -350,8 +317,6 @@ Nothing else to report in this section
 ./examples/using_make/if_end.ml:5: ?b
 ./examples/using_make/letIn.mli:1: ?a
 ./examples/using_make/let_in.ml:1: ?a
-./examples/using_make/opt/sig_struct.ml:6: ?x: Should not be detected
-./examples/using_make/opt/sig_struct.ml:11: ?x: Should not be detected
 ./examples/using_make/opt_in_opt.ml:1: ?a
 ./examples/using_make/opt_in_opt.ml:5: ?a
 ./examples/using_make/partial_opt.ml:1: ?a
@@ -458,7 +423,6 @@ Nothing else to report in this section
 ./examples/using_make/foo.ml:1: ?a
 ./examples/using_make/letIn.mli:1: ?b
 ./examples/using_make/let_in.ml:1: ?c
-./examples/using_make/opt/sig_struct.ml:2: ?x: Should not be detected
 ./examples/using_make/opt_in_opt.ml:2: ?a
 ./examples/using_make/opt_in_opt.ml:2: ?b
 ./examples/using_make/record.ml:12: ?b
@@ -505,7 +469,7 @@ Nothing else to report in this section
 --------------------------------------------------------------------------------
 
 
-Total: 446
-Success: 380
-Failed: 66
-Ratio: 85.201793722%
+Total: 404
+Success: 404
+Failed: 0
+Ratio: 100.%