resolve issue #56, clean up server.js code

Author: keski

graphql-server/drivers/arangodb/driver.js

@@ -1,18 +1,21 @@
 const graphql = require('graphql');
 const arangojs = require("arangojs");
 const aql = arangojs.aql;
+const { makeExecutableSchema } = require('graphql-tools');
 const { ApolloError } = require('apollo-server');
 const waitOn = require('wait-on');
 
 let db;
 let disableEdgeValidation;
 
 module.exports = {
-    init: async function(schema){
-        let db_name = process.env.db ? process.env.db: 'dev-db';
-        let url = process.env.URL ? process.env.URL : 'http://localhost:8529';
-        let drop = process.env.DROP === 'true';
-        disableEdgeValidation = process.env.DISABLE_EDGE_VALIDATION === 'true';
+    init: async function(args){
+        let typeDefs = args.typeDefs;
+        let db_name = args.db_name || 'dev-db';
+        let url = args.url || 'http://localhost:8529';
+        let drop = args.drop || false;
+        disableEdgeValidation = args.disableEdgeValidation || false;
+
         db = new arangojs.Database({ url: url });
 
         // wait for ArangoDB
@@ -34,6 +37,11 @@ module.exports = {
                 () => console.log()
             );
         }
+        const schema = makeExecutableSchema({
+            'typeDefs': typeDefs,
+            'resolvers': {}
+        });
+
         await createAndUseDatabase(db, db_name);
         await createTypeCollections(db, schema);
         await createEdgeCollections(db, schema);
@@ -71,14 +79,9 @@ module.exports = {
     },
     getEdgeCollectionName: function(type, field){
         return getEdgeCollectionName(type, field);
-    },
-    hello: () => hello() // TODO: Remove after testing
+    }
 };
 
-async function hello(){
-    return "This is the arangodb.tools saying hello!"
-}
-
 async function createAndUseDatabase(db, db_name){
     await db.createDatabase(db_name).then(
         () => { console.info(`Database '${db_name}' created`); },
@@ -97,7 +100,7 @@ async function createTypeCollections(db, schema) {
         await collection.create().then(
             () => { console.info(`Collection '${collection_name}' created`) },
             err => {
-                //console.warn(`Collection '${collection_name}' not created:` , err.response.body.errorMessage);
+                console.warn(`Collection '${collection_name}' not created:` , err.response.body.errorMessage);
             }
         );
     }

graphql-server/server.js

@@ -1,35 +1,53 @@
 const { ApolloServer, gql } = require('apollo-server');
-const fs = require('fs');
+const { readFileSync } = require('fs');
 const driver = require('./driver.js');
 const graphqlResolvers = require('./resolvers.js');
 const graphqlCustomResolvers = require('./custom-resolvers.js');
 
-const text = fs.readFileSync('api-schema/api-schema.graphql', 'utf8');
-const textExtend = fs.readFileSync('api-schema/custom-api-schema.graphql', 'utf8');
-const typeDefs = gql`${text + textExtend}`;
-
 async function run(){
-    // setup resolvers
-    const resolvers = await graphqlResolvers.get({ driver: driver });
-    const customResolvers = await graphqlCustomResolvers.get({ driver: driver });
-    resolvers.Query = {...resolvers.Query, ...customResolvers.Query};
-
-    const server = new ApolloServer({typeDefs, resolvers: resolvers});
-    await driver.init(server.schema);
+    // parse API schema and extended schema
+    const baseSchema = readFileSync('api-schema/api-schema.graphql', 'utf8');
+    const customSchema = readFileSync('api-schema/custom-api-schema.graphql', 'utf8');
+    const typeDefs = gql`${baseSchema} ${customSchema}`;
 
-    if(process.env.DISABLE_LOGGING){
-        console.info = function() {};
+    // Enable/disable debugging
+    if(process.env.DEBUG !== 'true'){
+        console.debug = function() {};
     }
 
-    server.listen().then(({ url }) => {
-        console.log(`GraphQL service ready at: ${url}`);
+    // Driver options
+    // Use environment variables to customize settings when starting the server
+    let args = {
+        'typeDefs': gql`${baseSchema}`,
+        'db_name': process.env.DB_NAME || 'spirit-db',
+        'url': process.env.URL || 'http://localhost:8529',
+        'drop': process.env.DROP === 'true',
+        'disableEdgeValidation': process.env.DISABLE_EDGE_VALIDATION === 'true'
+    };
+    await driver.init(args);
+
+    // Load base resolvers
+    const resolvers = await graphqlResolvers.get({
+        driver: driver
+    });
+    // Load custom resolvers
+    // Configure the get-request below if your custom resolvers require additional options
+    const customResolvers = await graphqlCustomResolvers.get({
+        driver: driver
     });
-}
 
-function main(){
-    run().then(() => {
-        err => console.error(err);
+    // Create instance of server and start listening
+    const server = new ApolloServer({
+        'typeDefs': typeDefs,
+        'resolvers': [
+            resolvers,
+            customResolvers
+        ]
+    });
+    server.listen().then(({ url }) => {
+        console.log(`GraphQL service ready at: ${url}`);
     });
 }
 
-main();
+// Run server
+run().then(() => { err => console.error(err); });