Skip to content

Commit bf765d9

Browse files
committed
Refactoring.
1 parent b2bc19f commit bf765d9

File tree

5 files changed

+157
-125
lines changed

5 files changed

+157
-125
lines changed

samples/Unity.Mvvm.ToDoList/Assets/Scripts/BindableUIElements/BindablePageBlocker.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
using Cysharp.Threading.Tasks;
2-
using Extensions;
32
using UnityEngine;
43
using UnityEngine.UIElements;
54
using UnityMvvmToolkit.UI.BindableUIElements;
5+
using UnityMvvmToolkit.UniTask;
66

77
namespace BindableUIElements
88
{
@@ -20,13 +20,13 @@ public async UniTask ActivateAsync()
2020
{
2121
visible = true;
2222
style.opacity = 1;
23-
await this.WaitForTransitionFinish();
23+
await this.WaitForLongestTransition();
2424
}
2525

2626
public async UniTask DeactivateAsync()
2727
{
2828
style.opacity = 0;
29-
await this.WaitForTransitionFinish();
29+
await this.WaitForLongestTransition();
3030

3131
visible = false;
3232
}

samples/Unity.Mvvm.ToDoList/Assets/Scripts/Extensions/VisualElementExtensions.cs

Lines changed: 0 additions & 60 deletions
This file was deleted.

samples/Unity.Mvvm.ToDoList/Assets/Scripts/Extensions/VisualElementExtensions.cs.meta

Lines changed: 0 additions & 3 deletions
This file was deleted.

samples/Unity.Mvvm.ToDoList/Assets/Scripts/UIElements/MobileInputAdaptivePage.cs

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,15 @@
33
using System.Threading;
44
using Controllers;
55
using Cysharp.Threading.Tasks;
6-
using Extensions;
76
using UnityEngine;
87
using UnityEngine.UIElements;
8+
using UnityMvvmToolkit.UniTask;
99
using Utilities;
1010

1111
namespace UIElements
1212
{
1313
public class MobileInputAdaptivePage : VisualElement, IDisposable
1414
{
15-
private bool _isActivated;
1615
private float _parentHeight;
1716
private float _initialPaddingBottom;
1817
private float _defaultPaddingBottom;
@@ -31,13 +30,10 @@ public MobileInputAdaptivePage()
3130
}
3231

3332
public float OffsetFromKeyboardPx { get; set; }
34-
35-
public bool IsActivated => _isActivated;
33+
public bool IsActivated => _trackKeyboardActivityTask is { Task: { Status: UniTaskStatus.Pending } };
3634

3735
public async UniTask ActivateAsync()
3836
{
39-
_isActivated = true;
40-
4137
if (IsScreenKeyboardSupported())
4238
{
4339
ActivateKeyboardTrackingAsync().Forget();
@@ -47,13 +43,11 @@ public async UniTask ActivateAsync()
4743
SetOpacity(1);
4844
SetPaddingBottom(_defaultPaddingBottom);
4945

50-
await this.WaitForTransitionFinish();
46+
await this.WaitForLongestTransition();
5147
}
5248

5349
public async UniTask DeactivateAsync()
5450
{
55-
_isActivated = false;
56-
5751
if (IsScreenKeyboardSupported())
5852
{
5953
_inputDialog.HideScreenKeyboard();
@@ -63,7 +57,7 @@ public async UniTask DeactivateAsync()
6357
SetOpacity(0);
6458
SetPaddingBottom(_initialPaddingBottom);
6559

66-
await this.WaitForTransitionFinish();
60+
await this.WaitForLongestTransition();
6761

6862
SetVisible(false);
6963
}
@@ -107,7 +101,6 @@ private async UniTaskVoid ActivateKeyboardTrackingAsync()
107101

108102
private async UniTask TrackKeyboardActivityAsync()
109103
{
110-
_isActivated = true;
111104
_cancellationTokenSource = new CancellationTokenSource();
112105

113106
try
@@ -138,8 +131,6 @@ private async UniTask TrackKeyboardActivityAsync()
138131
finally
139132
{
140133
_cancellationTokenSource?.Dispose();
141-
142-
_isActivated = false;
143134
_cancellationTokenSource = null;
144135
}
145136
}

0 commit comments

Comments
 (0)