Skip to content

Commit e2d7994

Browse files
committed
Define constants for class names.
1 parent eea5202 commit e2d7994

File tree

2 files changed

+23
-11
lines changed

2 files changed

+23
-11
lines changed

samples/Unity.Mvvm.Counter/Assets/Scripts/UIElements/CounterSlider.cs

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,18 @@ namespace UIElements
55
{
66
public class CounterSlider : VisualElement
77
{
8+
private const string SliderClassName = "slider";
9+
private const string SliderLabelClassName = "slider__label";
10+
private const string SliderThumbClassName = "slider__thumb";
11+
private const string SliderThumbIconClassName = "slider__thumb__icon";
12+
private const string SliderThumbAnimationClassName = "slider__thumb--animation";
13+
814
private VisualElement _thumb;
915
private SliderManipulator _manipulator;
1016

1117
public CounterSlider()
1218
{
13-
AddToClassList("slider");
19+
AddToClassList(SliderClassName);
1420

1521
CreateLabel("LabelLeft", "−");
1622
CreateLabel("LabelRight", "+");
@@ -38,7 +44,7 @@ private void CreateLabel(string labelName, string labelText)
3844
label.text = labelText;
3945
label.name = labelName;
4046
label.pickingMode = PickingMode.Ignore;
41-
label.AddToClassList("slider__label");
47+
label.AddToClassList(SliderLabelClassName);
4248

4349
Add(label);
4450
}
@@ -47,13 +53,13 @@ private void CreateThumb()
4753
{
4854
_thumb = new VisualElement();
4955
_thumb.name = "Thumb";
50-
_thumb.AddToClassList("slider__thumb");
51-
_thumb.AddToClassList("slider__thumb--animation");
56+
_thumb.AddToClassList(SliderThumbClassName);
57+
_thumb.AddToClassList(SliderThumbAnimationClassName);
5258

5359
var thumbIcon = new VisualElement();
5460
thumbIcon.name = "Icon";
5561
thumbIcon.pickingMode = PickingMode.Ignore;
56-
thumbIcon.AddToClassList("slider__thumb__icon");
62+
thumbIcon.AddToClassList(SliderThumbIconClassName);
5763

5864
_thumb.Add(thumbIcon);
5965

samples/Unity.Mvvm.Counter/Assets/Scripts/UIElements/ThemeSwitcher.cs

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ namespace UIElements
55
{
66
public class ThemeSwitcher : VisualElement
77
{
8+
private const string ToggleSwitchClassName = "toggle-switch";
9+
private const string ToggleSwitchTrackClassName = "toggle-switch__track";
10+
private const string ToggleSwitchTrackThumbClassName = "toggle-switch__track__thumb";
11+
private const string ToggleSwitchLabelClassName = "toggle-switch__label";
12+
private const string ToggleSwitchLabelContainerClassName = "toggle-switch__label-container";
13+
814
private VisualElement _track;
915
private VisualElement _thumb;
1016

@@ -16,7 +22,7 @@ public class ThemeSwitcher : VisualElement
1622

1723
public ThemeSwitcher()
1824
{
19-
AddToClassList("toggle-switch");
25+
AddToClassList(ToggleSwitchClassName);
2026

2127
CreateLabelContainer("LeftContainer", "Light", "--left");
2228
CreateTrack();
@@ -44,13 +50,13 @@ private void CreateLabelContainer(string containerName, string labelText, string
4450
var labelContainer = new VisualElement();
4551
labelContainer.name = containerName;
4652
labelContainer.pickingMode = PickingMode.Ignore;
47-
labelContainer.AddToClassList("toggle-switch__label-container");
53+
labelContainer.AddToClassList(ToggleSwitchLabelContainerClassName);
4854

4955
var label = new Label();
5056
label.text = labelText;
5157
label.pickingMode = PickingMode.Ignore;
52-
label.AddToClassList("toggle-switch__label");
53-
label.AddToClassList($"toggle-switch__label{labelClassNameModifier}");
58+
label.AddToClassList(ToggleSwitchLabelClassName);
59+
label.AddToClassList($"{ToggleSwitchLabelClassName}{labelClassNameModifier}");
5460

5561
labelContainer.Add(label);
5662
Add(labelContainer);
@@ -60,12 +66,12 @@ private void CreateTrack()
6066
{
6167
_track = new VisualElement();
6268
_track.name = "Track";
63-
_track.AddToClassList("toggle-switch__track");
69+
_track.AddToClassList(ToggleSwitchTrackClassName);
6470

6571
_thumb = new VisualElement();
6672
_thumb.name = "Thumb";
6773
_thumb.pickingMode = PickingMode.Ignore;
68-
_thumb.AddToClassList("toggle-switch__track__thumb");
74+
_thumb.AddToClassList(ToggleSwitchTrackThumbClassName);
6975

7076
_track.Add(_thumb);
7177
Add(_track);

0 commit comments

Comments
 (0)