'reservation' -> 'default.start.reminder' and 'default.end.reminder' are ignored

[guilegatan]

[x]: This is a bug and not a question.

[x]: I understand that the best way to resolve this issue is to solve it and propose a Pull Request.

Describe the bug**

The two variables in 'reservation' => ['default.start.reminder'] and 'reservation' => ['default.end.reminder'] are ignored. You can set them to whatever you want, in the UI it always defaults to 15min.

To Reproduce**

Steps to reproduce the behavior:

1. enable reminders: 'reservation' => ['reminder.enabled'] => true;
2. set 'reservation' => ['default.start.reminder'] and 'reservation' => ['default.end.reminder'] to whatever you want.
3. check reservation UI (see screenshot)

Expected behavior**

'default.start.reminder' and 'default.end.reminder' overwrite the hardcoded default of 15min

Screenshots**

Additional context**

Problem is present since 2.8.x, so it seems it never worked at all.

here is the excerpt from my 4.1.0 config file (truncated to the reminder-part):

    'reservation' => [
        ##########################################
        # Reservation Reminder
        ##########################################

        # Enable reminder notifications for upcoming reservations (true/false)
        'reminders.enabled' => true,

        # Default reminder time before reservation start (in minutes)
        'default.start.reminder' => '60',

        # Default reminder time before reservation end (in minutes)
        'default.end.reminder' => '',
    ],

Specifications

• currently using LibreBooking 4.1.0, but as said, the problem is present since every version I tested.

[belcirelk]

Hi,

can you try '1 days' and let me know if it works. Just a number won't work but the documentation is not clear. It works for me.

[belcirelk]

I think all the following would work. If it works, let me know I will update the documentation.

Seconds: 1 second, 30 seconds

Minutes: 1 minute, 15 minutes

Hours: 1 hour, 4 hours

Days: 1 day, 5 days

Weeks: 1 week, 2 weeks

Months: 1 month, 6 months

Years: 1 year, 10 years

[guilegatan]

I think all the following would work. If it works, let me know I will update the documentation.

Seconds: 1 second, 30 seconds

Minutes: 1 minute, 15 minutes

Hours: 1 hour, 4 hours

Days: 1 day, 5 days

Weeks: 1 week, 2 weeks

Months: 1 month, 6 months

Years: 1 year, 10 years

Thank you, this works perfectly!
In this case only the description "# Default reminder time before reservation start (in minutes)" needs to be changed to something like "# Default reminder time before reservation start (format: NUMBER INCREMENT; i.e. 1 minute, 5 minutes, 1 hour, 2 days, 2 months, etc.)"

[guilegatan]

One more thing:
If I change the setting to i.e. "24 hours", the checkbox is automatically enabled.
Is it possible, to just change the default value from 15min to some custom value, but keep the checkbox disabled?

I also tested to change 'reminders.enabled' => true to false, but then the complete reminder-function is disabled (and no reminders are sent).

[belcirelk]

Thanks!

Right now the is no option, it's checked by default if you have a valid value.

[guilegatan]

Ok, thanks for the explanation!