Cleanups for #1195

- Added Test for changed Method
- Added localization for exception message

Author: asturio

openpdf/src/main/java/com/lowagie/text/pdf/PdfPTable.java

@@ -658,7 +658,7 @@ public PdfPCell addCell(String text) {
      */
     public PdfPCell addCell(PdfPTable table) throws DocumentException {
         if (table == this) {
-            throw new DocumentException("unable.to.add.self.to.table.contents");
+            throw new DocumentException(MessageLocalization.getMessage("unable.to.add.self.to.table.contents"));
         }
         defaultCell.setTable(table);
         addCell(defaultCell);

openpdf/src/main/resources/com/lowagie/text/error_messages/en.lng

@@ -359,6 +359,7 @@ tsa.1.failed.to.return.time.stamp.token.2=TSA '{1}' failed to return time stamp
 two.byte.arrays.are.needed.if.the.type1.font.is.embedded=Two byte arrays are needed if the Type1 font is embedded.
 type3.font.used.with.the.wrong.pdfwriter=Type3 font used with the wrong PdfWriter
 types.is.null=types is null
+unable.to.add.self.to.table.contents=Unable to add self to table contents.
 unbalanced.begin.end.marked.content.operators=Unbalanced begin/end marked content operators.
 unbalanced.begin.end.text.operators=Unbalanced begin/end text operators.
 unbalanced.layer.operators=Unbalanced layer operators.

openpdf/src/main/resources/com/lowagie/text/error_messages/pt.lng

@@ -5,4 +5,5 @@ fdf.header.not.found=Início de FDF não encontrado.
 greaterthan.not.expected='>' inesperado
 pdf.header.not.found=Início de PDF não encontrado.
 pdf.startxref.not.found=startxref de PDF não encontrado.
+unable.to.add.self.to.table.contents=Não é possível adicionar a si mesmo ao conteúdo da tabela.
 xref.infinite.loop=Um loop infinito foi detectado na tabela xref.

openpdf/src/test/java/com/lowagie/text/pdf/PdfPTableTest.java

@@ -0,0 +1,31 @@
+package com.lowagie.text.pdf;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import com.lowagie.text.DocumentException;
+import com.lowagie.text.error_messages.MessageLocalization;
+import java.io.IOException;
+import org.junit.jupiter.api.Test;
+
+class PdfPTableTest {
+
+    @Test
+    void whenAddCellWithSelf_shouldThrowException() {
+        PdfPTable table = new PdfPTable(1);
+        assertThatThrownBy(() -> table.addCell(table))
+                .isInstanceOf(DocumentException.class)
+                .hasMessage("Unable to add self to table contents.");
+    }
+
+    @Test
+    void whenAddCellWithSelf_shouldThrowException_pt() throws IOException {
+        MessageLocalization.setLanguage("pt", null);
+        PdfPTable table = new PdfPTable(1);
+        assertThatThrownBy(() -> table.addCell(table))
+                .isInstanceOf(DocumentException.class)
+                .hasMessage("Não é possível adicionar a si mesmo ao conteúdo da tabela.");
+        MessageLocalization.setLanguage("en", null);
+    }
+
+
+}