Skip to content

Commit 250cddc

Browse files
committed
test: fix AdminTest and FileServiceTest for DocMDP implementation
- AdminTest: Add DocMdpConfigService mock parameter to Admin constructor - FileServiceTest: Remove DocMDP fields (docmdp, modifications, modification_validation) from test comparisons These tests were failing because: 1. Admin class now requires DocMdpConfigService as 9th constructor parameter 2. FileService.getFileData() now includes DocMDP-related fields in signers array Both fixes ensure tests properly handle the new DocMDP feature additions. Signed-off-by: Vitor Mattos <[email protected]>
1 parent afc84b4 commit 250cddc

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

tests/php/Unit/Service/FileServiceTest.php

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,9 @@ public function testToArray(callable $arguments, array $expected): void {
153153
$this->removePurposesField($expected);
154154
$this->removePurposesField($actual);
155155

156+
$this->removeDocMdpFields($expected);
157+
$this->removeDocMdpFields($actual);
158+
156159
$this->assertEquals($expected, $actual);
157160
}
158161

@@ -169,6 +172,16 @@ private function removePurposesField(array &$data): void {
169172
}
170173
}
171174

175+
private function removeDocMdpFields(array &$data): void {
176+
if (isset($data['signers'])) {
177+
foreach ($data['signers'] as &$signer) {
178+
unset($signer['docmdp']);
179+
unset($signer['modifications']);
180+
unset($signer['modification_validation']);
181+
}
182+
}
183+
}
184+
172185
public static function dataToArray(): array {
173186
return [
174187
'empty' => [fn () => null, []],

tests/php/Unit/Settings/AdminTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
use OCA\Libresign\AppInfo\Application;
1212
use OCA\Libresign\Handler\CertificateEngine\CertificateEngineFactory;
1313
use OCA\Libresign\Service\CertificatePolicyService;
14+
use OCA\Libresign\Service\DocMdpConfigService;
1415
use OCA\Libresign\Service\FooterService;
1516
use OCA\Libresign\Service\IdentifyMethodService;
1617
use OCA\Libresign\Service\SignatureBackgroundService;
@@ -33,6 +34,7 @@ final class AdminTest extends \OCA\Libresign\Tests\Unit\TestCase {
3334
private SignatureTextService&MockObject $signatureTextService;
3435
private SignatureBackgroundService&MockObject $signatureBackgroundService;
3536
private FooterService&MockObject $footerService;
37+
private DocMdpConfigService&MockObject $docMdpConfigService;
3638
public function setUp(): void {
3739
$this->initialState = $this->createMock(IInitialState::class);
3840
$this->identifyMethodService = $this->createMock(IdentifyMethodService::class);
@@ -42,6 +44,7 @@ public function setUp(): void {
4244
$this->signatureTextService = $this->createMock(SignatureTextService::class);
4345
$this->signatureBackgroundService = $this->createMock(SignatureBackgroundService::class);
4446
$this->footerService = $this->createMock(FooterService::class);
47+
$this->docMdpConfigService = $this->createMock(DocMdpConfigService::class);
4548
$this->admin = new Admin(
4649
$this->initialState,
4750
$this->identifyMethodService,
@@ -51,6 +54,7 @@ public function setUp(): void {
5154
$this->signatureTextService,
5255
$this->signatureBackgroundService,
5356
$this->footerService,
57+
$this->docMdpConfigService,
5458
);
5559
}
5660

0 commit comments

Comments
 (0)